Commit Graph

864 Commits

Author SHA1 Message Date
Andy Joslin
975f760899 refactor($ionicPopup): remove test/temp code 2014-04-10 07:49:45 -06:00
Andy Joslin
235ffcbd2d refactor(ionInfiniteScroll): stop error on destroy 2014-04-10 07:48:48 -06:00
Andy Joslin
698c93fcaf fix($ionicPopup): stop race condition with show then hide
Addresses #1100.
2014-04-10 07:48:45 -06:00
Andy Joslin
eb1dee9303 fix($ionicLoading): stop race condition with show and hide
Fixes #1100.
2014-04-10 07:47:45 -06:00
Andy Joslin
56eb2cf31f docs(ionNavBar): chiefly recommend 'nav-title-slide-ios7' animation 2014-04-09 15:41:43 -06:00
Andy Joslin
1809ce2cac style(ionRefresher): pulling-text, refreshing-text default to ' '
Fixes #1052.
2014-04-09 15:17:21 -06:00
Andy Joslin
08da6f753c fix(ionInfiniteScroll): remove listener on $destroy 2014-04-09 08:34:05 -06:00
Andy Joslin
d58fff72de fix(ionInfiniteScroll): work properly if past horizontal boundaries
Fixes #1073

ion-infinite-scroll will now fire a scroll event if the user scrolls
past the left boundaries (if they exist) or the top boundaries (if they
exists).  This means infinite scroll works for vertical, horizontal, or
vertical plus horizontal scrolling situations.
2014-04-09 07:51:14 -06:00
Andy Joslin
426a35539e refactor($ionicLoading): keep old options.showBackdrop, but undocumented 2014-04-09 07:09:40 -06:00
Andy Joslin
3b2e2c9f5e refactor($ionicLoading): cleanup deprecations 2014-04-09 07:00:15 -06:00
Andy Joslin
d36a6f3ba9 refactor($ionicLoading): opts: +template,+templateUrl, deprecate content 2014-04-09 06:55:06 -06:00
Andy Joslin
c7d7dab75f refactor($ionicLoading): make sure .hide() always happens after .show()
Fixes #1085.  Thanks @graemefoster.
2014-04-09 06:41:43 -06:00
Andy Joslin
d0b47d879f test($ionicLoading): re-add missing unit tests 2014-04-08 15:00:41 -06:00
Andy Joslin
cb1a5f6228 refactor($ionicPopup): add close() to returned promise, change closing
BREAKING CHANGE: $ionicPopup.show()'s button onTap function has changed.

When using `$ionicPopup.show()`, previously a button's onTap function
would only result in closing the popup and resolving the promise if the
 `onTap(event)` function returned a truthy value.

Now, a button's onTap event will *always* close the popup and resolve
the popup's promise, no matter the return value, by default. The only
way to prevent the popup from closing is to call
`event.preventDefault()`.

Change your code from this:

```js
$ionicPopup.show({
  buttons: [{
    onTap: function(event) {
      if (!shouldClosePopup) {
        return false;
      }
    }
  }]
});
```

To this:

```js
$ionicPopup.show({
  buttons: [{
    onTap: function(event) {
      if (!shouldClosePopup) {
        event.preventDefault();
      }
    }
  }]
});
```
2014-04-08 13:52:30 -06:00
Andy Joslin
98e7e3df46 refactor($ionicLoading,$ionicPopup): factor out common code, add tests
Also fixes $ionicLoading flickering on ios7 in beta.1.
2014-04-08 13:35:02 -06:00
Adam Bradley
8af018b1fa fix(scroll): Allow scrolling when touchstart target is an input, #1078 2014-04-08 14:28:12 -05:00
Andy Joslin
92c65f367b refactor(ionList): make sure attributes sync with delegate 2014-04-08 10:27:37 -06:00
Andy Joslin
933a555e08 feat($ionicNavBarDelegate): showBackButton returns whether bar is shown
Closes #1076

If the user for example switches tabs,
$ionicNavBarDelegate.getPreviousTitle() will return the title from the
navbar within the previous tab.  In this case, the back button will not
be shown.  To not use the previous title in a case like this, you can
now do:

```js
var shouldShowTitle = $ionicNavBarDelegate.showBackButton();
if (shouldShowTitle) {
  $scope.previousTitle = $ionicNavBarDelegate.getPreviousTitle();
}
```
2014-04-08 09:44:42 -06:00
Andy Joslin
24a415c32d feat($ionicNavBarDelegate): showBar returns whether navbar is shown 2014-04-08 09:44:28 -06:00
Robin van Baalen
518e54ee86 feat($ionicSideMenuDelegate): add isOpen() method
Closes #1074. Closes #1075.
2014-04-07 13:52:24 -06:00
Adam Bradley
dfbb376552 rename .checkbox-handle to .checkbox-icon 2014-04-07 14:03:48 -05:00
Adam Bradley
b0b446d5d9 fix(checkbox): Remove tap highlight and fix checkbox appearance in Firefox, closes #496 2014-04-07 13:25:54 -05:00
Andy Joslin
757f181931 fix(ionTab): make sure all tab-nav attributes are re-interpolated on change
Fixes #955.

Closes #1071.
2014-04-07 11:12:32 -06:00
Adam Bradley
5c300dd3e0 refactor(platform): Rename isCordova() to isWebView()
BREAKING CHANGE: ionic.Platform.isCordova() has been renamed to
ionic.Platform.isWebView()
2014-04-07 11:56:11 -05:00
Andy Joslin
c4a3d4ccbf test(navClear): remove ddescribe 2014-04-07 10:31:38 -06:00
Andy Joslin
4dffc5f6c6 fix(navClear): only set viewOptions if click leads to state change
Closes #1043
2014-04-07 10:21:00 -06:00
Andy Joslin
d6c960c2a6 feat(ionSlideBox): add pager-click attribute
Fixes #785
2014-04-07 10:21:00 -06:00
Adam Bradley
79f6b251c3 test(tap): Tests for ignoreTapInspect, recordCoordinates, isRecentTap 2014-04-07 11:07:31 -05:00
Adam Bradley
9d83b05580 test(tap): split apart ignoreSimulateClick tests 2014-04-07 10:01:53 -05:00
Adam Bradley
b7bb0db917 test(click): fix html test 2014-04-07 09:43:41 -05:00
Adam Bradley
a977332f2b fix(tap): Do not preventDefault after input focus, #1068 2014-04-07 09:43:41 -05:00
Andy Joslin
a19e3b62f8 feat($ionicModal): pass modal instance to modal.shown/modal.hidden events
Fixes #1065
2014-04-07 08:05:11 -06:00
Adam Bradley
e3c59e96a9 test(tap): add some more tests for taps 2014-04-07 00:44:29 -05:00
Adam Bradley
cf686548da fix(tap): Remove 300ms delay when tapping select elements 2014-04-05 23:43:12 -05:00
Adam Bradley
cb602b587b fix(tap): Prevent clicks from firing after scrolling, #579 2014-04-04 12:28:42 -05:00
Andy Joslin
986dbac893 refactor(ionList): more expressive, declarative (breaking change)
Closes #1024.

BREAKING CHANGE: ion-list syntax has changed in favor of simplicity &
flexibility.

Relevant documentation:
[ionList](http://ionicframework.com/docs/api/directive/ionList),
[ionItem](http://ionicframework.com/docs/api/directive/ionItem),
[ionOptionButton](http://ionicframework.com/docs/api/directive/ionOptionButton),
[ionReorderButton](http://ionicframework.com/docs/api/directive/ionReorderButton),
[ionDeleteButton](http://ionicframework.com/docs/api/directive/ionDeleteButton),
[$ionicListDelegate](http://ionicframework.com/docs/api/service/$ionicListDelegate).

To migrate, change your code from this:

```html
<ion-list option-buttons="[{text:'hello',type:'button-positive',onTap:tap()}]"
          on-delete="onDelete(el)"
          delete-icon="ion-minus-circled"
          can-delete="true"
          show-delete="shouldShowDelete"
          on-reorder="onReorder(el, startIndex, toIndex)"
          reorder-icon="ion-navicon"
          can-reorder="true"
          show-reorder="shouldShowReorder">
  <ion-item ng-repeat="item in items">
    {{item}}
  </ion-item>
</ion-list>
```

To this:

```html
<ion-list show-delete="shouldShowDelete"
          show-reorder="shouldShowReorder">
  <ion-item ng-repeat="item in items">
    {{item}}
    <ion-delete-button class="ion-minus-circled"
                       ng-click="onDelete(item)">
    </ion-delete-button>
    <ion-reorder-button class="ion-navicon"
                       ng-click="onReorder(item, $fromIndex, $toIndex)">
    </ion-reorder-button>
    <ion-option-button class="button-positive" ng-click="tap()">
      Hello
    </ion-option-button>
  </ion-item>
</ion-list>
```
2014-04-04 10:12:16 -06:00
Andy Joslin
ad12bffca7 refact(navClear): lower priority 2014-04-04 09:38:04 -06:00
Andy Joslin
ce42623176 style(navClear): remove unused dependencies 2014-04-04 09:37:32 -06:00
Andy Joslin
4f47bf24f0 fix(navClear): be sure it runs before ngClick
Closes #1047
2014-04-04 09:32:16 -06:00
Adam Bradley
3ee5ea77a6 fix(tap): Deactivate elements during scroll at the same time click is ignored, #997
Previously I disabled the activation class immediately on a touchmove,
where as the click will still work if you touchstart and touchend
within a few pixels of each other. So visually it may have looked like
the click shouldn't have worked. I just updated it so the use the same
numbers. For example, if you hold down an item and move just 5 pixels,
the item will stay active (before it wouldn't have), and the click will
fire. But at the same time, if you hold down an item, and move a larger
distance, once it realizes that it went farther than 6 pixels it'll not
allow a click to happen, AND it'll not show the item as being active.
2014-04-03 23:24:31 -05:00
Adam Bradley
0c1362861d refactor ionic.tap and start writing tests 2014-04-03 13:52:48 -05:00
Andy Joslin
21ff75479f fix($ionicPopup): make it work if jquery is included
Closes #1027
2014-04-03 11:55:13 -06:00
Andy Joslin
ad67184800 fix(refresher): get rid of flickers except on droid-4.4
Fixes #1014.
2014-04-03 11:29:08 -06:00
Adam Bradley
43ad2271d8 docs(scroll): Fix typo 2014-04-03 09:20:43 -05:00
Andy Joslin
972579383a feat(ionNavBar): make back button animated
Closes #1030
2014-04-02 19:35:09 -06:00
Mark Taylor
fbff104d39 Update ionicGesture.js
'Off' method name for docs
2014-04-02 15:55:18 -04:00
Adam Bradley
87d3a2590d Merge pull request #1028 from Cheguevara/patch-1
Update ionicRadio documentation
2014-04-02 14:24:27 -05:00
Adam Bradley
66ecec7031 fix(scroll): Fix input focus when tapped, do not scroll when target is an input, closes #1020 2014-04-02 14:22:56 -05:00
Cheguevara
078f54dbe8 Update ionicRadio.js 2014-04-02 21:46:59 +04:00
Adam Bradley
5f3a1d21c6 fix(tap): Prevent multiple clicks when overriding cordova object, closes #1022 2014-04-02 09:57:16 -05:00