824033f1d4
fix(react, vue): custom animations are used when going back ( #27895 )
...
Issue number: resolves #27873
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
Custom animations are not always used when the `handleNavigateBack`
method is called. This impacts both Ionic React and Ionic Vue.
While we do set the `incomingRouteParams` with the animation:
a08a5894ba/packages/react-router/src/ReactRouter/IonRouter.tsx (L247-L252)
We do sometimes call `handleNavigate`:
a08a5894ba/packages/react-router/src/ReactRouter/IonRouter.tsx (L273-L279)
This `handleNavigate` method sets `incomingRouteParams` again:
a08a5894ba/packages/react-router/src/ReactRouter/IonRouter.tsx (L225-L230)
Since we do not re-pass `routeAnimation`, that field gets set to
`undefined` and the custom animation does not get used.
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
- Custom animation is now passed to `handleNavigate`
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
Dev build: `7.2.2-dev.11690810887.180000d1`
2023-07-31 17:57:03 +00:00
87d83bb21b
chore(vue-router): add eslint and prettier ( #26636 )
2023-01-19 08:51:08 -05:00
c2e1ad385d
chore(many): replace any
types and add tech debt tickets ( #26293 )
...
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-01-06 09:34:55 -06:00
e3ef932ae1
chore(many): add tech debt tickets and remove unnecessary todos ( #26266 )
2022-11-14 14:49:08 -06:00
832788971a
fix(vue): go back to correct view with memory history ( #25732 )
...
resolves #25705
2022-08-08 12:28:54 -04:00
b4ba70ea14
fix(vue): switching between tabs and going back resolves to correct route ( #25206 )
...
resolves #24303
2022-04-29 10:11:55 -04:00
a0054a7cbd
fix(vue): ensure that only tab pages get added to the tab navigation stack ( #25045 )
...
resolves #24859
2022-04-12 10:22:36 -04:00
4534c8bc0b
fix(vue): tapping the active tab button now correctly resets the tab stack ( #24935 )
...
resolves #24934
2022-03-14 14:44:47 -04:00
721a461073
fix(vue): replacing routes now updates location state correctly ( #24721 )
...
resolves #24432
Co-authored-by: tigohenryschultz <tigohenryschultz@users.noreply.github.com>
Co-authored-by: yoyo930021 <yoyo930021@users.noreply.github.com>
2022-02-07 15:37:43 -05:00
0b18260da6
fix(vue): routing history is correctly replaced when overwriting browser history ( #24670 )
...
resolves #23873
2022-02-02 13:35:52 -05:00
90458da406
fix(vue): correct route is replaced when using router.replace ( #24533 )
...
resolves #24226
2022-01-10 11:58:35 -05:00
2054690f54
chore(): sync with main
2021-11-11 10:19:05 -05:00
7c43589b0a
fix(vue): canGoBack method now works correctly ( #24188 )
...
resolves #24109
2021-11-09 09:45:12 -05:00
7ab50dda83
chore(): sync with main
2021-10-22 15:24:34 -04:00
24659a527a
fix(vue): mount correct views when navigating ( #24056 )
...
resolves #23914
2021-10-14 11:28:36 -04:00
a09d7d4ab6
fix(vue): back button now selects correct route when navigating from view multiple times ( #24060 )
...
resolves #23987
2021-10-13 09:07:53 -04:00
c8cbe9c1f3
chore(): sync with main for beta 4
2021-08-18 09:42:03 -04:00
621f4faa1a
fix(vue): using router.go now shows correct view ( #23773 )
...
resolves #22563
2021-08-17 08:53:55 -04:00
fc9e1b4b36
feat(vue): extend useIonRouter hook for programmatic navigation with animation control ( #23499 )
...
resolves #23450
2021-06-28 10:33:32 -04:00
2e00dab95d
fix(vue): use correct history mode when doing ssr to avoid errors ( #23255 )
...
resolves #23254
2021-05-03 15:32:20 -04:00
7203190234
fix(react, vue): correct view now chosen when going back inside tabs ( #23154 )
...
resolves #23087
resolves #23101
2021-04-06 10:16:23 -04:00
943e3f6ae3
fix(react, vue): tab buttons no longer throw an error if href is undefined ( #22998 )
...
resolves #22997
2021-03-02 10:05:59 -05:00
cd8ffd82a0
fix(react, vue): navigating using ion-back-button now selects correct page ( #22974 )
...
resolves #22830
2021-02-25 13:18:20 -05:00
9e9a372497
fix(react, vue): do not show back button when replacing to root page ( #22750 )
...
resolves #22528
2021-01-13 10:10:44 -05:00
e3a05bfeb5
fix(vue): correctly determine leaving view when transitioning to a new instance of a previous page ( #22655 )
...
resolves #22654 resolves #22658
2020-12-16 16:45:28 -05:00
39bbb99f75
chore(vue): import animation types from @ionic/vue instead of @ionic/core ( #22677 )
2020-12-14 14:39:41 -05:00
a94e2a87fb
fix(vue): query strings are now correctly handled when navigating back ( #22615 )
...
resolves #22517
2020-12-07 15:17:31 -05:00
216f51b12a
fix(vue): correctly handle navigation failures ( #22621 )
...
resolves #22591
2020-12-03 12:44:16 -05:00
5a4d0c0217
fix(vue): ensure view is updated correctly when replacing a route outside of a nav guard ( #22429 )
...
resolves #22412
2020-11-04 16:44:51 -05:00
daf6a92127
fix(vue): correctly switch tabs after going back ( #22309 )
...
resolves #22307
2020-11-04 12:50:31 -05:00
31f9bc81d6
fix(vue): improve compatibility with route guards ( #22371 )
...
resolves #22344
2020-10-22 11:03:58 -04:00
561a4ac535
fix(vue): going back with query params now goes to correct view ( #22350 )
...
resolves #22324
2020-10-21 11:23:44 -04:00
39d2530427
fix(vue): correctly show ion-back-button when going back ( #22260 )
...
resolves #22217
2020-10-07 14:58:41 -04:00
6849dd3483
fix(vue): correctly handle query params ( #22253 )
...
resolves #22229
2020-10-06 14:12:40 -04:00
af2e6ca8d2
chore(vue): remove extra import
2020-09-11 11:37:53 -04:00
8227844cbc
fix(vue): canGoBack now returns correct result with initial load redirect ( #22071 )
2020-09-11 11:33:16 -04:00
a7f564b818
feat(vue): add hardware back button hook ( #22069 )
2020-09-11 11:20:48 -04:00
5ffa65f84a
feat(vue): add ionic vue beta ( #22062 )
2020-09-10 15:20:49 -04:00