Commit Graph

83 Commits

Author SHA1 Message Date
jgw96
f2894be061 test(tabs): update final tabs test 2017-03-06 11:18:55 -06:00
mhartington
33f2f09c5e test(tabs, segments, select, searchbar): update test to be lazy loaded 2017-03-06 12:11:00 -05:00
Dan Bucholtz
be79382386 test(e2e): refactor e2e tests to modular structure and utilize lazy loading where possible
refactor e2e tests to modular structure and utilize lazy loading where possible
2017-03-02 14:37:01 -06:00
Manu Mtz.-Almeida
738515879b fix(tabs): popToRoot catches the rejected promise 2017-02-28 17:50:42 +01:00
Brandy Carney
091545e8c5 chore(e2e): update tests to remove component name strings 2017-01-23 14:35:23 -05:00
Manu Mtz.-Almeida
ee2268f42a fix(alert): unhandled promise exception 2017-01-21 00:20:27 +01:00
Brandy Carney
c8c90572bc chore(scripts): update e2e prod build to work with ionic-app-scripts (#10083)
* chore(e2e): WIP to add files needed for app-scripts

* chore(e2e): WIP one e2e test building but with errors

* chore(e2e): move e2e.prod to working with app-scripts

move shared functions into util, add support for debug flag when
running e2e.prod / demos.prod which gets passed to app-scripts

* chore(build): fix app-scripts build for all e2e and demos

* chore(e2e): update ionic-angular import path

* chore(build): update dev paths to work with prod

* chore(e2e): get watch working with e2e prod

* docs(scripts): update README for running e2e and demos

closes #8411
closes #10023
2017-01-19 11:09:57 -05:00
Brandy Carney
d252fa49e5 chore(e2e): rename app-module.ts to app.module.ts for consistency
references #10023
2017-01-13 15:16:24 -05:00
Brandy Carney
f6cabcdbc7 test(tabs): fix ngc error in advanced test 2017-01-10 15:06:03 -05:00
Adam Bradley
7000b1b173 refactor: improve tree shaking abilities
Internal refactor completed in order to improve tree shaking and dead
code removal. The public API, with an exception to ion-slides, has
stayed the same. However, internally many changes were required so
bundlers could better exclude modules which should not be bundled.
Ultimately most changes resorted to removing references to `window` or
`document`, or a module that referenced one of those.

BREAKING CHANGES

ion-slides was refactored to remove the external dependencies, and
rewritten in TypeScript/ES6 modules to again improve tree shaking
abilities.
2017-01-09 09:51:39 -06:00
Adam Bradley
39e1dce72d fix(img): ensure scroll has been initialized 2016-12-07 15:59:20 -06:00
Adam Bradley
aec8f51b60 fix(virtual-scroll): fix tabs content loading 2016-12-07 14:46:58 -06:00
Brandy Carney
bb3a57f407 fix(tabs): make MD tab highlight the contrast color of tabs color 2016-12-06 17:45:02 -05:00
Brandy Carney
3b612d2bc0 fix(tabs): adjust the top of tabs each time the tab changes 2016-12-06 16:07:40 -05:00
Manu Mtz.-Almeida
907191bbc2 perf(tabs): improve tab switching response 2016-11-28 09:00:41 -06:00
Brandy Carney
b515f5251b refactor(toolbar): move border from toolbar to header/footer and increase opacity
This matches native iOS. Removed the `no-border-top` and
`no-border-bottom` from toolbars since it is only added to `ion-header`
and `ion-footer` now, and added `no-border` to each of those.
2016-11-23 17:54:05 -06:00
Brandy Carney
e7275f23c6 fix(tabs): update UI to match material design spec 2016-11-18 13:48:24 -05:00
Manu Mtz.-Almeida
04d61ee47a fix(nav): swipe to go back gesture
- smoother by debouncing touch events (reduces bank)
- dynamic animation duration
- intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item)

fixes #8919
fixes #8958
fixes #7934
2016-11-01 13:38:27 -05:00
Manu Mtz.-Almeida
033e1eae17 fix(nav): adds public willLoad lifecycle event
* fix(nav): adds public willLoad lifecycle event

* test(menu): adds more asserts
2016-11-01 13:12:29 -05:00
Manu Mtz.-Almeida
4f6a9b143c feat(tabs): tabsHideOnSubPages can be modified per tab
references #8970
2016-11-01 02:21:28 +01:00
Manu Mtz.-Almeida
060748b4cf test(tabs): adds show test
references #6412
2016-10-13 23:59:23 +02:00
Brandy Carney
9a4c2a0848 test(tabs): add e2e test for badges in tabs
references #8317
2016-10-11 15:49:45 -04:00
Manu Mtz.-Almeida
bcbe03c480 fix(icon): isActive="false" with ios mode
fixes #8435
2016-10-10 08:42:49 -05:00
Manu Mtz.-Almeida
ac8854772a fix(tabs): add TabHighlight to IONIC_DIRECTIVES
fixes #8294
2016-09-30 23:48:08 +02:00
Dan Bucholtz
248d0c1a9c chore(e2e): add css back to e2e tests where it was missing
add css back to e2e tests where it was missing
2016-09-27 16:48:27 -05:00
Adam Bradley
d7be8a80c0 test(ngmodule): update to ngmodule 2016-09-13 15:44:02 -05:00
Brandy Carney
55a0257dbc refactor(colors): color should be added as an input instead of directly adding the color to the component
BREAKING CHANGES:

Colors should be passed in the `color` input on components, not added
individually as an attribute on the component.

For example:

```
<ion-tabs primary>
```

Becomes

```
<ion-tabs color=”primary”>
```

Or to bind an expression to color:

```
<ion-navbar [color]="barColor">
   ...
</ion-navbar>
```

```ts
@Component({
  templateUrl: 'build/pages/about/about.html'
})
export class AboutPage {
  barColor: string;

  constructor(private nav: NavController, platform: Platform) {
    this.barColor = platform.is('android') ? 'primary' : 'light';
  }
}
```

Reason for this change:
It was difficult to dynamically add colors to components, especially if
the name of the color attribute was unknown in the template.
This change keeps the css flat since we aren’t chaining color
attributes on components and instead we assign a class to the component
which includes the color’s name.
This allows you to easily toggle a component between multiple colors.
Speeds up performance because we are no longer reading through all of
the attributes to grab the color ones.

references #7467
closes #7087 closes #7401 closes #7523
2016-08-23 17:16:55 -04:00
Brandy Carney
938864e8d0 refactor(button): add ion-button attribute and icon attributes to style buttons
BREAKING CHANGES:

- `<button>` becomes `<button ion-button>`
- `<a button>` becomes `<a ion-button>`
- `<button ion-item>` does not get the `ion-button` attribute
- Buttons inside of `<ion-item-options>` do get the `ion-button`
attribute
- Removed the `category` attribute, this should be passed in
`ion-button` instead.
- Button attributes added for icons in buttons: `icon-only`,
`icon-left`, and `icon-right`

closes #7466
2016-08-16 17:11:02 -04:00
Adam Bradley
8eb0667b79 test(tabs): fix navCtrl reference 2016-08-04 20:17:09 -05:00
Adam Bradley
3c493652b2 test(): update to public navCtrl convention 2016-08-04 13:50:15 -05:00
Brandy Carney
087e2f2480 revert(tabs): undo commit that removes tab sub pages
Fix advanced tabs test

This reverts
https://github.com/driftyco/ionic/commit/743de19ae898e83375b51ef9c376225
c8e63f0ef
2016-07-28 15:28:55 -05:00
Manu Mtz.-Almeida
ac8e4dce06 style(all): tslinter warnings 2016-07-19 13:31:46 -07:00
perry
4f52135c13 Revert "Revert "Merge branch 'master' of https://github.com/driftyco/ionic""
This reverts commit 4a6086c1f8.
2016-07-18 19:40:03 -05:00
perry
4a6086c1f8 Revert "Merge branch 'master' of https://github.com/driftyco/ionic"
This reverts commit 8945bf906d, reversing
changes made to f4fac225fa.
2016-07-18 19:24:56 -05:00
Adam Bradley
0386476879 test(nav): clean up NavController tests 2016-07-15 15:55:49 -05:00
Adam Bradley
0a7d865975 refactor(nav): create NavControllerBase and public abstract class
Use NavController as the public API, and NavControllerBase as the
internal API. Refactored all app/nav/tabs unit tests and created
centralized mocking functions.
2016-07-15 15:54:56 -05:00
Brandy Carney
d3be0af46d test(tabs): clean up tabs badges e2e test so it works 2016-07-08 17:14:41 -04:00
Brandy Carney
41064bf2be refactor(tabs): rename tab input/config options to be more clear/consistent
BREAKING CHANGES:

Tab input/config options have been renamed. The following options were
renamed:

- `tabbarHighlight` -> `tabsHighlight`
- `tabbarLayout` -> `tabsLayout`
- `tabSubPages` -> `tabsHideOnSubPages`
- `tabbarPlacement` -> `tabsPlacement`

The previous names have been deprecated. They will still work in the
current release but will be removed in the future so please update to
the new names.

references #7143
2016-07-07 13:09:00 -04:00
Manu Mtz.-Almeida
08f22fb82b docs(reorder): adds docs and demo for reorder directive 2016-06-29 17:35:33 +02:00
Adam Bradley
3cd31c3d17 fix(menu): fix content going under header
Closes #7084
2016-06-28 16:22:39 -05:00
Adam Bradley
4980659bd6 test(overlay): use injectable overlay controllers 2016-06-28 15:20:42 -05:00
Adam Bradley
060d064325 Merge branch '2.0' into layout-refactor
# Conflicts:
#	src/components/tabs/test/advanced/index.ts
2016-06-21 11:37:47 -05:00
Manu Mtz.-Almeida
2bff535e7b fix(tabs): swipeBackEnabled works with tabs as expected 2016-06-21 10:56:30 -05:00
Adam Bradley
3a7addf7b0 feat(toolbar): control toolbar borders on top/bottom
Toolbars can be stacked up vertically in `<ion-header>`,
`<ion-content>`, and `<ion-footer>` elements. However, toolbars also
come with borders on both the top and bottom of the toolbar. To give
developers full control of the design, Ionic also includes the
`no-border-bottom` and `no-border-top` attributes. For example,
sometimes two vertically stacked toolbars may have different background
colors, in this case it might be best to leave a border between them.
However, if they have the same background color, the app may look best
without a border between them. The main point here is, it's entirely up
to the app's design to decide when and when not to show borders between
toolbars, and to do so then each toolbar can individually set
`no-border-bottom` and `no-border-top` attributes.
2016-06-20 12:01:21 -05:00
Adam Bradley
2d680896e7 fix(tabs): hide tab's navbar when a page comes without a navbar
Closes #5556
2016-06-18 00:20:08 -05:00
Brandy Carney
1b882800f7 test(all): fix the tests that don't have ion-nav 2016-06-17 22:05:24 -04:00
Brandy Carney
927edfffcd refactor(tabs): remove all uses of ion-navbar-section 2016-06-17 13:51:30 -04:00
Adam Bradley
1a8f6d745d test(header): update header markup 2016-06-17 11:43:30 -05:00
Brandy Carney
af2228757f fix(tabs): don't add outline to the class name if it is a logo icon
fixes #6899
2016-06-17 11:42:18 -04:00
Adam Bradley
d13fa4e2cf refactor(structure): allow content to scroll under headers/footers 2016-06-16 11:28:02 -05:00