Commit Graph

183 Commits

Author SHA1 Message Date
Liam DeBeasi
e8fb9e7328 chore(): sync with main 2023-01-23 13:38:16 -05:00
Amanda Johnston
c2e1ad385d chore(many): replace any types and add tech debt tickets (#26293)
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-01-06 09:34:55 -06:00
Liam DeBeasi
96147ec1b0 fix(item): ios mode has correct padding (#26511) 2023-01-04 16:54:43 -05:00
ionitron
20829f54cd chore(): add updated snapshots 2022-12-20 16:03:24 +00:00
Liam DeBeasi
d54b9dfdc0 chore(): sync with main 2022-12-20 10:44:26 -05:00
Liam DeBeasi
bd05fccf58 test(config): update to playwright 1.29.0 (#26388) 2022-12-20 09:26:51 -05:00
Sean Perkins
eea91bbbe1 fix(item): align iOS font size to spec (#26445) 2022-12-08 16:24:02 -05:00
Amanda Johnston
e3ef932ae1 chore(many): add tech debt tickets and remove unnecessary todos (#26266) 2022-11-14 14:49:08 -06:00
Brandy Carney
2c36049a7f test(menu): migrate to playwright (#26187) 2022-11-14 10:46:52 -05:00
Liam DeBeasi
60054310af fix(menu): rtl menu no longer disappears on ios 15 (#25309)
resolves #25192
2022-05-19 14:16:52 -04:00
Sean Perkins
15c169043f chore(docs): remove manual documentation (#24984) 2022-04-21 12:31:51 -04:00
Sean Perkins
611832b0d5 fix(core): inherit aria attributes on host elements (#25156)
Resolves #20127
2022-04-21 10:50:56 -04:00
Amanda Smith
da89684877 fix(menu): preserve scroll position when focusing on open (#25044) 2022-04-08 16:01:08 -05:00
Liam DeBeasi
5676bab316 lint(eslint): migrate to eslint and prettier (#25046) 2022-04-04 11:12:53 -04:00
Sean Perkins
2af24494f5 chore(playwright): enable type checking (#25034) 2022-03-31 15:42:09 -04:00
Liam DeBeasi
4b5843ed5d test(): update other tests to use the new path update (#24841) 2022-03-02 09:23:18 -05:00
Sean Perkins
836c01c73e fix(modal): re-enable swipe gestures when modal is dismissed (#24846)
Resolves #24817
2022-02-24 15:57:18 -05:00
Sean Perkins
19ac2389eb fix(img): draggable attribute is now inherited to inner img element (#24781)
Resolves #21325

Co-authored-by: Celilsemi Sam Erkiner <celilsemi@erkiner.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2022-02-21 11:50:57 -05:00
Liam DeBeasi
632dafcd57 fix(menu): focus trapping with menu and overlays no longer results in errors (#24611)
resolves #24361, #24481
2022-01-25 10:09:37 -05:00
Liam DeBeasi
7704ac3a37 fix(menu): remove main attribute that was supposed to removed in v5 (#24565)
resolves #24563
2022-01-12 11:52:37 -05:00
Liam DeBeasi
9c540583b2 chore(): sync with main for rc1 2021-10-27 09:21:44 -04:00
Amanda Smith
bdb268aa12 fix(menu): added focus trapping, improved compatibility with screen readers (#24076)
* fix(menu): add basic accessibility features

* fix(menu): add focus trapping

* test(menu): add test for focus trapping

* style(menu): lint fixes

* fix(menu): focus first element inside instead of whole menu

* test(menu): fix focus trap test to account for new behavior

* refactor(menu): pull focus handler into its own prop

* test(menu): add a11y testing

* fix(menu): prevent nested aria landmark from header inside menu

* fix(menu): revert switch to nav element

* fix(menu): remove unnecessary import from test

* fix(menu): allow for custom aria-label

* fix(menu): move nested ARIA role logic to header for flexibility

* fix(item): only add focusable class if it actually is focusable

* fix(menu): allow focusing of menu itself, for a11y on menus with no focusable children

* fix(item): move isFocusable logic to state for better reactivity

* perf(item): only grab one focusable child

* fix(menu): hide page content from screen readers when menu is open

* fix(menu): fallback to focusing host element

* docs(menu): add comments

Co-authored-by: Liam DeBeasi <liamdebeasi@icloud.com>
2021-10-27 08:51:46 -04:00
Liam DeBeasi
8708095111 feat(all): add CustomEvents types to components that emit events (#23956)
resolves #22925

BREAKING CHANGE: The `RadioChangeEventDetail` interface has been removed in favor of `RadioGroupChangeEventDetail`.
2021-09-24 16:28:49 -04:00
Liam DeBeasi
c50d895370 feat(react): add custom elements bundle (#23896) 2021-09-13 14:53:28 -04:00
William Martin
879ab8ebda feat(menu): add console error for incorrect usage of contentId (#23871)
resolves #23810
2021-09-08 08:54:01 -04:00
Liam DeBeasi
7315e0157b chore(): switch to using disallow terminology (#23618) 2021-07-13 14:03:58 -04:00
Liam DeBeasi
f022464cf8 docs(menu, split-pane): update contentId docs to be more clear (#23008) 2021-03-03 10:40:39 -05:00
Adam Bradley
0de75afbef feat(custom-elements): add experimental custom elements build (#22863)
Co-authored-by: Liam DeBeasi <liamdebeasi@icloud.com>
2021-02-11 12:08:00 -05:00
Augusto Amaral
ff39d40255 docs(vue): fix menu usage example (#22624) 2020-12-07 11:42:18 -05:00
Brandy Carney
a9b2260100 test(core): add lang attr to html tag to resolve axe errors (#22410) 2020-11-02 17:08:03 -05:00
Liam DeBeasi
69d72f9c17 docs(vue): fix menuController import (#22392) 2020-10-29 16:43:37 -04:00
Liam DeBeasi
db2cac20fb docs(vue): update component usage examples for vue 3 (#22050) 2020-09-11 13:48:21 -04:00
Adam Bradley
ae47d77710 chore(api): internal updates required for stencil 2 upgrade (#21889)
Stencil 2 is removing deprecated APIs, and these are the remaining ones Ionic has been using.
2020-08-06 10:33:22 -05:00
Brandy Carney
687122127c docs(stencil): add stencil usage to components (#21261) 2020-05-12 20:35:48 -04:00
Liam DeBeasi
32ecdd6753 feat(gesture): add support for blurring active inputs on gesture start (#20638)
fixes #20588
2020-04-27 10:52:14 -04:00
Liam DeBeasi
50bc212d0b feat(menu): add parts support for backdrop, container (#20978) 2020-04-23 12:22:19 -04:00
Manu MA
976e68da5b refactor(): minor updates for next stencil version (#20787) 2020-03-24 11:59:07 -04:00
Liam DeBeasi
3252c2f8dc fix(menu): swipe gesture should not open menu when a modal is displayed (#20546)
fixes #20467
2020-02-19 08:57:42 -05:00
Liam DeBeasi
99d6069ecb docs(): remove mention of controllers (#20444)
resolves #20453
2020-02-12 09:55:58 -05:00
Brandy Carney
a25007f54f docs(react): update class usage to className (#20366) 2020-02-04 11:16:44 -05:00
Liam DeBeasi
b14471178e fix(menu): fix jump when dragging open (#20288)
fixes #20286
2020-01-24 15:22:51 -05:00
Liam DeBeasi
8732a10757 refactor(): remove deprecated controllers (#20165)
* remove action-sheet-controller and alert-controller

* rmeove loading controller

* remove popover controller

* remove toast controller

* remove picker-controller

* remove modal controller

* remove menu controller

* update menu ctrl in tests

* run linter

* remove window refs

* Update core/src/components/loading/test/standalone/index.html

Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>

* remove window from modal tests

* test

* testing timeout

* change timeout

Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
2020-01-14 12:09:35 -05:00
Brandy Carney
6fc1612f42 docs(breaking): add breaking changes for v5 (#20156) 2020-01-13 11:29:29 -05:00
Adam Bradley
3aa47e6e2f fix(ssr): reflect content-id attribute (#20169)
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
2020-01-08 21:36:30 -06:00
Masahiko Sakakibara
be0ab5c2ff chore(menu): change deprecated error message (#19717) 2019-11-07 18:58:32 -05:00
Liam DeBeasi
7bd4412889 fix(animation): track correctly when updating CSS Animation (#19813)
* fix bug

* update menu

* fix
2019-10-31 12:50:54 -04:00
Liam DeBeasi
96a5e600e5 feat(animation): cubic-bezier easing conversion utility (experimental) (#19788)
resolves #19789
2019-10-31 10:16:33 -04:00
Liam DeBeasi
d80f45516d feat(split-pane): convert to shadow component, add width, max-width, and min-width vars (#19754)
resolves #17088


Co-authored-by: troyanskiy <roman.rosluk@utopix.ch>
2019-10-30 14:16:39 -04:00
Liam DeBeasi
39fb8f6720 fix(menu): clicking backdrop closes menu properly (#19785) 2019-10-29 13:26:15 -04:00
Liam DeBeasi
e3233000c6 fix(menu): clamp out of bounds swipe value (#19684)
fixes #18927
2019-10-18 08:56:53 -04:00