13 Commits

Author SHA1 Message Date
d9e8b1bec6 refactor(nav-controller-base): cleanup some logic
NavControllerBase is the core of ionic 2 navigation. It handles all the transitions and it is complicated code to follow.
I am refactoring it to allow future developers and contributors to follow it better.

!node.parent now becomes node.isRoot()

ViewController does not remove itself from the stack, but two new auxiliar function in nav controller: _insertView() and _removeView() are used to add a view to the stack.

And so on...

All e2e and unit tests passing...
2016-10-18 16:36:55 +02:00
ba557acb4f fix(nav): ion-nav inside ion-content work properly 2016-10-15 02:59:57 +02:00
35568ba85f chore: removed deprecated APIs 2016-10-13 11:02:45 -05:00
ca3b9455d1 Merge pull request #8260 from vanackere/fix-viewcontroller-dismiss
Fix infinite loop (hang) in viewcontroller dismiss
2016-10-12 21:50:01 +02:00
451ffe1133 fix(nav): ionViewDidLoad is called in modals
fixes #8449
2016-10-12 11:38:44 -05:00
c8954d8a16 fix(nav): ionViewCanLeave does not break navigation
fixes #8408
2016-10-10 21:45:58 +02:00
9227310494 fix(ViewController): avoid deep copy in dismiss() that can turn into an infinite loop
For some reason, apparently related to the NavOptions.ev field,
this deep copy was turning into an infinite loop on a Nexus 7 / android 5.1.1 webview.
Replace with a non-deep copy since the deep copy is unnecessary in this case.
2016-10-03 12:01:45 +02:00
d5f71a448d fix(view-controller): dismiss does not crash when called more than once
fixes #8395
2016-10-02 17:15:23 +02:00
9b650229f7 fix(nav): push-pop pages too quickly
fixes #8319
2016-09-30 20:17:19 +02:00
dbfc183cac docs(): update docs 2016-09-26 21:11:54 -04:00
e26c425766 fix(navigation): move onWillDismiss and onDidDismiss, add unit tests 2016-09-22 21:37:50 -04:00
35193c42c4 fix(nav): move null assignment of _onWillDismiss 2016-09-19 08:30:17 -05:00
ed221eff1d refactor(nav): queue based transitions 2016-09-13 17:13:43 -05:00