Commit Graph

13 Commits

Author SHA1 Message Date
Liam DeBeasi
6326a3a9c1 chore: remove ref from checkout workflow (#27490)
Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Screenshots in a branch are currently compared against the screenshots
on `main`. While we ultimately need to compare against ground truths in
`main`, this can cause tests to seemingly fail at random. For example,
this branch was created based on
eb2772c0ce.
However,
381de0b3d3
was added to `main` after the first commit and has new screenshot diffs.

I do not have the latest ground truths for the changed screenshots in
this branch, so the screenshot tests failed in
https://github.com/ionic-team/ionic-framework/actions/runs/4995702351/jobs/8947969061
even though I did not change any component implementations.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Test runs in CI now run against the ground truths available in the
branch. When a commit is added to the merge queue, it will be tested
against the latest `main` and any commits ahead of it in the queue. As a
result, if there _is_ a conflict then the test run will fail at that
point and the commit will be removed from the merge queue.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
2023-05-18 14:16:54 +00:00
Liam DeBeasi
be9250692a chore(ci): core build caches api.txt (#27167)
<!-- Please refer to our contributing documentation for any questions on
submitting a pull request, or let us know here if you need any help:
https://ionicframework.com/docs/building/contributing -->

<!-- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation
for details. -->

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->


<!-- Issues are required for both bug fixes and features. -->
Unbuilt changes in `core` are not always being caught because the
`api.txt` file is not cached.

Stencil will potentially update both the `src/components.d.ts` and
`api.txt` files when there are built changes to the public API. We need
to check both files when accounting for unbuilt changes.

Example: https://github.com/ionic-team/ionic-framework/pull/25858

This had updates to `api.txt` that were not built.

Built changes PR:
https://github.com/ionic-team/ionic-framework/pull/25933

Example of this change catching `api.txt` changes as intended:
https://github.com/ionic-team/ionic-framework/pull/27165

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- GitHub Actions core build step caches `api.txt`

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
2023-04-11 16:36:58 +00:00
Liam DeBeasi
df6e8b7578 test(ci): do not upload Ionic Core source (#26473) 2022-12-12 17:32:51 -05:00
Liam DeBeasi
0f8b26f767 refactor(ci): do not cache node modules (#26265) 2022-11-14 13:55:46 -05:00
Liam DeBeasi
5e4892676c chore(ci): update actions versions (#26100) 2022-10-13 13:04:01 -04:00
Liam DeBeasi
2547b0b4e1 chore(ci): account for components.d.ts in clean build (#25769) 2022-08-16 17:17:24 -04:00
Liam DeBeasi
e5e0e24f76 fix(vue): canDismiss definition is now exposed (#25195) 2022-04-26 14:16:27 -04:00
Liam DeBeasi
0dd0646e9d chore(ci): ensure that the latest commit is pulled when checking out (#25063) 2022-04-06 10:40:01 -04:00
Liam DeBeasi
0aa6d124d6 test(e2e): add infrastructure for migration to playwright (#25033) 2022-03-31 11:23:21 -04:00
Liam DeBeasi
143b227d35 chore(): sync GitHub Actions with main 2021-11-02 09:21:41 -04:00
Liam DeBeasi
22be16f3f0 test(): allow core to use cached node modules (#24146) 2021-11-01 17:31:26 -04:00
Liam DeBeasi
fd59acd691 test(): add way of manually busting node module cache (#24145) 2021-11-01 17:00:25 -04:00
Liam DeBeasi
b5dbb3984c test(): migrate tests to GitHub Actions (#24029) 2021-11-01 15:41:00 -04:00