Commit Graph

13 Commits

Author SHA1 Message Date
Brandy Carney
f27c899d13 chore: remove unnecessary comments in PR template (#27358)
Removes the comments about reading the contributing guide from our pull
request template. GitHub recommends the contributing guide in a popup to
new contributors, and it also recommends it if anything has changed
recently.
2023-05-03 13:56:50 +00:00
Amanda Johnston
c9bddbdb4c chore(template): ask for issue number instead of URL (#27220)
Now that the PR description is used as the default commit message, the
issue a PR resolves is specified directly in the PR description.
However, the conventional-commits tool isn't smart enough to recognize
full issue URLs, only the issue number (e.g. `resolves #12345`). This PR
updates the template to nudge the description in this direction.
2023-04-17 20:31:39 +00:00
Liam DeBeasi
f6ec23774b chore(template): separate issue url from body (#27216)
Now that the default commit message uses the PR description, the
conventional commit tool is getting confused when it sees other URLs and
text that looks like issues (like hex colors).

Using the `-------` separates the issue URL from the rest of the PR
description and helps the conventional commits tool generate the
changelog correctly.

Example:
https://github.com/ionic-team/ionic-framework/releases/tag/v7.0.3-nightly.20230417

`item: ios active state has correct contrast` has issue 000 as the issue
the commit closes. This is happening because I mentioned the 000 hex
color in the commit description.
2023-04-17 18:16:09 +00:00
Liam DeBeasi
b1f5853cf0 chore(): update PR template (#27109)
* Update PULL_REQUEST_TEMPLATE.md

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>

---------

Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
2023-04-03 19:26:04 +00:00
Amanda Johnston
16a8b1e105 chore(templates): clarify process for updating docs (#25286) 2022-05-13 12:46:41 -05:00
Amanda Smith
38627ff277 chore(template): clarify that issue should be a link in PR template (#24775) 2022-02-11 09:31:35 -06:00
Sean Perkins
34cae57acc docs(contributing): update requirements for contributing (#24708) 2022-02-03 14:41:13 -05:00
Liam DeBeasi
0d17e05edc chore(docs): update PR wording 2019-04-09 11:13:35 -04:00
Brandy Carney
d87170db3a docs(github): update pull request template 2019-04-08 12:07:51 -04:00
dwieeb
2f66ae4f62 chore: extract v3 into its own repository (#16131)
These should be the necessary changes to move v3 source code & issues to the new home for Ionic 3: https://github.com/ionic-team/ionic-v3
2018-10-29 15:10:29 -05:00
Masahiko Sakakibara
7887550166 chore(github): add Ionic version 4.x to PR template (#14219) 2018-03-29 16:31:37 -04:00
Amit Moryossef
b07eb1afad docs(.github): add v3 for github documents (#10945)
* docs(issue_template): add ionic v3 for issue template

Now that v3 is officially in beta, this is needed for bug reports

* docs(pull_request_template): add ionic v3 for pull request template
2017-04-06 18:31:51 -04:00
Justin Willis
149d8dccfa chore(): add github folder back 2016-06-24 14:58:03 -05:00