Commit Graph

18 Commits

Author SHA1 Message Date
Adam Bradley
b6c7f3f2d0 test(tap): fix tap tests from tolerance change 2014-12-15 10:40:37 -06:00
Adam Bradley
caf1272186 fix(scroll): remove isContentEditable from ignoreScrollStart
If an element isContentEditable, do not ignoreScrollStart incase users
are using contenteditable elements to scroll. This may have originally
been put in because it disabled text selection, and moving the text
cursor on touch. But this doesn’t seem to be the case anymore, so it
may have been put in for platform versions we no longer support. Also
fix the data-prevent-scroll dataset attribute. Closes #2091
2014-08-29 23:35:07 -05:00
Adam Bradley
df57858521 fix(menuContent): gestures do not stop_browser_behavior
The gestures which were being added to side menu content were also
adding the `disable-user-behavior` class, which disabled
contenteditable elements. Now passing in the gesture option
stop_browser_behavior=false, along with adding the options param to the
gestures service. Fixes #421
2014-08-29 22:25:55 -05:00
Adam Bradley
944d2595af fix(sideMenu): fix stopping content scrolling
When a list was within a side menu it could scroll up and down, but if
the user happened to drag a little bit on the X axis, then it would try
to open the side menu and the Y scroll of the content stopped. Closes
#1541
2014-08-07 12:22:28 -05:00
Perry Govier
889482e048 fix(tap): fire input behavior when tap/clicking file input label. Closes #1699 2014-07-02 18:27:07 -05:00
Adam Bradley
2e3b854658 fix(tap): get containing label of deeply nested element
The `tapContainingElement` method was not working correctly to climb up
the DOM of a clicked element to potentially find an ancestor label
element. Closes #1643
2014-06-18 15:03:52 -05:00
Tim Lancina
ad08b341ce fix(keyboard):don't setKeyboardShow on date/time inputs
Closes #1638.
2014-06-18 14:33:34 -05:00
Adam Bradley
e5b81c3bee test(tap): update tests so nodeType exists 2014-06-16 15:28:42 -05:00
Adam Bradley
7059b818ce fix(tap): select tag not working in IE
Cannot prevent default on mousedown in IE when the target is an option
or select element. Closes #1435
2014-05-20 09:13:17 -05:00
Adam Bradley
da0c798ce5 test(tap): updates for release tolerance changes 2014-05-16 14:40:40 -05:00
Adam Bradley
29ee640701 fix(click): fix mouseup click for ion-option-button
To allow select elements to change options in Firefox, the simulated
tap click should not go through when the target is an `option` element.
However, the regex was too general and also prevented
`ion-option-button` on mouseup.
2014-05-15 09:43:20 -05:00
Andrew Joslin
0ed975124d test(tap): expect falsy instead of false 2014-05-14 08:41:24 -06:00
Adam Bradley
8730e62e62 fix(tap): Prevent different input focus after 300ms delay
If a text input is located in the same area as a button which was just
tapped, which was probably because of a view transition, the text input
gets focus 300ms later. This is an issue on Android because it also
fires off a mousedown event. Resolved by remembering the touchend
target then checking if it’s different from the mousedown target.
Closes #1370
2014-05-08 10:40:15 -05:00
Andrew Joslin
95d1aea4f1 chore(travis): re-enable jshint 2014-05-08 09:11:16 -06:00
Adam Bradley
08e4b3d95b feat(platform): added isWindowsPhone() method 2014-05-07 14:48:36 -05:00
Adam Bradley
08bc005766 fix select element click tests 2014-05-01 12:45:12 -05:00
Adam Bradley
05a6d7cca6 fix(tap): input[file] clicks within ion-content, closes #1237 2014-05-01 08:54:13 -05:00
Adam Bradley
ae3318a081 refactor(keyboard): Scroll to inputs hidden by keyboard 2014-04-24 20:22:16 -05:00