Commit Graph

64 Commits

Author SHA1 Message Date
Manu Mtz.-Almeida
451ffe1133 fix(nav): ionViewDidLoad is called in modals
fixes #8449
2016-10-12 11:38:44 -05:00
Brandy Carney
2b7e83c1e1 test(modal): fix modal e2e test errors with forms 2016-10-12 11:43:43 -04:00
Manu Mtz.-Almeida
c9f4a4123f test(modal): adds e2e tests for open rc0 issues
references #8616
references #8597
references #8573
2016-10-10 19:15:05 +02:00
Alex Muramoto
45ea189fa2 docs(): update modal and searchbar docs
* docs(input): fix typo

* docs(scroll): add note about required CSS for scrollY

* docs(config): add swipeBackEnabled to config properties list

* docs(component generator): fix broken link in template comment

* docs(directive generator): fix broken link in template comment

* docs(modal): add that modal is not reusable

* docs (searchbar): update description of debounce
2016-09-30 13:48:03 -04:00
Adam Bradley
d8ecf16feb refactor(nav): do not auto-add pascal case css class
Previously a css class generated from the JS class name, was
automatically being added to the page element. However, the JS class
name returned is not consistent among all browsers. Instead of
automatically applying a css classname, we now recommend adding a
`selector` to each page component.
2016-09-26 00:40:10 +01:00
Dan Bucholtz
83d973b1a8 chore(demos): change dgeni path for demos
change dgeni path for demos
2016-09-20 15:20:04 -05:00
Adam Bradley
7c05d0c0ba fix(di): update dependency injection and default configs 2016-09-16 00:49:09 -05:00
Brandy Carney
bc7d328bc0 refactor(components): add color/mode properties 2016-09-13 17:11:38 -05:00
Adam Bradley
52ada1ca6d chore(components): ngmodule updates 2016-09-13 17:07:33 -05:00
Brandy Carney
750cde38e2 refactor(css): scope component css to mode 2016-09-13 16:52:47 -05:00
Adam Bradley
d7be8a80c0 test(ngmodule): update to ngmodule 2016-09-13 15:44:02 -05:00
Brandy Carney
55a0257dbc refactor(colors): color should be added as an input instead of directly adding the color to the component
BREAKING CHANGES:

Colors should be passed in the `color` input on components, not added
individually as an attribute on the component.

For example:

```
<ion-tabs primary>
```

Becomes

```
<ion-tabs color=”primary”>
```

Or to bind an expression to color:

```
<ion-navbar [color]="barColor">
   ...
</ion-navbar>
```

```ts
@Component({
  templateUrl: 'build/pages/about/about.html'
})
export class AboutPage {
  barColor: string;

  constructor(private nav: NavController, platform: Platform) {
    this.barColor = platform.is('android') ? 'primary' : 'light';
  }
}
```

Reason for this change:
It was difficult to dynamically add colors to components, especially if
the name of the color attribute was unknown in the template.
This change keeps the css flat since we aren’t chaining color
attributes on components and instead we assign a class to the component
which includes the color’s name.
This allows you to easily toggle a component between multiple colors.
Speeds up performance because we are no longer reading through all of
the attributes to grab the color ones.

references #7467
closes #7087 closes #7401 closes #7523
2016-08-23 17:16:55 -04:00
Brandy Carney
938864e8d0 refactor(button): add ion-button attribute and icon attributes to style buttons
BREAKING CHANGES:

- `<button>` becomes `<button ion-button>`
- `<a button>` becomes `<a ion-button>`
- `<button ion-item>` does not get the `ion-button` attribute
- Buttons inside of `<ion-item-options>` do get the `ion-button`
attribute
- Removed the `category` attribute, this should be passed in
`ion-button` instead.
- Button attributes added for icons in buttons: `icon-only`,
`icon-left`, and `icon-right`

closes #7466
2016-08-16 17:11:02 -04:00
Adam Bradley
a4e393b619 fix(nav): fire lifecycle events from app root portal 2016-08-04 22:47:36 -05:00
Adam Bradley
3c493652b2 test(): update to public navCtrl convention 2016-08-04 13:50:15 -05:00
Adam Bradley
61a86253a8 fix(nav): register child nav when created from modal 2016-08-04 11:49:21 -05:00
Manu Mtz.-Almeida
ac8e4dce06 style(all): tslinter warnings 2016-07-19 13:31:46 -07:00
perry
4f52135c13 Revert "Revert "Merge branch 'master' of https://github.com/driftyco/ionic""
This reverts commit 4a6086c1f8.
2016-07-18 19:40:03 -05:00
perry
4a6086c1f8 Revert "Merge branch 'master' of https://github.com/driftyco/ionic"
This reverts commit 8945bf906d, reversing
changes made to f4fac225fa.
2016-07-18 19:24:56 -05:00
Manu Mtz.-Almeida
cac378f35b fix(menu): only one menu can be opened at a time
fixes #6826
2016-07-17 20:42:29 -05:00
Adam Bradley
0386476879 test(nav): clean up NavController tests 2016-07-15 15:55:49 -05:00
Adam Bradley
cca3309f4c chore(nav): create nav-interfaces file 2016-07-11 23:24:25 -05:00
Adam Bradley
da6215c08e test(modal): add provider tests
Related #7160
2016-07-01 20:30:28 -05:00
Adam Bradley
656426672c chore(templates): import required directives for ionic templates 2016-07-01 00:59:37 -05:00
Adam Bradley
4d56219a4c refactor(forms): upgrade to @angular/forms 2016-06-30 21:54:48 -05:00
mhartington
fbe6f82c89 docs(alert, loading, modal): update docs 2016-06-30 15:02:19 -04:00
Manu Mtz.-Almeida
ec99bfd019 feat(viewcontroller): add onWillDismiss callback
Fixed #6702
2016-06-30 08:06:19 -05:00
Adam Bradley
4980659bd6 test(overlay): use injectable overlay controllers 2016-06-28 15:20:42 -05:00
Adam Bradley
215c6d846c refactor(overlays): inject overlay providers
BREAKING CHANGES:

- Overlay components, such as Alert or Modals, should now be created
using its injected provider.
- Overlays now have the `present()` method on the overlay’s instance,
rather than using `nav.present(overlayInstance)`.
- All overlays now present on top of all app content, to include menus.
- Below is an example of the change to `Alert`, but the pattern is the
same for all overlays: ActionSheet, Loading, Modal, Picker, Popover,
Toast

WAS:

```
import { NavController, Alert } from ‘ionic-angular’;

constructor(private nav: NavController) {
}

doAlert() {
  let alert = Alert.create({
    title: 'Alert',
  });
  this.nav.present(alert);
}
```

NOW:

```
import { AlertController } from ‘ionic-angular’;

constructor(private alertCtrl: AlertController) {
}

doAlert() {
  let alert = this.alertCtrl.create({
    title: 'Alert'
  });
  alert.present();
}
```
2016-06-28 15:18:09 -05:00
Edd Hannay
0948ad05eb docs(modal): remove unused Page component import
The Page decorator usage was removed in 73635f3939.
2016-06-27 13:59:36 -04:00
Adam Bradley
c7fa9490bf style(imports): add spaces in imports 2016-06-22 14:29:27 -05:00
Brandy Carney
6e34739249 fix(modal): add class name to modal
fixes #7000
2016-06-21 18:06:48 -04:00
Adam Bradley
3a7addf7b0 feat(toolbar): control toolbar borders on top/bottom
Toolbars can be stacked up vertically in `<ion-header>`,
`<ion-content>`, and `<ion-footer>` elements. However, toolbars also
come with borders on both the top and bottom of the toolbar. To give
developers full control of the design, Ionic also includes the
`no-border-bottom` and `no-border-top` attributes. For example,
sometimes two vertically stacked toolbars may have different background
colors, in this case it might be best to leave a border between them.
However, if they have the same background color, the app may look best
without a border between them. The main point here is, it's entirely up
to the app's design to decide when and when not to show borders between
toolbars, and to do so then each toolbar can individually set
`no-border-bottom` and `no-border-top` attributes.
2016-06-20 12:01:21 -05:00
Adam Bradley
cdb1f8503c chore(sass): move z-index vars to separate file, remove unused vars 2016-06-17 23:21:15 -05:00
Adam Bradley
1a8f6d745d test(header): update header markup 2016-06-17 11:43:30 -05:00
Adam Bradley
b3b7eb4626 refactor(modal): add css classes after createComponent 2016-06-16 15:27:07 -05:00
Adam Bradley
d13fa4e2cf refactor(structure): allow content to scroll under headers/footers 2016-06-16 11:28:02 -05:00
Brandy Carney
01bbc940d1 fix(modal): change modal display so you can scroll the entire height
fixes #6839
2016-06-15 10:57:38 -04:00
Dan Bucholtz
e5473b6759 feat(modal): background click and escape key dismiss (#6831)
background click and escape key dismiss

closes #6738
2016-06-09 15:03:11 -05:00
Adam Bradley
c1d09dd6b2 refactor(nav): replace DynamicComponentLoader w/ ComponentFactory 2016-06-08 16:42:23 -05:00
Dan Bucholtz
cb1cacab42 refactor(inset-modal): inset-modal fixes (#6809)
inset-modal fixes
2016-06-08 12:23:47 -05:00
Adam Bradley
9f293e8549 feat(navPop): add nav pop method on the app instance 2016-06-08 10:42:19 -05:00
Manu Mtz.-Almeida
a1a582b7a1 fix(ion-backdrop): new ion-backdrop can prevent background scrolling
closes #6656
2016-06-02 17:09:44 +02:00
Dan Bucholtz
d26e3aee58 refactor(modal): import ElementRef, fix no-implicit-any error
import ElementRef, fix no-implicit-any error
2016-06-02 10:05:59 -05:00
Adam Bradley
3f8add9af2 refactor(modal): modal updates, additional animation options
* refactor(modal): cleaned up scss for modal/inset-modal, added functionality to pass animation to vie

cleaned up scss for modal/inset-modal, added functionality to pass animation to view-contro

* refactor(exports): exporting gestures so other apps can consume them

exporting gestures so other apps can consume them
2016-06-01 20:41:07 -05:00
Adam Bradley
2eb88fa687 test(lifecycle): update lifecycle events 2016-06-01 12:19:08 -05:00
Adam Bradley
11448dcd0c chore(tslint): fix noImplicitAny errors 2016-05-31 21:07:17 -05:00
Dan Bucholtz
9a86e4bdf8 refactor(modal): cleaned up scss for modal/inset-modal, added functionality to pass animation to vie
cleaned up scss for modal/inset-modal, added functionality to pass animation to view-contro
2016-05-31 17:09:08 -05:00
Adam Bradley
6e9087534d test(bootstrap): update to use ionicBootstrap 2016-05-31 15:49:12 -05:00
Adam Bradley
73635f3939 refactor(bootstrap): use ionicBootstrap() to bootstrap
BREAKING CHANGES:

- Ionic's custom decorators have been removed.
- `@App` and `@Page` should be replaced with `@Component`.
- `IonicApp` has been renamed to `App`.
- `ionicBootstrap` is required to bootstrap the app.
- Config is now the 3rd parameter in `ionicBootstrap(rootComponent,
providers, config)`.
- Property `prodMode` is now a config option, enabling or disabling
production mode.
2016-05-31 15:42:06 -05:00