Commit Graph

33 Commits

Author SHA1 Message Date
Andy Joslin
dbe4e3901d feat(ionic): remove all delegates
BREAKING CHANGE: $ionicScrollDelegate, $ionicSlideBoxDelegate, and
$ionicSideMenuDelegate have been removed.

  - $ionicScrollDelegate has been changed to $ionicScrollController.
    Documentation:
    [ionContent](
    http://ajoslin.github.io/docs/nightly/api/directive/ionContent),
    [ionScroll](
    http://ajoslin.github.io/docs/nightly/api/directive/ionScroll)

    Change your code from this:

    ```html
    <ion-content ng-controller="MyCtrl">
      <button ng-click="scrollBottom()">Scroll to bottom!</button>
    </ion-content>
    ```
    ```js
    function MyCtrl($scope, $ionicScrollDelegate) {
      $scope.scrollBottom = function() {
        $ionicScrollDelegate.scrollBottom();
      };
    }
    ```

    To this:

    ```html
    <!-- optional attr controller-bind, see docs -->
    <ion-content ng-controller="MyCtrl">
      <button ng-click="scrollBottom()">Scroll to bottom!</button>
    </ion-content>
    ```
    ```js
    function MyCtrl($scope) {
      $scope.scrollBottom = function() {
        $scope.$ionicScrollController.scrollBottom();
      };
    }
    ```

  - $ionicSideMenuDelegate has been changed to
    $ionicSideMenusController. Documentation:
    [ionSideMenus](http://ajoslin.github.io/docs/nightly/api/directive/ionSideMenus)

    Change your code from this:

    ```html
    <ion-side-menus>
      <ion-side-menu side="left">Side Menu Left</ion-side-menu>
      <ion-pane ion-side-menu-content ng-controller="MyCtrl">
        <button ng-click="toggleLeftMenu()">
          Toggle Left Menu!
        </button>
      </ion-pane>
    </ion-side-menus>
    ```
    ```js
    function MyCtrl($scope, $ionicSideMenuDelegate) {
      $scope.toggleLeftMenu = function() {
        $ionicSideMenuDelegate.toggleLeft();
      };
    }
    ```

    To this:

    ```html
    <!-- optional attr controller-bind, see documentation -->
    <ion-side-menus>
      <ion-side-menu side="left">Side Menu Left</ion-side-menu>
      <ion-pane ion-side-menu-content ng-controller="MyCtrl">
        <button ng-click="toggleLeftMenu()">
          Toggle Left Menu!
        </button>
      </ion-pane>
    </ion-side-menus>
    ```
    ```js
    function MyCtrl($scope) {
      $scope.toggleLeftMenu = function() {
        $scope.$ionicSideMenuController.toggleLeft();
      };
    }
    ```

  - $ionicSlideBoxDelegate has been removed and upgraded to
    $ionicSlideBoxController. It had only one method that
    was unneeded.  [Documentation](
    http://ajoslin.github.io/docs/nightly/api/directive/ionSlideBox)
2014-03-19 11:51:07 -06:00
Andy Joslin
83f4776f53 chore: remove animation & type attributes, standard controller names 2014-03-18 14:54:21 -06:00
Andy Joslin
b630214fdf refactor(ionTabBar): remove tab.shown and tab.hidden events
Instead, use `on-select` and `on-deselect` attribute callbacks.

Alternatively, listen for $scope.$on('$destroy') in a controller inside
your tab.
2014-03-17 14:41:51 -06:00
Andy Joslin
aa30faf863 fix(ionTab): stop browser-tooltip from appearing due to title attr
Closes #804
2014-03-15 18:57:10 -06:00
Andy Joslin
4427e8778c feat(ionTab): allow custom ngClick expression that doesnt select tab
Closes #784
2014-03-15 09:45:32 -06:00
Andy Joslin
afdee2a47d test(ionicTabBar): update to reflect new controller api 2014-03-10 21:16:08 -06:00
Andy Joslin
ecfdbaa67b fix(ionTabs): do not pre-transclude; stops error on compile
Closes #730
2014-03-08 12:52:43 -07:00
Andy Joslin
d9f2c9f70e test(tabbar): remove ddescribe 2014-02-26 16:15:17 -05:00
Andy Joslin
bcca397c39 fix(ionTabBar): fix iconOn and iconOff being wrong 2014-02-26 16:09:34 -05:00
Andy Joslin
c4549bae4f refactor(tabs): dont pass href attribute to ionTabNav 2014-02-25 12:32:58 -05:00
Andy Joslin
3419e40e52 refactor(tabs): dont show icon if no icon defined 2014-02-25 12:04:58 -05:00
Andy Joslin
0f1b6f47b8 fix(ionTabs): cleanup and fix many issues
Closes #597. Fixes #634. Fixes #334. Fixes #175. Fixes #646. Closes #647.
2014-02-25 10:54:41 -05:00
Adam Bradley
7981e8e294 fix tab icon test 2014-02-21 09:50:09 -06:00
Adam Bradley
a0492f319c fix tabBar tests 2014-02-20 14:58:48 -06:00
Andy Joslin
2c39a21498 feat(ionic): prefix all directives with ion-
BREAKING CHANGE: All directives are now prefixed with `ion-`.

For any directive you use, add the ionic prefix.

For example, change this HTML:

```html
<tabs>
  <tab title="home" href="/tab/home">
    <content>Hello!</content>
  </tab>
</tabs>
```

To this HTML:

```
<ion-tabs>
  <ion-tab title="home" href="/tab/home">
    <ion-content>Hello!</ion-content>
  </ion-tab>
</ion-tabs>
```
2014-02-18 16:13:00 -05:00
Andy Joslin
69fda4e526 fix(tabs): broadcast tab.shown/tab.hidden to only child scopes
Addresses #588
2014-02-13 12:15:41 -05:00
Andy Joslin
b11e0f512b feat(tabs): allow tab badge-style attribute to set badge class 2014-02-07 13:16:02 -05:00
Andy Joslin
0facb120c7 feat(tab): allow html in tab title attribute
Closes #528
2014-02-06 22:25:12 -05:00
Adam Bradley
aa93047a9e remove test from unused tabBar directive 2014-02-05 20:49:36 -06:00
UniRing
bc927e57e7 feat(tabs): allow badges on tabbar via bound badge attr 2014-02-05 11:38:06 -05:00
Adam Bradley
ead7224a1e angular-ui router 2014-01-09 11:12:39 -06:00
Adam Bradley
9f952c3a50 view state wip 2014-01-08 22:37:03 -06:00
Max Lynch
c3d032000f I BROKE THEN FIXED THE BUILD 2013-11-29 16:18:39 -06:00
Ulrich Sossou
054a8323a8 remove console log from ionicTabBar test 2013-11-23 13:41:46 +01:00
Max Lynch
d8bce833cd Trying with firefox instead of phantom 2013-11-18 22:07:00 -06:00
Max Lynch
38af5a5cb7 Mixed around the types 2013-11-18 18:51:19 -06:00
Max Lynch
5f0ae6ca51 Fixed #158 - tab bar styles not set 2013-11-18 18:48:57 -06:00
Max Lynch
8ed1f3e7da Unit test and tab stuff 2013-11-17 15:48:50 -06:00
Max Lynch
082259dcfb Fixed #40 with test 2013-10-29 14:27:57 -05:00
Max Lynch
a23522cb06 Fixed most tests, started moving to Backbone VC for #62 2013-10-29 13:03:16 -05:00
Max Lynch
599dd732d4 Updating tests, fixing some old toggle and tab stuff 2013-10-29 12:04:44 -05:00
Max Lynch
6ac2cd3797 Progress on #37 2013-10-15 14:33:49 -05:00
Max Lynch
9dbb595f3c TabBar Unit 2013-10-11 12:57:11 -05:00