Commit Graph

216 Commits

Author SHA1 Message Date
Amanda Smith
484de5074d perf(various): don't use lazy-loaded icon names in components (#24671) 2022-01-28 09:13:39 -06:00
Sean Perkins
94d033c421 fix(item): label text aligns with input text (#24620)
Resolves #24404
2022-01-21 10:30:56 -05:00
Sean Perkins
54db1a1e7c fix(item): match material design character counter (#24335)
Resolves #24334
2022-01-19 11:24:08 -05:00
Sean Perkins
af01a8b307 fix(item): error slot visible in Safari (#24579)
Resolves #24575
2022-01-14 12:36:14 -05:00
Sean Perkins
500985ce04 fix(item): remove empty padding space for item bottom (#24323)
* fix(item): remove empty padding space for item bottom

* test(item): padding CSS variable screenshot test

* fix(item): remove --bottom-padding-start CSS variable

Resolves #23892
2021-12-08 16:15:08 -05:00
Sean Perkins
63066bcb9c chore(deps): update puppeteer to v10 (#24342)
* chore(deps): update puppeteer to v10

* chore(item): disable nested-interactive axe rule temporarily

* chore(segment): disable nested-interactive axe rule temporarily

* chore(deps): update package-lock with puppeteer and axe-core update

* chore(): add TODO task references for axe nested-interactive rule

* chore(deps): remove @types/puppeteer dev dep
2021-12-08 16:13:17 -05:00
Liam DeBeasi
f61f356000 fix(item): counter defaults to false to make upgrade easier (#24263) 2021-11-30 09:44:46 -05:00
Sean Perkins
3949a949df fix(item): allow click targets inside of label (#24225)
* fix(item): allow click targets inside of label

* docs(label): document z-index usage in label
2021-11-17 11:13:58 -05:00
Sean Perkins
713f0f5526 fix(textarea): floating label with autogrow textareas (#24202)
* fix(textarea): floating label with autogrow textareas

* test(textarea): autogrow visual diff tests
2021-11-16 12:05:11 -05:00
Liam DeBeasi
3f52ebea6f chore(): add missing comma 2021-10-27 13:24:22 +00:00
Liam DeBeasi
9c540583b2 chore(): sync with main for rc1 2021-10-27 09:21:44 -04:00
Amanda Smith
bdb268aa12 fix(menu): added focus trapping, improved compatibility with screen readers (#24076)
* fix(menu): add basic accessibility features

* fix(menu): add focus trapping

* test(menu): add test for focus trapping

* style(menu): lint fixes

* fix(menu): focus first element inside instead of whole menu

* test(menu): fix focus trap test to account for new behavior

* refactor(menu): pull focus handler into its own prop

* test(menu): add a11y testing

* fix(menu): prevent nested aria landmark from header inside menu

* fix(menu): revert switch to nav element

* fix(menu): remove unnecessary import from test

* fix(menu): allow for custom aria-label

* fix(menu): move nested ARIA role logic to header for flexibility

* fix(item): only add focusable class if it actually is focusable

* fix(menu): allow focusing of menu itself, for a11y on menus with no focusable children

* fix(item): move isFocusable logic to state for better reactivity

* perf(item): only grab one focusable child

* fix(menu): hide page content from screen readers when menu is open

* fix(menu): fallback to focusing host element

* docs(menu): add comments

Co-authored-by: Liam DeBeasi <liamdebeasi@icloud.com>
2021-10-27 08:51:46 -04:00
Liam DeBeasi
b211cf0236 chore(): sync with main for beta 5 release 2021-09-01 10:14:58 -04:00
Liam DeBeasi
5ca2ce9197 fix(item): form validation states are now properly shown (#23853)
resolves #23733 #23850

Co-authored-by: Will Martin <willmartindev@users.noreply.github.com>
2021-08-31 17:18:21 -04:00
Liam DeBeasi
9932e26a2e fix(label): label now only takes up as much space as needed when slotted (#23807)
resolves #23806
2021-08-24 10:25:12 -04:00
William Martin
2995e337c8 fix(item): highlight now appears above helper/error text (#23763)
resolves #23510
2021-08-12 10:51:36 -04:00
Liam DeBeasi
d749d583e7 chore(): sync with main 2021-07-20 12:50:52 -04:00
Brandy Carney
2c07a1566b feat(select): update popover interface to match MD spec on desktop, allow multiple values in popover interface (#23474)
resolves #23657
resolves #15500
resolves #12310
2021-07-20 11:23:00 -04:00
William Martin
9021e7cc4b fix(item): mirror disabled prop to aria attribute (#23544)
resolves #23513
2021-07-09 09:19:48 -04:00
Liam DeBeasi
5db60d9697 chore(): resolve merge conflicts 2021-06-21 14:03:47 -04:00
William Martin
faefe97da6 feat(item): add helper text, error text, counter, shape, and fill mode (#23354)
resolves #19619
2021-06-17 17:21:03 -04:00
Liam DeBeasi
932d3ca62f feat(datetime): add calendar picker (#23416)
resolves #19423

BREAKING CHANGE: The `ion-datetime` component has been revamped to use a new calendar style. As a result, some APIs have been removed. See https://github.com/ionic-team/ionic-framework/blob/master/BREAKING.md for more details.
2021-06-16 15:54:15 -04:00
Liam DeBeasi
e27b5b6ae3 fix(item): using multiple items with inputs no longer results in console warnings (#23429)
resolves #23427
2021-06-08 09:16:29 -04:00
Liam DeBeasi
dc430af906 fix(all): reflect color property as an attribute for vue (#23345)
resolves #23323
2021-05-21 19:26:53 -04:00
Liam DeBeasi
c877061a32 fix(item): detail icon is no longer announced by screen readers (#23055)
resolves #23054
2021-03-16 09:59:30 -04:00
Evgeniy
630848ae5c chore(): remove duplicate --color definition in ion-item (#23030) 2021-03-10 09:56:03 -05:00
Adam Bradley
0de75afbef feat(custom-elements): add experimental custom elements build (#22863)
Co-authored-by: Liam DeBeasi <liamdebeasi@icloud.com>
2021-02-11 12:08:00 -05:00
Óscar Carretero
11a59133d9 test(item): fix disabled test script path (#22660) 2020-12-10 17:00:32 -05:00
Brandy Carney
9659ad6334 fix(item): only add click event listener to items with inputs (#22352)
This stops screen readers, such as NVDA, from reading every item as clickable even when it is text only.

fixes #22011
2020-11-04 16:19:38 -05:00
Brandy Carney
a9b2260100 test(core): add lang attr to html tag to resolve axe errors (#22410) 2020-11-02 17:08:03 -05:00
Vlad Topala
992580a383 fix(label): keep color when focused on a floating or stacked label (#18576)
fixes #18531
2020-10-07 13:32:15 -04:00
Brandy Carney
f42c688f46 fix(item): properly align datetime and select without labels and with fixed labels (#22221)
fixes #18773 fixes #18761 fixes #18779
2020-10-01 18:54:19 -04:00
Brandy Carney
99f2532ee1 fix(input): only focus the first input / textarea when clicking on the parent item (#22049)
fixes #22037 resolves #22032
2020-09-14 11:44:37 -04:00
Liam DeBeasi
db2cac20fb docs(vue): update component usage examples for vue 3 (#22050) 2020-09-11 13:48:21 -04:00
Brandy Carney
e4964ff77b fix(input): properly focus the input when clicking the item padding in WebKit (#21930)
Related WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=214859

Issue Number: fixes #21509
2020-08-27 14:52:02 -04:00
Adam Bradley
753fd2f910 chore(colorClass): update createColorClasses() for ts4 (#21896)
Change the createColorClasses() fn so the returned type and jsx class property work well with typescript 4
2020-08-10 09:18:41 -05:00
Brandy Carney
17375d2325 feat(all): add shadow parts to missing components (#21436) 2020-06-10 09:58:33 -04:00
Liam DeBeasi
f34d3752e3 feat(all): add support for configuring animations on a per-page basis (#21433) 2020-06-08 15:49:14 -04:00
Brandy Carney
882f8fef07 fix(item): inherit align-items from parent item (#19278)
inherits alignment in inner item, sets item alignment to center

fixes #18703
2020-05-29 11:30:19 -04:00
Alex Currie-Clark
29d208de88 fix(item): input-wrapper now inherits overflow (#21282) 2020-05-27 12:56:11 -04:00
Brandy Carney
dd4cb706ff fix(input): check for tabindex and pass it properly to native input (#21170)
* fix(input): check for tabindex and pass it properly to native input

references #17515

* style(input): fix lint error

* test(input): update test for more use cases (inside item)

* fix(item): adds delegatesFocus to shadow

* style(input): add comment block on what the code does
2020-05-13 12:18:03 -04:00
Brandy Carney
687122127c docs(stencil): add stencil usage to components (#21261) 2020-05-12 20:35:48 -04:00
Liam DeBeasi
64144960b0 feat(item): add parts support for detail-icon (#20979) 2020-04-27 15:33:54 -04:00
Manu MA
976e68da5b refactor(): minor updates for next stencil version (#20787) 2020-03-24 11:59:07 -04:00
Brandy Carney
d53595eb16 fix(item): apply proper margin left for slotted icon in RTL (#20684)
fixes #20653
2020-03-11 11:52:01 -04:00
Ely Lucas
714ecaae65 docs(react): updating icon usages 2020-02-20 16:08:23 -07:00
Brandy Carney
27a219874c docs(grid): update usage from attributes to classes (#20492)
closes ionic-team/ionic-docs#1230
2020-02-14 12:45:46 -05:00
Liam DeBeasi
a6764c4724 fix(item): remove unneeded box-shadow CSS variable (#20412)
resolves #20392
2020-02-07 13:35:21 -05:00
Brandy Carney
a25007f54f docs(react): update class usage to className (#20366) 2020-02-04 11:16:44 -05:00
Brandy Carney
43d00415a5 docs(breaking): remove references to removed global css vars (#20348) 2020-01-30 18:20:35 -05:00