Commit Graph

1686 Commits

Author SHA1 Message Date
Brandy Carney
afcc46e1cc fix(radio): properly announce radios on screen readers and resolve axe errors (#22507) 2020-11-24 11:43:59 -05:00
Brandy Carney
04b874e32a fix(select): fix a11y issues with axe and screen readers (#22494)
fixes #21552 fixes #21548
2020-11-20 17:18:51 -05:00
Yohann CINTRE
c727419350 docs(select): fix broken link to select-option (#22539) 2020-11-20 12:20:07 -05:00
Liam DeBeasi
e1e23bc1a2 docs(modal): include note on using ion-page when wrapping modal component (#22534) 2020-11-19 15:31:01 -05:00
Liam DeBeasi
1956f98968 fix(router): navigation guards now fire when navigating to a page with params (#22521)
resolves #22516
2020-11-18 14:36:49 -05:00
Liam DeBeasi
33768e1d0c docs(tabs): add correct vue examples (#22510) 2020-11-17 11:02:28 -05:00
Liam DeBeasi
2d878fc4f6 fix(backdrop): nvda no longer incorrectly announces backdrop (#22481)
resolves #22102
2020-11-16 12:15:33 -05:00
Takuma Kira
65bc99577c feat(segment): add swipeGesture property to allow for disabling of the swipe gesture (#22087)
resolves #22048
2020-11-13 12:38:23 -05:00
Liam DeBeasi
abad12fbdb fix(input): title attribute is automatically inherited (#22493)
resolves #22055
2020-11-13 12:15:33 -05:00
Liam DeBeasi
d77a9d57ec perf(ios): move content to stacking context while preserving position: fixed behavior (#22489)
resolves #22473
2020-11-12 16:02:12 -05:00
Brandy Carney
813611a61b fix(toggle): use a native input to fix a11y issues with axe and screen readers (#22477)
fixes #22011
references #21552
2020-11-12 15:29:05 -05:00
Brandy Carney
7214a8401b fix(checkbox): use a native input to fix a11y issues with axe and screen readers (#22402)
fixes #21644
fixes #20517
fixes #17796
2020-11-12 11:25:33 -05:00
Liam DeBeasi
a4a64530ff fix(refresher): ios native refresher now works in side menu (#22449) 2020-11-10 12:07:38 -05:00
Daniele
1267945480 docs(checkbox): update example for vue 3 syntax (#22457) 2020-11-09 11:01:34 -05:00
Stian Øvrevåge
907cc7b159 docs(vue): fix label typo (#22451) 2020-11-09 09:57:38 -05:00
Liam DeBeasi
6b817f26b0 fix(refresher): refresher gesture now works in side menu (#22446)
resolves #20832
2020-11-06 12:16:45 -05:00
Hans Krywalsky
0a0cbd8f2a feat(chip): add disabled property (#20658)
resolves #19510
2020-11-05 14:18:24 -05:00
Liam DeBeasi
dd307b60b6 chore(): revert old segment fix in favor of new one (#22434)
This reverts commit 68afc49e9e.
2020-11-05 11:38:46 -05:00
Brandy Carney
9659ad6334 fix(item): only add click event listener to items with inputs (#22352)
This stops screen readers, such as NVDA, from reading every item as clickable even when it is text only.

fixes #22011
2020-11-04 16:19:38 -05:00
Liam DeBeasi
9752cd6371 fix(alert): correctly position alert when keyboard is open (#22425)
Co-authored-by: Masahiko Sakakibara <rdlabo@users.noreply.github.com>
2020-11-04 14:17:00 -05:00
Brandy Carney
a9b2260100 test(core): add lang attr to html tag to resolve axe errors (#22410) 2020-11-02 17:08:03 -05:00
Hans Krywalsky
91d041485c fix(refresher): work properly in modal by waiting for content to be ready (#22390)
resolves #22256
2020-11-02 13:14:15 -05:00
Liam DeBeasi
2fea36fc98 fix(range): gesture is now properly re-created on connectedCallback (#22407)
resolves #22335
2020-11-02 10:50:08 -05:00
Liam DeBeasi
27191026ef docs(): add note on form bindings with debounce (#22409) 2020-11-02 09:26:42 -05:00
Liam DeBeasi
04161c9512 fix(segment-button): color property is now reactive if previously undefined (#22405)
resolves #20831
2020-10-30 16:25:52 -04:00
Liam DeBeasi
023fb18412 fix(ios): contenteditable elements are now selectable on iOS (#22404)
Co-authored-by: Chris Lo <CFT-Chris@users.noreply.github.com>
2020-10-30 09:44:17 -04:00
Liam DeBeasi
69d72f9c17 docs(vue): fix menuController import (#22392) 2020-10-29 16:43:37 -04:00
Liam DeBeasi
9f44966d85 perf(ios): move content to stacking context to improve scrolling performance on iOS devices (#22180) 2020-10-29 16:41:20 -04:00
Brandy Carney
1a2e5322fb fix(select): properly align label with select in item in md (#22330)
fixes #19887
2020-10-15 15:21:18 -04:00
Liam DeBeasi
6be8b8d89d docs(vue): add infinite scroll examples (#22317) 2020-10-14 15:41:46 -04:00
Liam DeBeasi
dcdb7b6f4e docs(vue): add note on virtual scroll (#22318) 2020-10-14 15:41:04 -04:00
Liam DeBeasi
18ad9efa4b chore(): sync vue branch with master 2020-10-08 11:38:58 -04:00
Vlad Topala
992580a383 fix(label): keep color when focused on a floating or stacked label (#18576)
fixes #18531
2020-10-07 13:32:15 -04:00
Matthias Max
c454c84ef4 fix(button): allow any element type to use the "icon-only" slot (#22168) 2020-10-06 18:40:29 -04:00
Brandy Carney
1878c8e7e0 fix(select): do not close popover or set value when switching with arrow keys (#22210)
fixes #22179
2020-10-06 17:33:35 -04:00
Jeremy Forsythe
66b4d11545 docs(select): fix objects as values angular usage (#22143)
Fix the Objects as Values documentation to add the necessary value
property to the template, simplify the compare function, and add an
interface for type checking.

Add an Objects as Values with Multiple Selection documentation section
to show the difference with the compare function which needs to
determine if an object is in the array of selected objects

This fixes an issue noted in the forums at https://forum.ionicframework.com/t/ionic-5-ion-select-objects-as-values-not-working/191807/2
2020-10-02 11:28:52 -04:00
Brandy Carney
2373ff0d39 docs(popover): add the popover-example-page to core and event to react (#22231)
closes ionic-team/ionic-docs#1517
2020-10-01 19:04:18 -04:00
Brandy Carney
f42c688f46 fix(item): properly align datetime and select without labels and with fixed labels (#22221)
fixes #18773 fixes #18761 fixes #18779
2020-10-01 18:54:19 -04:00
Brandy Carney
18fb8855e0 fix(datetime): do not set ampm when the column doesn't exist (#22220)
fixes #22149
2020-10-01 13:06:13 -04:00
Brandy Carney
f81d18c6f9 fix(datetime): remove the automatic switching from am to pm (#22207)
fixes #18924 fixes #22171 fixes #22199
2020-09-29 16:32:21 -04:00
Liam DeBeasi
1832be0597 docs(modal): fix props on vue example (#22201) 2020-09-29 10:00:59 -04:00
Liam DeBeasi
aeda33d8ae docs(vue): add revised overlay examples (#22173) 2020-09-25 10:27:27 -04:00
Liam DeBeasi
cc45ad815c fix(overlays): return focus to presenting element after dismissal (#22167)
resolves #21768
2020-09-24 18:07:25 -04:00
Brandy Carney
e9b2cc8453 fix(alert): update to follow accessibility guidelines outlined by wai-aria (#22159)
This also fixes the Select "alert" interface as it uses this component

WAI-ARIA Guidelines:

- Tab and Shift + Tab: Move focus into and out of the radio group. When focus moves into a radio group :
  - If a radio button is checked, focus is set on the checked button.
  - If none of the radio buttons are checked, focus is set on the first radio button in the group.
- Space: checks the focused radio button if it is not already checked.
- Right Arrow and Down Arrow: move focus to the next radio button in the group, uncheck the previously focused button, and check the newly focused button. If focus is on the last button, focus moves to the first button.
- Left Arrow and Up Arrow: move focus to the previous radio button in the group, uncheck the previously focused button, and check the newly focused button. If focus is on the first button, focus moves to the last button.

closes #21744
2020-09-24 17:09:54 -04:00
Brandy Carney
1526bdfb49 fix(segment): do not allow text selection on desktop (#22158) 2020-09-24 14:48:52 -04:00
archzaiko
baafe08927 fix(reorder): allow click event propagation when reorder group is disabled (#21947)
Allow interactive components (e.g `<ion-checkbox>`) inside of an `<ion-reorder>` tag in a disabled `<ion-reorder-group>` to fire click events / have their state changed. 

fixes #21017
2020-09-24 14:43:32 -04:00
Brandy Carney
ea0e0499e2 fix(radio): update to follow accessibility guidelines outlined by wai-aria (#22113)
This also fixes the Select "popover" interface as it is made up of radio buttons

WAI-ARIA Guidelines:

- Tab and Shift + Tab: Move focus into and out of the radio group. When focus moves into a radio group :
  - If a radio button is checked, focus is set on the checked button.
  - If none of the radio buttons are checked, focus is set on the first radio button in the group.
- Space: checks the focused radio button if it is not already checked.
- Right Arrow and Down Arrow: move focus to the next radio button in the group, uncheck the previously focused button, and check the newly focused button. If focus is on the last button, focus moves to the first button.
- Left Arrow and Up Arrow: move focus to the previous radio button in the group, uncheck the previously focused button, and check the newly focused button. If focus is on the first button, focus moves to the last button.

Closes #21743
2020-09-24 14:33:27 -04:00
Nelson Martell
ca338864bf docs(reorder-group): add type to the event param (#22157)
Improve Angular example by adding missing (`any`) typehint of the event
2020-09-23 17:58:01 -04:00
Liam DeBeasi
a24a041064 fix(picker-column): add cancelable check to avoid intervention error in chrome (#22140)
resolves #22137
2020-09-22 14:04:39 -04:00
Liam DeBeasi
68afc49e9e perf(segment): improve scrolling performance on ios when using segment (#22110)
resolves #22095
2020-09-21 15:39:09 -04:00