Commit Graph

1980 Commits

Author SHA1 Message Date
Ikko Ashimine
ae0a1a3deb chore(nav): fix typo in test comment (#23658) 2021-07-20 11:21:39 -04:00
Liam DeBeasi
773bbcb211 fix(overlays): overlay interfaces are now exported from framework packages and documented (#23619)
resolves #22790
2021-07-15 08:50:50 -04:00
Liam DeBeasi
174b7de741 docs(vue): add card style modal example (#23628) 2021-07-14 10:18:17 -04:00
Liam DeBeasi
7315e0157b chore(): switch to using disallow terminology (#23618) 2021-07-13 14:03:58 -04:00
Liam DeBeasi
c08345df2e fix(menu-button): custom aria-label can now be set (#23608)
resolves #23604
2021-07-12 08:52:03 -04:00
Liam DeBeasi
fa069424b2 fix(router-outlet): improve reliability of swipe back gesture when quickly swiping back (#23527)
resolves #22895
2021-07-09 09:29:16 -04:00
Liam DeBeasi
3b803ebe02 fix(button): buttons are now disabled during page transitions (#23589)
resolves #23588
2021-07-09 09:27:11 -04:00
William Martin
9021e7cc4b fix(item): mirror disabled prop to aria attribute (#23544)
resolves #23513
2021-07-09 09:19:48 -04:00
Liam DeBeasi
39315bc857 fix(action-sheet): header, subheader, and icon alignment better matches native ios (#23322)
resolves #23317
2021-07-08 09:38:00 -04:00
omar2205
a15cace139 docs(loading): show how to use dismiss method returns from useIonLoading for react (#23537) 2021-07-07 09:04:10 -04:00
Liam DeBeasi
635ac195d9 docs(router-outlet): add react note to docs (#23580) 2021-07-06 10:19:54 -04:00
Liam DeBeasi
69be51dc54 fix(ios, md): double tapping back button no longer causes app to go back 2 pages (#23526)
resolves #18455
2021-07-01 10:44:19 -04:00
Liam DeBeasi
f3d6abbc1b fix(animation): typescript interface has correct return value for progress methods (#23536) 2021-06-29 16:36:51 -04:00
Liam DeBeasi
0b5c470b98 docs(card): fix usage example for vue (#23535) 2021-06-29 15:03:01 -04:00
Liam DeBeasi
68c0e7136d fix(button): buttons using fill and color properties now account for hover and focused opacity variables (#23442)
resolves #23441
2021-06-21 13:00:50 -04:00
Liam DeBeasi
e27b5b6ae3 fix(item): using multiple items with inputs no longer results in console warnings (#23429)
resolves #23427
2021-06-08 09:16:29 -04:00
Liam DeBeasi
60bedb5599 fix(vue): prevent error from being thrown when testing on certain jest runners (#23421)
resolves #23397
2021-06-07 10:49:19 -04:00
Brandy Carney
82cfa55653 fix(title): inherit padding for iOS title in a toolbar (#23343)
resolves #23072
2021-06-03 11:28:57 -04:00
Hans Krywalsky
ae96563fb3 fix(modal): swipe to close modal is no longer swipeable on footer (#23401)
resolves #23398
2021-06-02 08:59:25 -04:00
Liam DeBeasi
d527414e10 chore(radio-group): clean up code to reuse helper function (#23396)
Co-authored-by: Daniel Simão <danielsimao@users.noreply.github.com>
2021-06-01 10:44:45 -04:00
Liam DeBeasi
6cc6f4c44b chore(): revert incorrect co-author credit (#23395)
This reverts commit 62ed9712e1.
2021-06-01 09:54:04 -04:00
Liam DeBeasi
62ed9712e1 chore(radio-group): use existing helper function for getting all radios (#23394)
Co-authored-by: Daniel Simão < danielsimao @users.noreply.github.com>
2021-06-01 09:22:12 -04:00
Liam DeBeasi
e3aaa9513e docs(popover): resolve variable naming conflict (#23393) 2021-06-01 09:08:14 -04:00
Victor Berchet
857550a0c4 chore(router): clean up code and add comments (#23355) 2021-05-28 08:57:52 -04:00
Liam DeBeasi
3d474ec67f fix(title): large title scale animation is now correct in rtl mode (#23372)
resolves #23371
2021-05-26 13:40:44 -04:00
Liam DeBeasi
bc2f1b8944 docs(fab): document correct ion-icon usage for vue (#23352) 2021-05-24 11:04:31 -04:00
Daniel Ehrhardt
1a36922f41 fix(skeleton-text): animation no longer jumps on large skeleton text elements (#22697)
resolves #22694
2021-05-24 08:52:39 -04:00
Liam DeBeasi
dc430af906 fix(all): reflect color property as an attribute for vue (#23345)
resolves #23323
2021-05-21 19:26:53 -04:00
Victor Berchet
08a9f3ac94 fix(router): redirects now account for query string (#23337)
resolves #23136
2021-05-21 15:34:06 -04:00
Liam DeBeasi
881dcff40b fix(range): knob can now have an accessible name (#23338)
resolves #23295
2021-05-21 14:38:18 -04:00
Liam DeBeasi
a708c41262 fix(slides): resolve prototype pollution in swiper v5 (#23344)
resolves #23342
2021-05-21 14:16:53 -04:00
Liam DeBeasi
d473a53851 fix(action-sheet): subheader no longer overlaps action sheet buttons (#23318)
resolves #23316
2021-05-21 11:28:34 -04:00
Victor Berchet
56f6f56c66 fix(router): guards are now triggered on initial navigation (#23123)
resolves #22936
2021-05-20 10:05:49 -04:00
Liam DeBeasi
a9b12a5aa4 fix(overlays): screen readers no longer read content behind overlays (#23284)
resolves #22714
2021-05-11 09:51:37 -04:00
Liam DeBeasi
1e1596f471 fix(refresher): refresher now only activates when pulling down on MD (#23283)
resolves #23245
2021-05-10 09:38:14 -04:00
Matthias Max
f36eabccb8 docs(modal): document stacked modal behavior (#23279) 2021-05-07 11:56:26 -04:00
William Martin
03d5fcb6c8 chore(): revert #23181
Reverts #23181
2021-05-03 16:29:58 -04:00
William Martin
d94739f39b fix(modal): add additional padding to toolbars in iOS modal (#23181)
resolves #22778
2021-05-03 10:44:41 -04:00
Liam DeBeasi
2ccaabb5b4 fix(slides): undefined error is no longer thrown after destroying and quickly re-creating ion-slides (#23239)
resolves #22289
2021-04-26 12:25:23 -04:00
Liam DeBeasi
dab927d290 fix(vue): overlay events can now be listened for without the "on" prefix, deprecated "on" prefix event listeners (#23227) 2021-04-23 11:38:45 -04:00
William Martin
7139b3f39e fix(radio-group): pressing spacebar correctly unselects radio with allow-empty-selection (#23194)
resolves #22734
2021-04-21 14:34:27 -04:00
William Martin
a31fb55bac fix(datetime, input, textarea): remove aria-labelledby when there is no adjacent ion-label (#23211)
* fix(datetime, input, textarea): remove aria-labelledby when there is no adjacent ion-label

* Update core/src/components/input/test/a11y/input.spec.ts

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>

* Update core/src/components/textarea/test/a11y/textarea.spec.ts

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>

* Update core/src/components/datetime/test/a11y/datetime.spec.ts

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>

* remove hard-coded label, fix whitespace

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2021-04-20 12:34:32 -04:00
William Martin
2d07d8216a fix(content): change main child element to div when parent is menu (#23160)
* fix(content): change main child element to div when parent is menu

* fix(content): change main child element to div when parent is menu, popover, or modal

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>

* fix(content): make closest element detector unreactive

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2021-04-12 09:22:24 -04:00
William Martin
91ac340ae7 fix(segment, segment-button): use correct tablist and tab roles for screen readers (#23145)
* fix(segment, segment-button): change aria attributes for segment and segment-button

* add axe test

* Add tests, screen reader doc

* add updated screen reader

* fix(segment-button): move aria tags to host

* verify nvda and talkback behavior

* fix(segment-button): remove outline on focus

* Update core/src/components/segment/test/basic/index.html

Co-authored-by: Liam DeBeasi <liamdebeasi@icloud.com>
2021-04-12 09:20:59 -04:00
William Martin
61f094d306 fix(input): inherit aria-label to input (#23159) 2021-04-07 14:44:03 -04:00
Ikko Ashimine
8739c9b16d test(slides): fix typo in test (#23158) 2021-04-07 09:42:17 -04:00
William Martin
42e6c90c46 fix(toggle): prevent click event from firing twice (#23146)
resolves #23041
2021-04-06 09:54:29 -04:00
William Martin
b0d53ca736 docs(action-sheet, alert, popover, toast): update usage to show onDidDismiss (#23133) 2021-04-02 13:00:36 -04:00
William Martin
ef1a82f64a docs(alert): add input handler to usage examples (#23131) 2021-04-02 12:58:59 -04:00
William Martin
f4eb4b34d6 docs(reorder-group): fix vue usage of reorder-group (#23130)
resolves https://github.com/ionic-team/ionic-docs/issues/1804
2021-04-01 16:19:02 -04:00