25 Commits

Author SHA1 Message Date
96657535f1 refactor(navigation): async component loading (aka lazy loading)
async component loading (aka lazy loading)
2017-03-02 15:05:35 -06:00
8d9f374065 fix(all): memory leaks
fixes #10459
fixes #10416
fixes #10286
2017-02-28 17:50:42 +01:00
d46b3e8e9f docs(nav): fix typos in comments for NavControllerBase and ViewController (#9953)
* docs(nav): fix typo

* docs(view): fix typo
2017-01-11 16:23:18 -05:00
8ca9797c0f fix(clickblock): add NavOptions.minClickBlockDuration
* feat(clickblock): ability to set a minimum duration for click block

* fix(clickblock): add NavOptions.minClickBlockDuration
2017-01-09 16:44:37 -06:00
7000b1b173 refactor: improve tree shaking abilities
Internal refactor completed in order to improve tree shaking and dead
code removal. The public API, with an exception to ion-slides, has
stayed the same. However, internally many changes were required so
bundlers could better exclude modules which should not be bundled.
Ultimately most changes resorted to removing references to `window` or
`document`, or a module that referenced one of those.

BREAKING CHANGES

ion-slides was refactored to remove the external dependencies, and
rewritten in TypeScript/ES6 modules to again improve tree shaking
abilities.
2017-01-09 09:51:39 -06:00
f599758db4 style(viewcontroller): some TS types and minor changes 2016-12-06 01:45:37 +01:00
68eb1b7cb5 fix(viewcontroller): onDidDismiss() is always called
fixes #8223
2016-12-05 14:53:24 -06:00
5567191a45 fix(modal): app.navPop() can dismiss modals
fixes #8692
2016-12-02 11:55:26 +01:00
16bfb49395 fix(nav): prevents to remove all views in the nav stack
fixes #9140
2016-11-28 01:38:21 +01:00
ac157c0474 docs(viewController): update viewController 2016-11-07 15:44:45 -05:00
be72d39bd9 perf(nav): avoid running zone when it is not needed 2016-11-07 20:59:48 +01:00
033e1eae17 fix(nav): adds public willLoad lifecycle event
* fix(nav): adds public willLoad lifecycle event

* test(menu): adds more asserts
2016-11-01 13:12:29 -05:00
d9e8b1bec6 refactor(nav-controller-base): cleanup some logic
NavControllerBase is the core of ionic 2 navigation. It handles all the transitions and it is complicated code to follow.
I am refactoring it to allow future developers and contributors to follow it better.

!node.parent now becomes node.isRoot()

ViewController does not remove itself from the stack, but two new auxiliar function in nav controller: _insertView() and _removeView() are used to add a view to the stack.

And so on...

All e2e and unit tests passing...
2016-10-18 16:36:55 +02:00
ba557acb4f fix(nav): ion-nav inside ion-content work properly 2016-10-15 02:59:57 +02:00
35568ba85f chore: removed deprecated APIs 2016-10-13 11:02:45 -05:00
ca3b9455d1 Merge pull request #8260 from vanackere/fix-viewcontroller-dismiss
Fix infinite loop (hang) in viewcontroller dismiss
2016-10-12 21:50:01 +02:00
451ffe1133 fix(nav): ionViewDidLoad is called in modals
fixes #8449
2016-10-12 11:38:44 -05:00
c8954d8a16 fix(nav): ionViewCanLeave does not break navigation
fixes #8408
2016-10-10 21:45:58 +02:00
9227310494 fix(ViewController): avoid deep copy in dismiss() that can turn into an infinite loop
For some reason, apparently related to the NavOptions.ev field,
this deep copy was turning into an infinite loop on a Nexus 7 / android 5.1.1 webview.
Replace with a non-deep copy since the deep copy is unnecessary in this case.
2016-10-03 12:01:45 +02:00
d5f71a448d fix(view-controller): dismiss does not crash when called more than once
fixes #8395
2016-10-02 17:15:23 +02:00
9b650229f7 fix(nav): push-pop pages too quickly
fixes #8319
2016-09-30 20:17:19 +02:00
dbfc183cac docs(): update docs 2016-09-26 21:11:54 -04:00
e26c425766 fix(navigation): move onWillDismiss and onDidDismiss, add unit tests 2016-09-22 21:37:50 -04:00
35193c42c4 fix(nav): move null assignment of _onWillDismiss 2016-09-19 08:30:17 -05:00
ed221eff1d refactor(nav): queue based transitions 2016-09-13 17:13:43 -05:00