Commit Graph

10 Commits

Author SHA1 Message Date
Maria Hutt
b16fd1d6f9 fix(item-sliding): options display on rtl (#27203)
Issue URL: resolves #26103, resolves #25285

---------

<!-- Please refer to our contributing documentation for any questions on
submitting a pull request, or let us know here if you need any help:
https://ionicframework.com/docs/building/contributing -->

<!-- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation
for details. -->

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Options in `item-sliding` will not display when using RTL with Firefox
and Safari.

<!-- Issues are required for both bug fixes and features. -->


## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

Issue was coming from `:host-context`. Firefox would keep [removing the
entire](https://www.w3.org/TR/selectors-3/#grouping) compiled style when
using this unsupported style. This would led to the RTL styles to not
being applied to the component.

- Split the CSS group from `add-root-selector()`
- Added comments to make it easier to navigate through
`add-root-selector()`
- Added `:dir()`

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Co-authored-by: brandyscarney <brandyscarney@users.noreply.github.com>

- Updating `add-root-selector()` would also fix another
[issue](https://github.com/ionic-team/ionic-framework/issues/25285)
unintentionally

---------

Co-authored-by: ionitron <hi@ionicframework.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-05-09 17:05:18 +00:00
Ryan Waskiewicz
16dcd2d114 chore(scss): remove injected global styles (#26469)
this commit removes a globally injected style, `ionic.skip-warns.scss`,
from the project. this stylesheet was used to set a variable, `$Ionic`,
that would turn on/off deprecation warnings in (the also removed)
`ionic.deprecation.scss`. any file using either of the aforementioned
files have been updated.

this change is occurring while the stencil team is looking to improve
the size of generated components that use >1 mode. this deprecation was
a part of an initiative to remove sass source files from artifact
published to npm. while that was completed, this deprecation was not
removed (until now)

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2022-12-13 08:34:25 -05:00
Manu MA
c7b302c7a6 refactor(): add scss usage deprecation warning (#19238) 2019-08-30 20:20:55 +02:00
Brandy Carney
805b225876 fix(segment): update segment border for rtl (#18326)
references #17012
2019-05-21 17:46:14 -04:00
Brandy Carney
845def82f5 fix(rtl): updates searchbar, fab and toggle icon positioning in rtl (#18325)
- fixes tab badge (in Chrome)
- fixes searchbar buttons
- fixes fab positioning
- fixes toggle

references #17012
2019-05-21 17:20:45 -04:00
Brandy Carney
00a27dc37b fix(css): update rtl function to prepend selectors with host-context properly (#18315)
references #17012
2019-05-21 14:42:57 -04:00
Brandy Carney
ceae5d20d7 fix(alert): update styles for rtl (#17129)
- apply border correctly to 2 button mode in iOS
- radio: position icon correctly (fixes #16295)
- checkbox: position icon correctly
- remove scrollbar with radio/checkbox
- updates e2e test to include rtl

https://screenshot.ionicframework.com/5447404/d8bad6a

references #17012
2019-01-16 15:38:08 -05:00
Adam Bradley
c2fe9175bf refactor(rtl): use css logical properties for padding/margin (#16987)
* refactor(rtl): use css logical properties for padding/margin

* fix(item-divider): fix padding

* test(rtl): add item basic rtl script

* fix(rtl): update core/src/themes/ionic.mixins.scss

* refactor(rtl): wrap css logical props with @supports

* refactor(rtl): do not use css logical properties for hardcoded 0 values
2019-01-15 10:43:00 -06:00
Brandy Carney
a7f1f4daa7 refactor(components): update to use shadow DOM and work with css variables
- updates components to use shadow DOM or scoped if they require css variables
- moves global styles to an external stylesheet that needs to be imported
- adds support for additional colors and removes the Sass loops to generate colors for each component
- several property renames, bug fixes, and test updates

Co-authored-by: Manu Mtz.-Almeida <manu.mtza@gmail.com>
Co-authored-by: Adam Bradley <adambradley25@gmail.com>
Co-authored-by: Cam Wiegert <cam@camwiegert.com>
2018-07-09 12:57:21 -04:00
Brandy Carney
d37623a2ca chore(packages): move the packages to root 2018-03-12 16:02:25 -04:00