96 Commits

Author SHA1 Message Date
9c48fa715d fix(spinner): fix default spinner logic for relevant components (#17660)
- In the **`loading`** component, fallback to `spinner` icon config before platform default.
- In both **`refresher`** & **`infinite-scroll`** components, use platform default as final fallback.
- In **`infinite-scroll`** test templates, and the _basic_ **`virtual-scroll`** test template, fix loading _spinner_ and _text_ attributes.

fixes #17659
2019-03-15 17:52:33 -04:00
14f758ca97 fix(item-option): add styling for slots other than icon-only (#17711)
styles the item option properly when icons are slotted. This was not working before at all for `top` and `bottom` slots.

- removes the e2e test from item/sliding in favor of all of them being under item-sliding
- adds more usage examples for all frameworks
- updates the styling for an anchor option so that it displays properly
- updates the standalone e2e test to take screenshots of the start icon, top icon, and anchor options
- updates the interactive e2e test to work locally
- cleaned up the CSS for start/end icons
- verified the styles for ben approval 💪

closes #17737 fixes #17402
2019-03-15 13:46:57 -04:00
1c60a083e5 docs(vue): update markdown format for vue files. 2019-03-04 19:38:16 -06:00
28fd75ee6b fix(loading): add backdropDismiss to the interface (#17668)
fixes #17369
2019-03-04 10:52:13 -05:00
ab57b98e07 chore(docs): rebuild readme after update to vue usage docs. 2019-03-02 12:04:45 -06:00
928b2f7843 docs(vue): add loading usage vue docs (#17661) 2019-03-02 12:03:38 -06:00
f07ea4f7db test(): Take more screenshots, DRY up code, add more tests (#17534)
* test(toast): DRY up tests, add expanded tests, add rtl tests

* test(popover): add more screenshots, add rtl tests

* clean up tests a bit more

* test(modal): DRY up tests, add RTL tests

* add missing type to util function

* add utils file, update standlone test

* update standalone tests, add utils file

* test(menu): DRY up tests, add rtl tests

* test(loading): DRY up tests, add rtl tests, add utils file

* lint files

* test(alert): add more screenshots, dry up tests

* fix potential race condition

* remove artificial delay

* lint files

* lint files

* remove artificial delays

* remove artificial delay

* add initial test updates, need to figure out alert from action sheet

* test(): dry up tests some more, add generic utils file

* lint files

* add hook

* fix typescript error
2019-03-01 10:41:55 -05:00
22d1aeebaa docs(react): update component usage docs (#17615) 2019-02-26 08:54:01 -06:00
74859a098e docs(loading): update example to show proper usage 2019-02-04 13:03:45 -05:00
c99032de6f docs(loading): remove dismissOnPageChange, add ionLoadingDidDismiss (#17357)
* docs(loading): remove dismissOnPageChange, change onDidDismiss to ionLoadingDidDismiss

* docs(loading): add usage showing events
2019-02-04 11:16:26 -06:00
bf434e52c9 docs(loading): correct loading-controller link path (#17295)
closes ionic-team/ionic-docs#254
2019-01-28 09:12:01 -06:00
82457d874b fix(action-sheet): remove the height shift on press and update iOS design (#16862)
This changes the border into a linear gradient background image which allows us to avoid the height decrease on press and have the same border as the background color when pressed.

- merges all action sheet tests to the basic directory (except standalone, translucent), references #16715
- removes the height shift on press, fixes #16790
- fixes the cancel button on iOS so it is `#ffffff` by default
- gets the look of the action sheet closer to native for iOS
- only applies the translucent and backdrop filter if it is supported by the browser (chrome will not show transparent anymore)
- updates documentation to describe when translucent will show up
- adds documentation on how to use screenshot tests
2019-01-10 18:13:31 -05:00
c68292b78f test(rtl): add rtl script to all e2e tests (#17009) 2019-01-08 15:06:23 -06:00
302be5392c fix(overlays): make them hidden until presented (#16903)
fixes #16685
2018-12-29 01:31:33 +01:00
3d656ac312 docs(all): improve type docs for event 2018-12-28 20:38:24 +01:00
8b140306ef refactor(animation): remove ion-animation-controller (#16842) 2018-12-21 13:17:42 +01:00
4053f386fd refactor(components): consistent css variables for size (#16600)
Reviews the `--width` and `--height` variables in each component to either remove or add them based on need.

- fixes a bug where the spinner color wasn't being set properly in loading
- adds css variables for customizing background, color, some borders in overlays
- fixes a bug where prefix, suffix are taking up too much width in picker

closes #16097
references ionic-team/ionic-docs#228

BREAKING CHANGES

## Core Components

Removes the `--width` and `--height` variables from the following components, in favor of CSS:

- Button
- FAB Button
- Checkbox
  - Removes the `--width`/`--height` and adds a `--size` variable that is set on the width and height, allowing width and height to still be set and border-radius to still use it as a variable
- Radio
  - Removes the `--width`/`--height` and `--inner-width`/`--inner-height` variables. Calculates inner values based on parent element size.

## Overlay Components

The following components have all be converted to shadow (or scoped) and have CSS variables for width/height:

- Action Sheet _(scoped)_
- Alert  _(scoped)_
- Loading  _(scoped)_
- Menu _(shadow)_
- Modal  _(scoped)_
- Picker _(scoped)_
- Popover  _(scoped)_
- Toast _(shadow)_

The above components will now have the following CSS variables for consistency among overlays:

| Name              |
| ----------------- |
| `--height`        |
| `--max-height`    |
| `--max-width`     |
| `--min-height`    |
| `--min-width`     |
| `--width`         |

If the component does not set the value, it will default to `auto`.

## Removed CSS Variables

The following CSS properties have been removed:

| Component      | Property            | Reason                          |
| ---------------| --------------------| --------------------------------|
| **Button**     | `--height`          | Use CSS instead                 |
| **Button**     | `--margin-bottom`   | Use CSS instead                 |
| **Button**     | `--margin-end`      | Use CSS instead                 |
| **Button**     | `--margin-start`    | Use CSS instead                 |
| **Button**     | `--margin-top`      | Use CSS instead                 |
| **Button**     | `--width`           | Use CSS instead                 |
| **Checkbox**   | `--height`          | Use CSS or `--size`             |
| **Checkbox**   | `--width`           | Use CSS or `--size`             |
| **FAB Button** | `--width`           | Use CSS instead                 |
| **FAB Button** | `--height`          | Use CSS instead                 |
| **FAB Button** | `--margin-bottom`   | Use CSS instead                 |
| **FAB Button** | `--margin-end`      | Use CSS instead                 |
| **FAB Button** | `--margin-start`    | Use CSS instead                 |
| **FAB Button** | `--margin-top       | Use CSS instead                 |
| **Menu**       | `--width-small`     | Use a media query and `--width` |
| **Radio**      | `--width`           | Use CSS instead                 |
| **Radio**      | `--height`          | Use CSS instead                 |
| **Radio**      | `--inner-height`    | Calculated based on parent      |
| **Radio**      | `--inner-width`     | Calculated based on parent      |
2018-12-14 15:45:14 -05:00
a251b500a9 fix(loading): add backdropDismiss closes #16527 (#16570) 2018-12-03 18:36:19 +01:00
6b7f8ae201 chore(): update stencil (#16506) 2018-11-29 18:54:51 +01:00
d09e55500c chore(): update stencil (#16460) 2018-11-26 22:19:48 +01:00
a85ef06ac9 chore(): update stencil + api-spec file 2018-11-20 10:06:02 +01:00
3c9ed3166d fix(backdrop): update opacity to match MD spec (#16188) 2018-11-04 14:04:06 -05:00
0680fe9251 docs(all): add global config docs (#16193)
* docs(all): add global config docs

fixes #16109

* lint issue

* add tabButtonLayout

* tabs docs
2018-11-02 17:30:37 +01:00
ecc2c55370 docs(all): possible values are extracted by stencil (#16190)
* docs(all): possible values are extracted by stencil

* add defaults

* remove all hardcoded defaults

* update stencil
2018-11-02 00:06:40 +01:00
38db1fb167 test(tabs): fix tabs tests (#16146) 2018-10-30 13:30:08 -05:00
018fb9876f test(all): use test() instead of it() where appropriate (#16129)
This replaces uses of Jest's it() function in end-to-end tests with the alias test() where it makes sense semantically.
2018-10-29 12:40:06 -05:00
c982856dba feat(toast): add "color" prop (#16100)
This commit also refactors ion-toast, so it uses shadow-dom,
this is required since CSS variables
does not work well in non-shadow-dom components.

fixes #16099
2018-10-26 18:53:02 +02:00
3c7fee5cca test(e2e): relative paths (#16077) 2018-10-24 22:41:48 -05:00
d800c48734 test(e2e): update e2e tests for screenshot (#16056) 2018-10-23 23:56:40 -05:00
a9fd3399de test(e2e): force roboto font on all systems (#15993) 2018-10-19 15:22:15 -05:00
86d5f33841 chore(package): update to stencil 0.14.1-1 (#15992) 2018-10-17 15:01:37 -05:00
3a4b21457f chore(): update stencil 2018-10-12 11:44:43 -05:00
fb3b752198 chore(): update stencil 2018-10-11 16:49:05 -05:00
a72fced6fe fix(all): docs for all missing props 2018-10-11 16:24:08 -05:00
ae3271f2d7 test(all): inject test styles on flag 2018-10-11 15:13:23 -05:00
2172aa9dae test(screenshot): use Arial for testing 2018-10-09 13:40:31 -05:00
4036db5480 chore(): update readme 2018-10-08 15:46:34 -05:00
9d109d68c8 fix(all): disable animations in e2e tests 2018-10-08 10:18:31 -05:00
dc976cc745 feat(overlays): expose animation customization 2018-10-04 17:21:15 +02:00
05f3d92af4 test(loading): migrate e2e tests
references #15803
2018-10-02 11:49:25 -05:00
c49d896e08 refactor(all): using ComponentInterface 2018-09-14 18:47:00 +02:00
6e5c035b39 chore(tslint): disable 'no-floating-promises' 2018-09-14 00:50:44 +02:00
ac42180f14 fix(toast): render on top 2018-09-12 23:06:00 +02:00
bf486e2c99 docs(overlay): onDidDismiss() and onWillDismiss() 2018-09-07 16:45:11 +02:00
ba2230510e refactor(all): strict boolean conditions 2018-09-01 17:23:03 +02:00
096d9a76f3 fix(css): add core.css (#15220)
fixes #15170
2018-08-29 18:05:20 +02:00
cc960c3d48 fix(overlays): expose mode, id, keyboardClose
fixes #15366
2018-08-29 16:19:51 +02:00
1d46973785 refactor(all): make all method return a promise 2018-08-28 22:20:10 +02:00
8b768fb73d fix(overlay): expose "animated" API
fixes #14775
2018-08-26 19:06:50 +02:00
d12ef78de6 refactor(all): cleanup mode font 2018-08-24 03:33:44 +02:00