Commit Graph

114 Commits

Author SHA1 Message Date
Amanda Johnston
07f013c9ac chore(angular): log error when attempting to use reserved prop with modals and popovers (#27491)
Issue number: resolves #27205

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

If an Angular component that makes use of `ModalController` or
`PopoverController` has a property of its own named `modal` or `popover`
respectively, this will collide with an internal reference to the
modal/popover element and cause errors.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

The actual behavior is unchanged, but a console error is logged guiding
the developer on how to fix the issue.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

I used the original reproduction from the issue to test. Full steps:

1. Clone the repo: https://github.com/Asac2142/expenses
2. Run `git checkout ef95c2e80a9991fe958d628f17ecc4e862c834ef` to get to
the app's state from when the issue was originally posted. Observe that
the component in `src/app/home/create-transaction` has a private prop
named `modal`.
3. Run `npm install`, then install the dev build: `npm install
@ionic/angular@7.0.7-dev.11684263140.15c242cf`
4. Run `ionic serve`. Click the fab button in the lower right. Observe
the console error. If you scroll down in the modal and click the
Category button, this will trigger the originally-reported issue.
5. Rename the private `modal` variable to something else, like `_modal`.
6. Refresh the page and re-open the modal. Note that no error is logged,
and the Category button can be clicked to open another modal without
issue.
2023-05-18 15:57:20 +00:00
Sean Perkins
1dee16f3a2 feat(angular,angular-server): angular v14 minimum support (#26822)
BREAKING CHANGE:

Angular v14 is now required to use `@ionic/angular` and `@ionic/angular-server`. Upgrade your project to Angular v14 by following the [Angular v14 update guide](https://update.angular.io/?l=3&v=13.0-14.0).

The dev-preview `environmentInjector` property has been removed from `ion-tabs` and `ion-router-outlet`. Standalone component routing is now available without additional custom configuration. Remove the `environmentInjector` property from your `ion-tabs` and `ion-router-outlet` components.
2023-02-22 12:33:49 -05:00
Liam DeBeasi
69d89eae94 fix(popover): popover opens on chrome 109 (#26672)
resolves #26643
2023-01-30 11:55:20 -05:00
Amanda Johnston
c2e1ad385d chore(many): replace any types and add tech debt tickets (#26293)
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-01-06 09:34:55 -06:00
Lars Mikkelsen
897bd4a8d0 ci: add CodeQL workflow (#25443)
Co-authored-by: Liam DeBeasi <liamdebeasi@icloud.com>
2022-06-17 15:54:16 -04:00
Sean Perkins
122cdcc825 fix(angular): add support for Angular 14 (#25403)
Resolves #25353
2022-06-07 10:11:53 -04:00
Mike Hartington
3451a34ad0 feat(angular): build for angular 12.0 (#23970) 2021-10-15 16:54:59 -04:00
Liam DeBeasi
c70a18ebc2 chore(): sync with main 2021-08-04 10:35:59 -04:00
Moritz Eck
caf0917623 docs(platform): add capacitor to method docs (#23688)
resolves #23687
2021-07-26 08:49:24 -04:00
Liam DeBeasi
5db60d9697 chore(): resolve merge conflicts 2021-06-21 14:03:47 -04:00
dejian-lc
e4bbaf8a7f chore(angular): fix typo in platform provider (#23385) 2021-06-01 08:52:36 -04:00
Liam DeBeasi
9e05891736 refactor(angular): remove Config.set() method (#22918)
BREAKING CHANGE: The `Config.set()` method has been removed. See https://ionicframework.com/docs/angular/config for examples on how to set config globally, per-component, and per-platform.
2021-02-12 13:54:34 -05:00
Liam DeBeasi
f34d3752e3 feat(all): add support for configuring animations on a per-page basis (#21433) 2020-06-08 15:49:14 -04:00
Liam DeBeasi
ae5f1ddff0 feat(app): keyboard open and close events (#18478) 2020-04-30 16:07:44 -04:00
Liam DeBeasi
3821c0463a feat(): add ability to continue processing hardware back button events (#20613)
fixes #17824
2020-04-27 12:58:37 -04:00
Liam DeBeasi
429edb053b feat(gesture): add option to run inside NgZone for Angular apps (#20685)
fixes #20529
2020-04-27 12:50:44 -04:00
Liam DeBeasi
407db752a0 chore(angular): update Config deprecation message (#19908)
* update deprecation msg

* add exact release
2019-11-14 11:30:25 -05:00
Liam DeBeasi
48a766246d feat(angular): expose Ionic Gestures via GestureController (#19864)
* expose gestures thru angular

* run linter
2019-11-08 10:35:52 -05:00
Liam DeBeasi
96a5e600e5 feat(animation): cubic-bezier easing conversion utility (experimental) (#19788)
resolves #19789
2019-10-31 10:16:33 -04:00
Liam DeBeasi
67a7e232b9 feat(angular): Expose Ionic Animations via the AnimationController (#19745)
* Add animation controller for angular

* remove empty constructor

* sync with master
2019-10-29 16:14:26 -04:00
Liam DeBeasi
17170f01da refactor(angular): removes Events service (#19600)
BREAKING CHANGES

The Events Service in @ionic/angular has been removed. 

- Use "Observables" for a similar pub/sub architecture: https://angular.io/guide/observables
- Use "Redux" for advanced state management: https://ngrx.io
2019-10-10 14:34:16 -04:00
Liam DeBeasi
1b9d61bfa8 refactor(): remove deprecated swipeEnable (#19526) 2019-10-10 14:34:16 -04:00
Manu MA
0f05ea4245 feat(config): expose getMode() and deprecate Config (#19104) 2019-09-25 17:21:43 +02:00
Manu MA
da5d3f0e04 refactor(): add warnings for deprecated CSS attributes 2019-08-28 13:53:21 +02:00
Manu MA
ef34402960 refactor(events): add deprecations (#19103) 2019-08-27 18:20:07 +02:00
Manu MA
c3044f59df feat(nav-link): merge nav-push/pop/set-root into a single component (#18909) 2019-08-27 18:14:13 +02:00
Manu MA
a65d897214 refactor(): deprecate web component controllers (#19109) 2019-08-27 14:00:45 +02:00
Manu MA
f94300cbb3 refactor(angular): use arrow functions (#18910) 2019-08-06 14:18:08 +02:00
Manu MA
3a22105375 fix(platform): subscribeWithPriority trigger change detection (#18962)
fixes #18959
2019-08-06 13:39:01 +02:00
Manu MA
544e550286 fix(platform): wrap event listeners around zone (#18853)
fixes #18831
2019-07-22 18:53:31 +02:00
Matthew Harris
854004cf2c docs(nav-controller): fix typos (#18848) 2019-07-22 11:00:53 -04:00
Ken Sodemann
fbfc07688e fix(menu-controller): add swipeGesture proxy (#18806) 2019-07-18 15:56:09 -05:00
Manu MA
97fec92365 fix(router-outlet): attach entering view before first change detection (#18821) 2019-07-18 10:26:54 +02:00
Manu Mtz.-Almeida
7953088418 fix(angular): fix linting issues 2019-07-05 20:32:42 +02:00
Manu Mtz.-Almeida
1add112be6 chore(): update stencil 2019-07-05 19:33:22 +02:00
Manu MA
b40f7d36d5 fix(): update to Stencil One 🎉🎊 2019-06-19 21:33:50 +02:00
Mark Levy
7610787e09 fix(angular): ensure all NavigationExtras values are preserved when navigating (#18468)
fixes #18469
2019-06-10 11:45:36 -04:00
Liam DeBeasi
b79f68a776 fix(angular): account for query params and fragments within a string (#18356)
* account for defaultHref, switch to serializer

* bug fix
2019-05-22 19:20:23 -04:00
Liam DeBeasi
4339ec3aa9 fix(angular): preserve special characters encoding when going back (#18323) 2019-05-21 16:06:31 -04:00
Liam DeBeasi
bdd5109dbe fix(angular): preserve queryParams and fragment when going back (#18298)
fixes #16744
2019-05-20 11:56:02 -04:00
Adam Bradley
f44c17e03b fix(ssr): fix angular global window and document references 2019-02-25 16:43:41 -06:00
Liam DeBeasi
cf2b2b370a feat(platform): add mobileweb platform 2019-02-01 08:43:32 -05:00
Manu MA
a7a2fc59bf docs(angular): adds docs to angular API (#17211) 2019-01-22 20:03:47 +01:00
Manu MA
766c79d2a1 feat(angular): add global pop() (#17182)
fixes #16340
2019-01-21 01:52:47 +01:00
Manu MA
a6559a4ef4 fix(angular): navigateRoot + animated (#17164)
fixes #17144
2019-01-18 17:08:53 +01:00
Manu MA
4d5dcd4778 fix(angular): hide some internal methods (#17121) 2019-01-15 16:04:22 +01:00
Manu MA
3aaf87ad0f fix(angular): NavController methods return a promise (#17106)
fixes #17103
2019-01-14 22:16:23 +01:00
Manu MA
27a4709195 fix(angular): ViewChild() fix (#17037)
fixes #17034
2019-01-10 12:59:29 +01:00
Manu MA
44fb45e2bc perf(angular): bundle size improvements for angular (#16966) 2019-01-07 22:05:36 +01:00
Manu MA
8ee9205629 fix(tabs): fix goto root (#16926)
fixes #16917
2019-01-01 17:51:38 +01:00