Commit Graph

21 Commits

Author SHA1 Message Date
Adam Bradley
c68292b78f test(rtl): add rtl script to all e2e tests (#17009) 2019-01-08 15:06:23 -06:00
Manu Mtz.-Almeida
3d656ac312 docs(all): improve type docs for event 2018-12-28 20:38:24 +01:00
Paul Stelzer
54e5a244ef fix(tab-bar): adds selected color if tab bar is using a color (#16766)
fixes #16761
2018-12-17 11:22:59 -05:00
Paul Stelzer
3e15402408 docs(tabs): Add changes after refactor (#16699) 2018-12-12 15:06:27 +01:00
Manu MA
147380533c fix(tab-bar): hide on keyboard events (#16688)
fixes #16419
2018-12-11 16:29:55 +01:00
Brandy Carney
2f63049909 fix(tab-bar): update tab-bar to set the color/background of tab-button (#16641)
similar to the PR for segment: https://github.com/ionic-team/ionic/pull/16590, this implements the color/background in the tab-bar and inherits it in tab-button

closes #14853
2018-12-10 17:33:06 -05:00
Manu MA
437ad09122 refactor(angular): lazy loading tabs (#16637)
Fixes #16619
2018-12-08 17:23:39 +01:00
Brandy Carney
8029df344a fix(segment): set colors in the parent segment and remove the unused color property (#16590)
* style(theming): clean up sass TODOs

* fix(item): use proper padding on small buttons in an item

* refactor(components): remove color from unused components

* chore(components): update build files to remove color

* fix(tab-bar): remove unused layout prop

* test(segment): add custom test and update standalone

* docs(segment): update usage examples to remove layout

* test(segment): update tests to remove layout

* test(tab-bar): update tests to remove layout

* fix(segment): set the colors in the parent segment

but use them in the child segment button

This allows the user to customize all of the segment buttons from segment, while still allowing the `color` property to take precedence, and they can also edit the segment button colors directly if desired.

This actually fixes some bugs surrounding colors and allows customization for a segment inside of a toolbar.

references #14853

* style(sass): fix lint errors

* chore(build): build files

* fix(segment-button): use transparent background

* docs(segment-button): add color activated back

* why does the build hate me

* fix(segment): set initial css variables to avoid inheriting

* fix(segment): set initial color activated

also add new line to the nav readme because reasons

* test(segment): parent mode should match children
2018-12-06 00:12:14 +01:00
Manu MA
6b7f8ae201 chore(): update stencil (#16506) 2018-11-29 18:54:51 +01:00
Brandy Carney
bc3e192427 fix(tab-bar): update to match MD design and remove transforms (#16348)
Updates the tab-bar to match the MD bottom navigation spec: https://material.io/design/components/bottom-navigation.html#specs

Changes proposed in this pull request:
- moved flex properties to host, inherit in child anchor element
  - this allows the user to customize the tab-button flex properties & fixes #16231
- increased letter spacing
- removed transforms / transitions on active tab
- decreased badge size, add badge styling when empty for MD
- fix badge positioning on both iOS and MD
- updates e2e tests, adds a preview test for tab-bar
- updates documentation surrounding tabs

fixes #16231
fixes ionic-team/ionic-docs#175
fixes ionic-team/ionic-docs#163
2018-11-21 12:07:37 -05:00
Manu Mtz.-Almeida
adae8d4ad1 fix(angular): adds tabs stack 2018-11-14 19:26:19 +01:00
Cam Wiegert
fda48a0e52 docs(tabs): document custom properties (#16225)
* docs(tab-bar): document custom properties

* docs(tab-button): document custom properties

* chore: fix lint error
2018-11-05 07:47:57 +01:00
Manu MA
091625df64 fix(all): update types to be required (#16218) 2018-11-03 20:54:58 +01:00
Manu MA
0680fe9251 docs(all): add global config docs (#16193)
* docs(all): add global config docs

fixes #16109

* lint issue

* add tabButtonLayout

* tabs docs
2018-11-02 17:30:37 +01:00
Manu MA
ecc2c55370 docs(all): possible values are extracted by stencil (#16190)
* docs(all): possible values are extracted by stencil

* add defaults

* remove all hardcoded defaults

* update stencil
2018-11-02 00:06:40 +01:00
Manu Mtz.-Almeida
72f0a76a1f fix(tabs): use slot instead of placement 2018-11-01 19:26:05 +01:00
Manu MA
1532bd2f48 fix(tab-bar): safe-bottom area is applied correctly (#16179)
* fix(tab-bar): safe-bottom area is applied correctly

fixes #16175

* add test
2018-11-01 18:29:33 +01:00
Manu MA
c2f58038f5 perf(angular): disable async queue (#16118)
* perf(angular): disable async queue

* wip

* update proxy
2018-10-30 20:33:46 +01:00
Brandy Carney
67eb7cf50d fix(tab-bar): align tab text to the center (#16130)
fixes #15273
2018-10-29 14:01:24 -04:00
Cam Wiegert
018fb9876f test(all): use test() instead of it() where appropriate (#16129)
This replaces uses of Jest's it() function in end-to-end tests with the alias test() where it makes sense semantically.
2018-10-29 12:40:06 -05:00
Manu MA
4d3ad67740 refactor(tabs): apply design-doc (#16048) 2018-10-25 22:13:19 +02:00