Commit Graph

62 Commits

Author SHA1 Message Date
Manu MA
6364e4e2a1 fix(inputs): keyboard focus improvements (#16838)
fixes #16815
fixes #16872
fixes #13978
fixes #16610
2019-01-11 19:36:02 +01:00
Adam Bradley
c68292b78f test(rtl): add rtl script to all e2e tests (#17009) 2019-01-08 15:06:23 -06:00
kplhub
09726b0d35 feat(radio-group): add missing implementation for property allowEmptySelection (#16880)
fixes #16841
2018-12-31 17:24:44 +01:00
Manu Mtz.-Almeida
3d656ac312 docs(all): improve type docs for event 2018-12-28 20:38:24 +01:00
Brandy Carney
4053f386fd refactor(components): consistent css variables for size (#16600)
Reviews the `--width` and `--height` variables in each component to either remove or add them based on need.

- fixes a bug where the spinner color wasn't being set properly in loading
- adds css variables for customizing background, color, some borders in overlays
- fixes a bug where prefix, suffix are taking up too much width in picker

closes #16097
references ionic-team/ionic-docs#228

BREAKING CHANGES

## Core Components

Removes the `--width` and `--height` variables from the following components, in favor of CSS:

- Button
- FAB Button
- Checkbox
  - Removes the `--width`/`--height` and adds a `--size` variable that is set on the width and height, allowing width and height to still be set and border-radius to still use it as a variable
- Radio
  - Removes the `--width`/`--height` and `--inner-width`/`--inner-height` variables. Calculates inner values based on parent element size.

## Overlay Components

The following components have all be converted to shadow (or scoped) and have CSS variables for width/height:

- Action Sheet _(scoped)_
- Alert  _(scoped)_
- Loading  _(scoped)_
- Menu _(shadow)_
- Modal  _(scoped)_
- Picker _(scoped)_
- Popover  _(scoped)_
- Toast _(shadow)_

The above components will now have the following CSS variables for consistency among overlays:

| Name              |
| ----------------- |
| `--height`        |
| `--max-height`    |
| `--max-width`     |
| `--min-height`    |
| `--min-width`     |
| `--width`         |

If the component does not set the value, it will default to `auto`.

## Removed CSS Variables

The following CSS properties have been removed:

| Component      | Property            | Reason                          |
| ---------------| --------------------| --------------------------------|
| **Button**     | `--height`          | Use CSS instead                 |
| **Button**     | `--margin-bottom`   | Use CSS instead                 |
| **Button**     | `--margin-end`      | Use CSS instead                 |
| **Button**     | `--margin-start`    | Use CSS instead                 |
| **Button**     | `--margin-top`      | Use CSS instead                 |
| **Button**     | `--width`           | Use CSS instead                 |
| **Checkbox**   | `--height`          | Use CSS or `--size`             |
| **Checkbox**   | `--width`           | Use CSS or `--size`             |
| **FAB Button** | `--width`           | Use CSS instead                 |
| **FAB Button** | `--height`          | Use CSS instead                 |
| **FAB Button** | `--margin-bottom`   | Use CSS instead                 |
| **FAB Button** | `--margin-end`      | Use CSS instead                 |
| **FAB Button** | `--margin-start`    | Use CSS instead                 |
| **FAB Button** | `--margin-top       | Use CSS instead                 |
| **Menu**       | `--width-small`     | Use a media query and `--width` |
| **Radio**      | `--width`           | Use CSS instead                 |
| **Radio**      | `--height`          | Use CSS instead                 |
| **Radio**      | `--inner-height`    | Calculated based on parent      |
| **Radio**      | `--inner-width`     | Calculated based on parent      |
2018-12-14 15:45:14 -05:00
Brandy Carney
7ba94900bb refactor(themes): remove the outer-content class from core (#16589)
BREAKING CHANGES

The outer-content class has been removed in favor of setting the color in your app instead:

```
.outer-content {
  --background: #f2f2f2;
 }
```
2018-12-04 16:38:50 -05:00
Manu MA
6b7f8ae201 chore(): update stencil (#16506) 2018-11-29 18:54:51 +01:00
Daniel Karlsson
509650349e fix(radio): removd hard coded inner-width and inner-height for iOS 2018-11-29 13:53:25 +01:00
Manu MA
50b0c6f15d fix(alert): accepts any value (#16476)
fixes #16170
2018-11-27 16:29:12 +01:00
Manu Mtz.-Almeida
a85ef06ac9 chore(): update stencil + api-spec file 2018-11-20 10:06:02 +01:00
Manu MA
fd79b57748 fix(inputs): fix aria with shadow-dom (#16329) 2018-11-16 19:26:55 +01:00
Brandy Carney
e416c23b3b fix(item): update to match Material Design spec (#16182)
- splits the item min height by mode
- removes padding end from the slotted end components in favor of using 16px on the item
- updates the icon color to lighter gray (rgb)
- removes font size change from text wrapped labels
- add list spec test to include MD examples

fixes #14799
2018-11-04 10:58:57 -05:00
Manu MA
ecc2c55370 docs(all): possible values are extracted by stencil (#16190)
* docs(all): possible values are extracted by stencil

* add defaults

* remove all hardcoded defaults

* update stencil
2018-11-02 00:06:40 +01:00
Cam Wiegert
018fb9876f test(all): use test() instead of it() where appropriate (#16129)
This replaces uses of Jest's it() function in end-to-end tests with the alias test() where it makes sense semantically.
2018-10-29 12:40:06 -05:00
Manu MA
ef6895acbd fix(inputs): disabled handling (#16071) 2018-10-25 22:50:06 +02:00
Cam Wiegert
672324886a fix(radio): match MD sizing (#16087)
This adjusts the sizing and proportions of our radio input to match the updated Material Design spec.
2018-10-25 10:58:19 -05:00
Adam Bradley
3c7fee5cca test(e2e): relative paths (#16077) 2018-10-24 22:41:48 -05:00
Adam Bradley
a9fd3399de test(e2e): force roboto font on all systems (#15993) 2018-10-19 15:22:15 -05:00
Manu Mtz.-Almeida
3a4b21457f chore(): update stencil 2018-10-12 11:44:43 -05:00
Manu Mtz.-Almeida
a72fced6fe fix(all): docs for all missing props 2018-10-11 16:24:08 -05:00
Cam Wiegert
ae3271f2d7 test(all): inject test styles on flag 2018-10-11 15:13:23 -05:00
Brandy Carney
798b4f6935 test(radio): update standalone test 2018-10-10 11:35:23 -05:00
Manu Mtz.-Almeida
a999c1f0a9 perf(): prevent unnecesary event listener changes 2018-10-09 16:03:14 -05:00
Daniel Imhoff
2172aa9dae test(screenshot): use Arial for testing 2018-10-09 13:40:31 -05:00
Manu Mtz.-Almeida
e81af2d5aa fix(picker): stop animation when it's closed
fixes #15854
2018-10-08 14:53:47 -05:00
Manu Mtz.-Almeida
9d109d68c8 fix(all): disable animations in e2e tests 2018-10-08 10:18:31 -05:00
Cam Wiegert
5aaacbc91b test(radio): migrate e2e tests
references #15803
2018-10-01 14:31:25 -05:00
Manu Mtz.-Almeida
9ec8e748a6 fix(radio): add css variables to make it customizable
fixes #15729
2018-09-25 02:53:40 +02:00
Manu Mtz.-Almeida
c49d896e08 refactor(all): using ComponentInterface 2018-09-14 18:47:00 +02:00
Brandy Carney
21d1f2e2dd fix(item): update hostContext to use ion-item element
fixes styling issues with children elements using the .in-item class
2018-09-13 11:46:13 -04:00
Manu Mtz.-Almeida
e7416435d8 refactor(all): additional tslint rules 2018-09-01 18:06:59 +02:00
Manu Mtz.-Almeida
ba2230510e refactor(all): strict boolean conditions 2018-09-01 17:23:03 +02:00
Cam Wiegert
0f9a7b4252 fix(radio): add and document custom properties
references #14850
2018-08-30 13:20:02 -05:00
Manu MA
096d9a76f3 fix(css): add core.css (#15220)
fixes #15170
2018-08-29 18:05:20 +02:00
Manu Mtz.-Almeida
16452b2455 fix(radio-group): accept any value
fixes #15334
2018-08-29 02:41:48 +02:00
Manu Mtz.-Almeida
d856ecfbbf chore(): update to latest stencil 2018-08-12 12:04:27 +02:00
Manu Mtz.-Almeida
2e7d355edf fix(input): event interfaces 2018-08-12 01:18:59 +02:00
Manu Mtz.-Almeida
690726f918 refactor(radio): move pointer-events to base CSS
relates to #15129
2018-08-10 20:11:55 +02:00
Manu Mtz.-Almeida
c1b61d0fee chore(): update to ionic-rules/strict 2018-07-29 23:10:38 +02:00
Manu Mtz.-Almeida
8a1ad1da2c fix(app): user-select on desktop 2018-07-29 14:48:05 +02:00
Manu Mtz.-Almeida
b4976dd914 chore(): update docs 2018-07-24 23:05:35 +02:00
Brandy Carney
2c37a5a7b2 docs(previews): update preview tests to have translucent white toolbars
to make ben happy
2018-07-24 16:27:17 -04:00
Brandy Carney
f0c15384a2 docs(components): update color documentation 2018-07-24 11:59:32 -04:00
Brandy Carney
7a8d5f68d2 chore(stylelint): remove sass-lint/scss-lint in favor of stylelint
- remove scss-lint and sass-lint
- add stylelint and stylelint-order packages and configuration
- update all *.scss files to new syntax

fixes #14805
2018-07-19 15:10:30 -05:00
Brandy Carney
8923aa7351 docs(components): add missing angular usage 2018-07-09 18:37:09 -04:00
Brandy Carney
a7f1f4daa7 refactor(components): update to use shadow DOM and work with css variables
- updates components to use shadow DOM or scoped if they require css variables
- moves global styles to an external stylesheet that needs to be imported
- adds support for additional colors and removes the Sass loops to generate colors for each component
- several property renames, bug fixes, and test updates

Co-authored-by: Manu Mtz.-Almeida <manu.mtza@gmail.com>
Co-authored-by: Adam Bradley <adambradley25@gmail.com>
Co-authored-by: Cam Wiegert <cam@camwiegert.com>
2018-07-09 12:57:21 -04:00
Brandy Carney
81611946ee docs(components): running validate built some docs 2018-06-14 16:31:08 -04:00
mhartington
04e807f459 docs(): update examples 2018-06-14 11:46:44 -04:00
Manu Mtz.-Almeida
618f708bc4 fix(all): strong typing for color 2018-05-14 13:51:30 +02:00
Manu Mtz.-Almeida
cc7ab4e3c6 fix(all): snapshot tests 2018-05-08 16:05:06 +02:00