Commit Graph

38 Commits

Author SHA1 Message Date
Amit Moryossef
5d562166fc refactor(): global refactoring to avoid IDE warnings and cleaner code (#11296)
* refactor(style): redundant measure units

* refactor(): change pointless boolean operation to cast

* refactor(): change redundant 'if' statement

* refactor(style): remove overwritten property value

* fix(spellcheck): wrong attribute value

* refactor(datetime-test): There should be a space between attribute and previous attribute

* refactor(import): import can be shortened

* refactor(semicolon): add missing semicolon

* docs(): fix incorrect parameter name

* refactor(): remove trailing unused parameters

* fix(menu): create mock change signature

* refactor(): remove redundant imports
all tests are passing

* refactor(style): 'var' used instead of 'let' or 'const'

* Revert "refactor(style): 'var' used instead of 'let' or 'const'"

This reverts commit 0369dbcaa8.

* refacrot(): remove unused code

* Revert "refactor(style): remove overwritten property value"

* revert(hammer): don't modify 3rd party files

* revert(activator): follow interface

* revert(activator): follow interface (cont)

* revert(activator): follow interface (cont)

* merge(master): fix conflicts

* revert(): change pointless boolean operation to cast

* revert(): text align is covered by a different PR

* revert(): add back unused parameters

* revert(): add back unused parameters
2017-05-05 01:11:00 +02:00
Manuel Mtz-Almeida
f88823a30f fix(navcontroller): lazy loading is queued 2017-04-18 20:55:41 +02:00
perry
396f891f33 chore(docs): updating dgeni typescript package 2017-03-14 14:50:31 -05:00
Manu MA
9e4c3a6e3e feat(split-panel): split panel support for ion-nav and ion-menu (#10343)
* feat(split-panel): split panel support for ion-nav and ion-menu

Revert some changes

adds support split-panel support for tabs

Removes .orig

removes e2e.ts

Removes unneeded changes in menu.ts

improves stuff

* fix(split-panel): resize is called when menu wraps a ion-nav

* test(split-panel): improves split-panel/basic test

* feat(split-panel): ionChange is an ng2 @Output()

* fix(split-panel): fix tabs as side content

* fix(menu): forzedClose works as expected

* feat(split-panel): split-panel works with several menus

* chore(split-panel): renames to split-pane

* refactor(split-pane): splitPane can be injected

* fix(split-pane): it is a directive

* fix(slides): integration with split-panel

* Make gulp validate happy
2017-03-03 20:13:07 +01:00
Adam Bradley
7000b1b173 refactor: improve tree shaking abilities
Internal refactor completed in order to improve tree shaking and dead
code removal. The public API, with an exception to ion-slides, has
stayed the same. However, internally many changes were required so
bundlers could better exclude modules which should not be bundled.
Ultimately most changes resorted to removing references to `window` or
`document`, or a module that referenced one of those.

BREAKING CHANGES

ion-slides was refactored to remove the external dependencies, and
rewritten in TypeScript/ES6 modules to again improve tree shaking
abilities.
2017-01-09 09:51:39 -06:00
Adam Bradley
071ad2ef3f chore(ts): fix noImplicitAny errors 2016-12-08 11:17:43 -06:00
Manu Mtz.-Almeida
ccb6bf1390 fix(modal): using cross mode animations
fixes #9323
2016-11-30 13:30:28 +01:00
Manu Mtz.-Almeida
76df8412b4 test(animation): adds more asserts 2016-11-28 01:34:46 +01:00
Manu Mtz.-Almeida
320989540e perf(menu): improves menu performance and fixes some edge cases 2016-11-25 22:56:53 +01:00
Manu Mtz.-Almeida
91478edd9f fix(menu): improves menu swipe animation 2016-11-23 20:16:28 +01:00
Manu Mtz.-Almeida
4be47bd3dd fix(animation): improve menu and go back swipe 2016-11-21 23:09:57 +01:00
Manu Mtz.-Almeida
cfbc5eabca perf(picker): improves picker UX feedback 2016-11-17 09:53:39 +01:00
Manu Mtz.-Almeida
91f5087bc6 fix(animation): regression in _willChg() 2016-11-16 21:06:52 +01:00
Manu Mtz.-Almeida
c44f6b6f2e perf(animation): improves _progress() hot function
- progress() is the function where more time is spent during any swipe gesture
- replace iterating over the _fx properties, using an array instead
- optimize pointerCoord(), profiler showed it’s one of the most called functions
2016-11-16 19:48:35 +01:00
Manu Mtz.-Almeida
c78dc19754 perf(animation): optimizing hot loops
- local variable optimization
- progressStep() does not debounce
2016-11-16 16:22:52 +01:00
Manu Mtz.-Almeida
3a2ff85f6a perf(animation): set after styles should not be recursive 2016-11-16 13:41:54 +01:00
Manu Mtz.-Almeida
d9e9ece836 fix(animation): always run before classes and functions
fixes #8842
fixes #8769
2016-11-14 10:24:05 -06:00
Manu Mtz.-Almeida
04d61ee47a fix(nav): swipe to go back gesture
- smoother by debouncing touch events (reduces bank)
- dynamic animation duration
- intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item)

fixes #8919
fixes #8958
fixes #7934
2016-11-01 13:38:27 -05:00
Manu Mtz.-Almeida
13b32896fa refactor(nav): adds some asserts and small changes 2016-10-18 19:09:38 +02:00
Manu Mtz.-Almeida
d9e8b1bec6 refactor(nav-controller-base): cleanup some logic
NavControllerBase is the core of ionic 2 navigation. It handles all the transitions and it is complicated code to follow.
I am refactoring it to allow future developers and contributors to follow it better.

!node.parent now becomes node.isRoot()

ViewController does not remove itself from the stack, but two new auxiliar function in nav controller: _insertView() and _removeView() are used to add a view to the stack.

And so on...

All e2e and unit tests passing...
2016-10-18 16:36:55 +02:00
Manu Mtz.-Almeida
ff1f340285 test(assert): adds new debugging assert() util
improves removing of console.debug statements

fixes #8483
2016-10-18 09:10:00 -05:00
Adam Bradley
0e8ebe5734 fix(animation): prevent possible raf null errors 2016-09-19 08:43:27 -05:00
Adam Bradley
7c05d0c0ba fix(di): update dependency injection and default configs 2016-09-16 00:49:09 -05:00
Adam Bradley
41a7e07651 refactor(transition): create transition controller 2016-09-13 15:12:14 -05:00
Szymon Stasik
9fa31a1ec8 fix(animation): ele as string selector 2016-07-24 21:12:20 -05:00
Manu Mtz.-Almeida
ac8e4dce06 style(all): tslinter warnings 2016-07-19 13:31:46 -07:00
perry
4f52135c13 Revert "Revert "Merge branch 'master' of https://github.com/driftyco/ionic""
This reverts commit 4a6086c1f8.
2016-07-18 19:40:03 -05:00
perry
4a6086c1f8 Revert "Merge branch 'master' of https://github.com/driftyco/ionic"
This reverts commit 8945bf906d, reversing
changes made to f4fac225fa.
2016-07-18 19:24:56 -05:00
Manu Mtz.-Almeida
cac378f35b fix(menu): only one menu can be opened at a time
fixes #6826
2016-07-17 20:42:29 -05:00
Adam Bradley
0cb093e394 fix(animation): fix easing timing function
Closes #7130
2016-06-30 09:53:09 -05:00
Manu Mtz.-Almeida
267aa32f5a perf(animation): using will-change when using progressStep() 2016-06-30 08:17:17 -05:00
Adam Bradley
3a7addf7b0 feat(toolbar): control toolbar borders on top/bottom
Toolbars can be stacked up vertically in `<ion-header>`,
`<ion-content>`, and `<ion-footer>` elements. However, toolbars also
come with borders on both the top and bottom of the toolbar. To give
developers full control of the design, Ionic also includes the
`no-border-bottom` and `no-border-top` attributes. For example,
sometimes two vertically stacked toolbars may have different background
colors, in this case it might be best to leave a border between them.
However, if they have the same background color, the app may look best
without a border between them. The main point here is, it's entirely up
to the app's design to decide when and when not to show borders between
toolbars, and to do so then each toolbar can individually set
`no-border-bottom` and `no-border-top` attributes.
2016-06-20 12:01:21 -05:00
Adam Bradley
a1223da08c fix(animation): correctly apply will-change: transform 2016-06-19 10:43:12 -05:00
Adam Bradley
d13fa4e2cf refactor(structure): allow content to scroll under headers/footers 2016-06-16 11:28:02 -05:00
Adam Bradley
d23c75a229 chore(animation): add any as type 2016-06-08 12:20:31 -05:00
Adam Bradley
03f4511635 chore(tslint): fix noImplicitAny errors 2016-05-31 18:40:29 -05:00
Brandy Carney
57a1274b6c feat(popover): modify the animation for each mode
add another wrapper div to fix the arrow not animating at the same time.

references #5420
2016-05-24 16:00:23 -04:00
Josh Thomas
c8f760f080 chore(build): rename ionic directory to src and update all references in the build process. 2016-05-19 13:22:40 -05:00