Commit Graph

61 Commits

Author SHA1 Message Date
Andrew
7ef9ad74cf fix(slidebox): refactor for performance and stability
Closes #2336. Closes #2317. Closes #2290. Closes #2228. Closes #2067.
Closes #1890. Closes #1865. Closes #1850. Closes #1755. Closes #1688.
Closes #1578. Closes #1501. Closes #1353. Closes #1342. Closes #782.
Closes #416. Closes #2288.

BREAKING CHANGE: The slideBox's API has undergone many changes.

- **`<ion-slide-box>`** attributes have changed (see
  [documentation](http://ionicframework.com/docs/api/directive/ionSlideBox)):

  * `active-slide` has changed to `selected`. Change your code from
  this:

    ```html
    <ion-slide-box active-slide="activeSlideIndex"></ion-slide-box>
    ```

    To this:

    ```html
    <ion-slide-box selected="activeSlideIndex"></ion-slide-box>
    ```

  * `does-continue` has changed to `loop`.  Change your code from this:

    ```html
    <ion-slide-box does-continue="shouldLoop"></ion-slide-box>
    ```

    To this:

    ```html
    <ion-slide-box loop="shouldLoop"></ion-slide-box>
    ```

  * `auto-play` and `slide-interval` have been merged into `auto-play`.
  Change your code from this:

    ```html
    <!-- autoPlay is on -->
    <ion-slide-box auto-play="true" slide-interval="1000">
    </ion-slide-box>
    <!-- autoPlay is off -->
    <ion-slide-box auto-play="false" slide-interval="1000">
    </ion-slide-box>
    ```

    To this:

    ```html
    <!-- autoPlay is on -->
    <ion-slide-box auto-play="1000"></ion-slide-box>
    <!-- autoPlay is off -->
    <ion-slide-box auto-play="false"></ion-slide-box>
    ```

  * `show-pager` and `pager-click` have been removed. Use
  a child `<ion-slide-pager>` element. See the [`ion-slide-pager`
  documentation](http://ionicframework.com/docs/api/directive/ionSlidePager).
  Change your code from this:

  ```html
  <!-- pager using default click action -->
  <ion-slide-box show-pager="true">
  </ion-slide-box>
  <!-- pager with custom click action -->
  <ion-slide-box show-pager="true" pager-click="doSomething(index)">
  </ion-slide-box>
  ```

  To this:

  ```html
  <ion-slide-box>
    <!-- pager using default click action -->
    <ion-slide-pager></ion-slide-pager>
  </ion-slide-box>
  <ion-slide-box>
    <!-- pager with custom click action -->
    <ion-slide-pager ng-click="doSomething(index)"></ion-slide-pager>
  </ion-slide-box>
  ```

- **`$ionicSlideBoxDelegate`** methods have changed (see
  [documentation](http://ionicframework.com/docs/api/service/$ionicSlideBoxDelegate)):

  - `update()` has been removed. slideBox updates on its own now.

  - `stop()` has been removed. See `autoPlay()` below.

  - `start()` hass been removed. See `autoPlay()` below.

  - `slide(newIndex[, speed])` has been renamed to `select(newIndex[,
    speed]);

  - `currentIndex()` has been renamed to `selected()`.

  - `slidesCount()` has been renamed to `count()`.

  - New method `$ionicSlideBoxDelegate.autoPlay()`. Change your code
    from this:

    ```js
    // stop auto sliding
    $ionicSlideBoxDelegate.stop();
    // later... start auto sliding
    $ionicSlideBoxDelegate.start();
    ```

    To this:

    ```js
    var autoPlaySpeed = 3000; //wait 3000 seconds between changing slide
    // stop auto sliding
    $ionicSlideBoxDelegate.autoPlay(false);
    // later... start auto sliding
    $ionicSlideBoxDelegate.autoPlay(autoPlaySpeed);
    ```

  - `previous()` now returns the index of the previous slide and does
    not select. Change your code from this:

    ```js
    // select previous slide
    $ionicSlideBoxDelegate.previous();
    ```

    To this:

    ```js
    // select previous slide
    $ionicSlideBoxDelegate.select( $ionicSlideBoxDelegate.previous() );
    ```
  - `next()` now returns the index of the next slide and does
    not select. Change your code from this:

    ```js
    // select next slide
    $ionicSlideBoxDelegate.next();
    ```

    To this:

    ```js
    // select next slide
    $ionicSlideBoxDelegate.select( $ionicSlideBoxDelegate.next() );
    ```
2014-10-08 11:09:15 -06:00
Perry Govier
34934f636e fix(loading): prevent loading service from disabling all future back button behavior. Fixes #2214 2014-10-07 14:19:20 -05:00
Perry Govier
5658a4df0c fix(popup): prevent back to back popups from dismissing background. Fixes #2071 2014-09-26 16:43:27 -05:00
Perry Govier
cffe631866 fix(loading): subsequent calls use config defaults and not last call's options. Fixes #2066, #2088 2014-09-26 15:26:01 -05:00
Adam Bradley
68de8ed910 fix(history): tabs lose history after switching tabs
It was possible that when switching between tabs, and creating a
navigation history in one of the tabs, then switching tabs again, it
could clear out the individual tab stacks under certain scenarios.
Closes #1978
2014-09-16 00:13:29 -05:00
Adam Bradley
73a30e0659 test(): fix $timeout.flush 2014-09-15 00:07:12 -05:00
Adam Bradley
2c3f1c9f02 feat($ionicBody): service to simplify body ele interaction
Many services/directives have to interact with the body element, and
each one has to write the same long code. The $ionicBody service
provides some useful methods to clean up and reduce redundant code.
2014-08-26 22:23:07 -05:00
Andrew
e00e938040 test(popover): fix tests for container addition 2014-08-20 14:29:11 -06:00
Andrew
6d859f4876 fix(popup): fix alignment, backdrop not fading out 2014-08-20 14:17:19 -06:00
Perry Govier
25ee658e8b amend(loading): simpler/more clean fix for #1914 2014-08-20 13:04:48 -05:00
Perry Govier
65aece2aad fix(loading): potential race condition with showing and hiding loading in same watch cycle 2014-08-19 15:07:10 -05:00
Perry Govier
944a92b08d feat(templateCache): automatically cache template files to prevent flicker on page navigation and improve performance
State templates are cached automatically, but you can optionally cache other templates.
```js
$ionicTemplateCahce('myNgIncludeTemplate.html');
```

Optionally disable all preemptive caching with the `$ionicConfigProvider` or individual states by setting `prefetchTemplate`
in the $state definition
```js
$ionicTemplateCahce('myNgIncludeTemplate.html');
```js
  angular.module('myApp', ['ionic'])
  .config(function($stateProvider, $ionicConfigProvider) {

    // disable preemptive template caching globally
    $ionicConfigProvider.prefetchTemplates(false);

    // disable individual states
    $stateProvider
      .state('tabs', {
        url: "/tab",
        abstract: true,
        prefetchTemplate: false,
        templateUrl: "tabs-templates/tabs.html"
      })
      .state('tabs.home', {
        url: "/home",
        views: {
          'home-tab': {
            prefetchTemplate: false,
            templateUrl: "tabs-templates/home.html",
            controller: 'HomeTabCtrl'
          }
        }
      });
  });
```
2014-08-15 15:10:19 -05:00
Andrew
834e2bb173 amend($ionicConfigProvider): fix typo, add unit tests 2014-08-15 13:11:44 -06:00
Andrew
8c6d5f2c96 fix(collectionRepeat): simplify item reusing process to fix rare reuse error
Closes #1777.
2014-08-13 10:30:44 -06:00
Perry Govier
044fac4d77 fix(popup): only override prompt input if template includes HTML 2014-08-08 15:00:19 -05:00
Andrew
41a2124d45 test(): fix phantomjs test problems for CircleCI 2014-08-06 12:10:34 -06:00
Andrew
7ddb57e60b feat(collectionRepeat): other children of ion-content element fit in
Closes #1920. Closes #1866. Closes #1380.
2014-08-06 10:32:40 -06:00
Perry Govier
ae87c66b12 fix(popup): backdrop release fires with every close 2014-08-05 11:16:46 -05:00
Max Lynch
64641b1be0 fix(viewService): No error on clearHistory for empty history 2014-08-04 14:17:54 -05:00
Adam Bradley
c1215aa300 feat(popover): created popovers 2014-07-31 14:43:29 -05:00
Perry Govier
4f6d02cfcb refactor(modal): trigger resize event on the window when modal opens
A better approach to resolving an issue with collection-repeat sizing itself properly. This keeps directives independent of eachother.
2014-07-24 14:45:40 -05:00
Andrew
26ca840dfc feat($ionicLoading): add $ionicLoadingConfig constant for default options
Closes #1800
2014-07-21 08:22:43 -06:00
Andrew
7e20424a87 test(platform): fix unit tests for setting platform to null 2014-07-21 08:22:07 -06:00
Perry Govier
7630bd419f fix(loading): Prevent clicks on modal views when loading is active. Closes #1720 2014-07-03 16:16:21 -05:00
Perry Govier
3e6ce1831b fix(popup): if popup is taller than the window, shrink the popup body and make it scrollable. Closes #1679 2014-06-27 11:27:06 -05:00
Andrew Joslin
b2585f19ca fix(collectionRepeat): fix scroll when item bigger than viewport
Closes #1621
2014-06-17 17:42:10 +00:00
Andrew Joslin
087e55f320 feat($ionicActionSheet): add cancelOnStateChange option, default true
Closes #1318

BREAKING CHANGE: $ionicActionSheet's default behavior is now to cancel
when the app's state changes.  To disable this behavior, pass
`cancelOnStateChange: false` into $ionicActionSheet.show().
2014-06-11 11:28:53 -06:00
Andrew Joslin
30a3c8e0c8 fix(collectionRepeat): remove elements at correct time when leaving page 2014-06-11 08:43:00 -06:00
Andrew Joslin
6af5d68da4 feat(collectionRepeat): huge optimization upgrades
Closes #1597
2014-06-10 17:56:35 -06:00
Andrew Joslin
8c36a667d8 test(actionSheet): fix test for angular v1.2.17 2014-06-10 15:27:48 -06:00
Andrew Joslin
b7646a5630 fix($ionicActionSheet): stop memory leak due to hidden element staying in dom
BREAKING CHANGE: $ionicActionSheet now returns a method to hide the
action sheet.

Previously, it returned an object that had a `show` and `hide` method.
This was undocumented, but if you used it, here is how to migrate your
code:

Change your code from this:

```js
var sheet = $ionicActionSheet.show({...});
sheet.hide();
```

To this:

```js
var hideSheet = $ionicActionSheet.show({...});
hideSheet();
```
2014-06-06 13:45:38 -04:00
Andrew Joslin
9942045fb2 amend($ionicModal): if hardwareBackButtonClose false, back button is noop
Addresses #1397
2014-06-05 07:29:39 -06:00
Andrew Joslin
9ffca1e4eb feat($ionicModal): add hardwareBackButtonClose as option, default true
Closes #1397
2014-06-04 13:45:21 -06:00
Max Lynch
4c700e9c0f fix(backdrop): Changed z-index for loading backdrop only. Fixes #1428 2014-05-22 10:43:52 -05:00
Andrew Joslin
94f0b5b705 fix(collectionRepeat): fix rare NPE error on android 4.1
Closes #1292
2014-05-21 07:44:21 -06:00
Andrew Joslin
291d723ab1 feat($ionicModal): allow configuration of backdropClickToClose
Addresses #1087
2014-05-12 08:24:19 -06:00
Adam Bradley
4928b996d6 set WP8 as a grade-b device 2014-05-09 09:33:35 -05:00
Andrew Joslin
95d1aea4f1 chore(travis): re-enable jshint 2014-05-08 09:11:16 -06:00
Adam Bradley
6e32c2f880 Merge initial wp8 fixes 2014-05-07 15:47:35 -05:00
Adam Bradley
08e4b3d95b feat(platform): added isWindowsPhone() method 2014-05-07 14:48:36 -05:00
Andy Joslin
9de67e0ab7 test(gesture): make it use ionic.CustomEvent 2014-05-07 12:21:11 -06:00
Andy Joslin
fc8711c7d0 feat($ionicLoading): on android, no back button action while loading
Fixes #1273
2014-05-05 12:15:32 -06:00
Andy Joslin
74891acaf4 test(collectionRepeatManager): finish testing .render() 2014-05-05 09:19:21 -06:00
Adam Bradley
6b3c2b929a merge keyboard-fixes 2014-05-03 22:30:21 -05:00
Adam Bradley
d2ebed847e fix(modal): Remove modal flicker, closes #1150 2014-05-02 11:49:16 -05:00
Adam Bradley
5f8e9040bd fix(viewport): Auto update viewport tag 2014-05-02 10:12:48 -05:00
Adam Bradley
05a6d7cca6 fix(tap): input[file] clicks within ion-content, closes #1237 2014-05-01 08:54:13 -05:00
Andy Joslin
aeda31669b test($ionicModal): add test for unbinding event 2014-04-30 13:46:09 -06:00
Andy Joslin
5c3c65d17f test($ionicModal): add better tests for backdrop click 2014-04-30 13:43:07 -06:00
Andy Joslin
b87bcb30c3 feat($ionicPopup): on android, make back button close popup
Fixes #1222
2014-04-29 09:07:13 -06:00