139 Commits

Author SHA1 Message Date
c0200f7447 dosc(navigation): rename params variable to navParams (#11709)
Aligning the code sample to match the generated code from the CLI’s
page generator.
2017-05-19 13:06:46 -04:00
6d11499417 fix(view-controller): _dismissRole is a string 2017-05-05 01:55:50 +02:00
5d562166fc refactor(): global refactoring to avoid IDE warnings and cleaner code (#11296)
* refactor(style): redundant measure units

* refactor(): change pointless boolean operation to cast

* refactor(): change redundant 'if' statement

* refactor(style): remove overwritten property value

* fix(spellcheck): wrong attribute value

* refactor(datetime-test): There should be a space between attribute and previous attribute

* refactor(import): import can be shortened

* refactor(semicolon): add missing semicolon

* docs(): fix incorrect parameter name

* refactor(): remove trailing unused parameters

* fix(menu): create mock change signature

* refactor(): remove redundant imports
all tests are passing

* refactor(style): 'var' used instead of 'let' or 'const'

* Revert "refactor(style): 'var' used instead of 'let' or 'const'"

This reverts commit 0369dbcaa877b69534e6e78cb17f6b8aa7603597.

* refacrot(): remove unused code

* Revert "refactor(style): remove overwritten property value"

* revert(hammer): don't modify 3rd party files

* revert(activator): follow interface

* revert(activator): follow interface (cont)

* revert(activator): follow interface (cont)

* merge(master): fix conflicts

* revert(): change pointless boolean operation to cast

* revert(): text align is covered by a different PR

* revert(): add back unused parameters

* revert(): add back unused parameters
2017-05-05 01:11:00 +02:00
3b4b29e832 refactor(action-sheet): adds proper TS types 2017-05-05 01:01:49 +02:00
7f7c3cd514 Merge branch 'master' of github.com:driftyco/ionic; branch 'onDidDismiss-doc' of https://github.com/icedt89/ionic 2017-05-05 00:32:10 +02:00
646d736d07 fix(navcontrollerbase): popToRoot should not remove root view 2017-05-05 00:17:30 +02:00
abf6bd1f68 - typified onDidDismiss and onWillDismiss signature to clearify supplied parameters 2017-05-04 21:23:19 +02:00
d701799d8b refactor(nav-interfaces): remove unecessary semicolons (#11450) 2017-05-01 02:35:46 +02:00
ed66591db6 test(view-controller): adds isOverlay asserts 2017-05-01 02:19:35 +02:00
cc1eb02337 fix(navcontrollerbase): fixes crash when it is destroyed
fixes #11338
2017-04-24 15:19:34 +02:00
53113366e2 fix(menu): rtl support 2017-04-24 01:02:20 +02:00
51d507998c fix(menu): rtl support
Squashed commit of the following:

commit 57b59eb373e76401caf1c42fa696a67e1e6a69b7
Merge: dcf80e416 f26c4b4fe
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Fri Apr 21 14:38:03 2017 +0300

    merge 'master'

commit dcf80e4161f33ca3ff4cea5ce0c6358107bbcdff
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Fri Apr 21 01:24:40 2017 +0300

    tests(menu): add menu rtl tests

commit d65575b9ca63402fdc49991349320ad1dd76f114
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Fri Apr 21 01:24:00 2017 +0300

    tests(mock): add platform to mockMenu

commit faad17ca3231d999296907a9892b3afdb48e124f
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Fri Apr 21 01:23:01 2017 +0300

    fix(menu): update gesture only if it exists

commit e50eb184ec5af3cfdb3634b1d7cfe1899da36054
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Fri Apr 21 00:55:50 2017 +0300

    refactor(menu): use magic get/set for side update

commit 89a1715661fa889157f39401c419fc55d4809f9e
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Thu Apr 20 19:31:49 2017 +0300

    revert(menu): revert removed dependency
    this PR is for a specific feature

commit 7c1263624c68fc2729b24f10956841b6ff0c22f6
Merge: 4465f82f6 860567288
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Thu Apr 20 19:26:10 2017 +0300

    Merge remote-tracking branch 'upstream/master' into menu

commit 4465f82f644a96830379fe3bef8e0fbe53e6f998
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Thu Apr 20 16:11:13 2017 +0300

    style(backdrop): fix code style

commit da4983a16133ee7d85f3393161d16fe1a33d2fa4
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Thu Apr 20 16:09:18 2017 +0300

    revert(renderer): back to renderer1

commit 80ab0941d6351e3787dba11c4a6398da7044fb24
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Sun Apr 16 11:34:34 2017 +0300

    fix(swipe-back): change side according to dir

commit f99cb9844f325f43d9fb7ca22394e7ccff89f3b3
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Sun Apr 16 11:26:49 2017 +0300

    feat(platform): add dir change event emitter

commit 90de5d1105f6554ad759f280d2ed96ff6b3ef28a
Author: Amit Moryossef <amitmoryossef@gmail.com>
Date:   Sat Apr 15 20:13:09 2017 +0300

    fix(menu): add gesture side real-time update
    migrated to Renderer2
2017-04-23 18:06:04 +02:00
59eb9a328d refactor(): restructure components to loosen coupling, move overlay-portal, click-block, menu-controller and other app-level functionality to app directory. The motivation for this change is logical grouping, decoupling components from each other, and improving the ability to drop more unused components from bundle 2017-04-20 23:21:25 -05:00
8605672888 fix(navcontroller): filter null viewcontrollers 2017-04-20 14:36:58 +02:00
95c06a53cc fix(navcontroller): exceptions inside lifecycle events are printed properly
fixes #10974
2017-04-19 23:12:50 +02:00
356ccd9e1c docs(nav): .catch() is not longer needed 2017-04-18 23:42:49 +02:00
f88823a30f fix(navcontroller): lazy loading is queued 2017-04-18 20:55:41 +02:00
bc9accf215 docs(navigation): fix typo (#11192) 2017-04-13 14:48:33 -05:00
35f394750f fix(navigation): legacy deep link config can have a defaultHistory entry that is a component in addi
legacy deep link config can have a defaultHistory entry that is a component in addition to a string
2017-04-13 10:39:06 -05:00
55dfd254e5 Merge branch 'decorator-inheritance' 2017-04-05 20:35:16 +02:00
8586cc11ed fix(navigation): update the URL if there are no children navs 2017-04-04 17:01:26 -04:00
404d977c81 fix(nav-controller): remove duplicated swipeBackEnabled input 2017-03-29 18:51:54 +02:00
41e34fc4ce chore(docs): moving docs from /docs/v2 to /docs 2017-03-29 11:00:52 -05:00
36b7d338f6 docs(navigation): move deep linker docs to ionic page 2017-03-27 13:33:47 -04:00
99142f8ebe fix(datetime): fixes date time in 3.0 + perf improvements 2017-03-21 19:47:52 +01:00
b10ec68087 refactor(deep-linking): rename to
rename  to
2017-03-20 10:42:00 -05:00
52081a471a refactor(deep-linking): change to
change  to
2017-03-20 10:14:36 -05:00
d93ca82666 refactor(deep-linking): fix url when navigating back to url w/ params 2017-03-14 16:08:15 -05:00
396f891f33 chore(docs): updating dgeni typescript package 2017-03-14 14:50:31 -05:00
4354fc212e docs(deep-linker): copy editing 2017-03-13 17:59:14 -04:00
ddb8ef23e0 docs(deep-linker): update deep linker docs with new decorator 2017-03-13 17:37:18 -04:00
eaadea7569 chore(navigation): update NavController and NavPush types 2017-03-09 15:36:59 -05:00
a7ea189fa3 chore(navigation): remove private, old property on interface
remove private, old property on interface
2017-03-09 10:46:30 -06:00
5a4f8b9b5d feat(module-loader): preload modules based on priority 2017-03-07 16:15:15 -05:00
37c198414d Merge branch 'master' into 3.0 2017-03-07 21:28:18 +01:00
61a5317b25 fix(ViewController): nav must be set as soon as possible
fixes regression in 5a4c6093a72059577544dafe372e06018ee1ed19
fixes #10654
2017-03-05 16:00:47 +01:00
8674aaf419 style(linting): fix validate issues
fix validate issues
2017-03-03 16:46:12 -06:00
90f9650d7a style(lint): fix linter errors 2017-03-03 16:02:24 -06:00
b47848ceb2 feat(navigation): add optional priority to deep link config
add optional priority to deep link config
2017-03-03 15:47:42 -06:00
3e70856c0b feat(navigation): @DeepLink decorator
@DeepLink decorator
2017-03-03 15:36:05 -06:00
3ebc3656c1 feature(modal): support lazy loading of modal pages 2017-03-03 15:13:15 -06:00
5a4c6093a7 refactor(NavController): adds better error handling
fixes #10090
2017-03-03 21:11:58 +01:00
9e4c3a6e3e feat(split-panel): split panel support for ion-nav and ion-menu (#10343)
* feat(split-panel): split panel support for ion-nav and ion-menu

Revert some changes

adds support split-panel support for tabs

Removes .orig

removes e2e.ts

Removes unneeded changes in menu.ts

improves stuff

* fix(split-panel): resize is called when menu wraps a ion-nav

* test(split-panel): improves split-panel/basic test

* feat(split-panel): ionChange is an ng2 @Output()

* fix(split-panel): fix tabs as side content

* fix(menu): forzedClose works as expected

* feat(split-panel): split-panel works with several menus

* chore(split-panel): renames to split-pane

* refactor(split-pane): splitPane can be injected

* fix(split-pane): it is a directive

* fix(slides): integration with split-panel

* Make gulp validate happy
2017-03-03 20:13:07 +01:00
96657535f1 refactor(navigation): async component loading (aka lazy loading)
async component loading (aka lazy loading)
2017-03-02 15:05:35 -06:00
be79382386 test(e2e): refactor e2e tests to modular structure and utilize lazy loading where possible
refactor e2e tests to modular structure and utilize lazy loading where possible
2017-03-02 14:37:01 -06:00
fdd50ba47c refactor(navcontroller): clean up and algorithm documented 2017-02-28 17:53:49 +01:00
8d9f374065 fix(all): memory leaks
fixes #10459
fixes #10416
fixes #10286
2017-02-28 17:50:42 +01:00
43b90973ef docs(navController): fix setPages signature 2017-02-21 17:05:13 -05:00
aa528fdb42 docs(navController): better type setPages
Closes https://github.com/driftyco/ionic-site/issues/970
2017-02-17 16:38:25 -05:00
fae38f910c docs(navController): argument is not optional 2017-02-17 11:27:40 -05:00