Commit Graph

13 Commits

Author SHA1 Message Date
arturokunder
c6fb60cd68 Update actionSheet.js
fixed a typo at the params description
2014-06-17 09:54:00 -04:00
ohh2ahh
a0b61e0c2c docs(actionSheet): correct show() method example 2014-06-14 16:20:55 -05:00
Andrew Joslin
e2ec0bfffe amend($ionicActionSheet): remove unused line of code 2014-06-11 11:33:56 -06:00
Andrew Joslin
087e55f320 feat($ionicActionSheet): add cancelOnStateChange option, default true
Closes #1318

BREAKING CHANGE: $ionicActionSheet's default behavior is now to cancel
when the app's state changes.  To disable this behavior, pass
`cancelOnStateChange: false` into $ionicActionSheet.show().
2014-06-11 11:28:53 -06:00
Andrew Joslin
b7646a5630 fix($ionicActionSheet): stop memory leak due to hidden element staying in dom
BREAKING CHANGE: $ionicActionSheet now returns a method to hide the
action sheet.

Previously, it returned an object that had a `show` and `hide` method.
This was undocumented, but if you used it, here is how to migrate your
code:

Change your code from this:

```js
var sheet = $ionicActionSheet.show({...});
sheet.hide();
```

To this:

```js
var hideSheet = $ionicActionSheet.show({...});
hideSheet();
```
2014-06-06 13:45:38 -04:00
hallucynogenyc
323e2ce22d fix($ionicActionSheet): fix problems with cancel() not being called
Closes #1013, #1576.
2014-06-06 13:22:13 -04:00
Andrew Joslin
75e30003a8 chore(): move demos out of source files 2014-05-27 11:21:08 -06:00
Andrew Joslin
c340951b48 demo($ionicActionSheet): add demo 2014-05-22 11:41:28 -06:00
Pavel Strashkin
e0c7979aa5 feat ($ionicActionSheet): pass button object to buttonClicked
Closes #1369.

Right now `buttonClicked` accepts only the index of the pressed button that means you have to work with indices to decide which one it is. In case you move buttons around to get better UX, you'd have to be very careful with those indices. It's easier to add `id` property to buttons and simply check for it. Index-agnostic solution is more maintainable and leads to less changes to the code when the buttons order is being changed.
2014-05-13 10:57:13 -06:00
Andrew Joslin
b785955348 chore(): factor out some angular functions to variables 2014-05-07 14:54:51 -06:00
Andy Joslin
3e5b39f201 feat($ionicActionSheet): allow html binding
Closes #1219
2014-04-29 10:35:35 -06:00
Andy Joslin
b87bcb30c3 feat($ionicPopup): on android, make back button close popup
Fixes #1222
2014-04-29 09:07:13 -06:00
Andy Joslin
14a2790749 refactor(): reorganize source files 2014-04-14 10:47:27 -06:00