Commit Graph

21 Commits

Author SHA1 Message Date
Liam DeBeasi
cd5c099dd3 feat(picker): add inline picker (#28689)
Issue number: resolves #24905, resolves #26840, resolves #15710

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

The current picker is only displayed as an overlay which makes it
impossible to use inline with the rest of the application. Additionally,
there are several bugs and missing features. For example, it is
impossible to know when the value of the picker column has changed using
public APIs. This is valuable for updating other columns in response to
that data.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Introduces `ion-picker` as an inline wheel picker component. The
overlay picker is still available using `ion-picker-legacy`.
- The implementation of this component resolves linked bugs. It also
resolves linked features by exposing an `ionChange` event for developers
to listen for.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev-build: `7.5.8-dev.11702398696.1ab62ea9`

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Shawn Taylor <shawn@ionic.io>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
2023-12-13 13:03:58 -05:00
Liam DeBeasi
b02190d71f chore(react): migrate to eslint, add prettier (#26633) 2023-01-18 16:49:25 -05:00
Amanda Johnston
c2e1ad385d chore(many): replace any types and add tech debt tickets (#26293)
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-01-06 09:34:55 -06:00
Bittor Poza
57105d54ea fix(react): loading layout is correct with no message (#26222)
Resolves #26219
2022-11-03 11:48:55 -04:00
Amanda Johnston
7111370dd7 fix(react): add param types to useIonPopover dismiss function (#25311) 2022-05-18 13:15:35 -05:00
Sean Perkins
68b2f8bfe1 fix(react): useIonModal/useIonPopover dismiss accepts data and role (#25209)
Resolves #25208
2022-04-29 11:57:41 -04:00
Liam DeBeasi
897ae4a454 fix(angular, react, vue): overlays no longer throw errors when used inside tests (#24681)
resolves #24549, resolves #24590
2022-02-02 15:25:51 -05:00
Liam DeBeasi
32fad3d02c fix(react): building app for production now works correctly with vite (#24515)
resolves #24229
2022-01-05 14:25:49 -05:00
Liam DeBeasi
e4056f7945 chore(): sync with main 2021-12-07 14:57:29 -05:00
Sean Perkins
4b26feaa47 fix(react): present and dismiss hooks return promises (#24299) 2021-12-01 15:16:55 -05:00
Liam DeBeasi
7ab50dda83 chore(): sync with main 2021-10-22 15:24:34 -04:00
Ely Lucas
f3e492c897 fix(react): overlays shown with useIonModal and useIonPopover no longer render outside of main react tree
closes #23516 and #23516
2021-10-15 15:29:25 -06:00
Ely Lucas
655631ddf0 fix(react): fix to regression in overlay hooks dimiss method (#24038)
resolves #24030
2021-10-07 15:18:10 -04:00
Liam DeBeasi
5f31196fc1 chore(): fix tests again 2021-10-06 15:35:12 +00:00
Liam DeBeasi
b12422a4d9 chore(): fix tests 2021-10-06 15:14:47 +00:00
Liam DeBeasi
6951b7703c chore(): fix tests for now 2021-10-06 15:03:27 +00:00
Liam DeBeasi
0ade0a5f09 chore(all): sync with main for beta 7 2021-10-06 10:52:14 -04:00
Ely Lucas
2c97712601 fix(react): overlay hooks memorised properly to prevent re-renders (#24010)
resolves #23741

Co-authored-by: Fabrice <fabrice@weinberg.me>
2021-10-05 08:44:40 -04:00
Liam DeBeasi
c50d895370 feat(react): add custom elements bundle (#23896) 2021-09-13 14:53:28 -04:00
William Martin
1680b0ce9f refactor(react): transition to Stencil React bindings (#23826) 2021-08-31 17:29:59 -04:00
Ely Lucas
b83e00934e feat(react): add react hooks to control overlay components (#22484) 2021-03-01 11:34:13 -05:00