Commit Graph

7 Commits

Author SHA1 Message Date
Max Lynch
0fd3e5d4c5 fix(react): ensure element exists in controller before dismissing it 2019-05-26 14:38:41 -05:00
Ely Lucas
3d04417a05 fix(react): defaultHref fixes (#18278)
* fix(react): making children prop optional on overlay components

* fix(react): passing in defaultHref so it can be used if there is no prev view
2019-05-14 15:08:47 -05:00
Ely Lucas
7bb6a8e8b1 fix(react): Support for adding css classes via className in Ionic React components (#18231)
* fix(react): adding classname to react props

* fix(react): updating rtl to latest to fix ts error

* fix(react): changes to support className
2019-05-08 15:53:33 -05:00
Josh Thomas
d9aa318aa4 tests(react): create tests for the react bindings to core (#17551)
* Add tests.

* updates after API meeting.

* test(): add tests for create controller components.

* correct testing for controller component

* Ensure tests properly cleanup after each run.

* create common test utils for overlay and controllers.

* initial tests for ion router outlet

* simple update.

* add mocks for jest tests.
2019-02-20 15:35:20 -06:00
Josh Thomas
a4150010a8 fix(react): duplicate events being fired in ionic/react (#17321) 2019-01-30 12:55:38 -06:00
Josh Thomas
f46cd507c2 feat(react): complete controller integrations and navigation (#16849)
* fix(react): correct controller types and reexport AlertOptions.

* feat(): add Ion Stack and Tabs navigation items based on React Router.

* rework tabs and add router outlet

* fixes to the outlet rendering.

* add direction as state

* fixed transitions

* Update to core rc2.
2019-01-22 14:09:58 -06:00
Josh Thomas
e30c5f1756 feat(react): Initial implementations of controller required elements. (#16817) 2018-12-19 10:27:11 -06:00