Commit Graph

15 Commits

Author SHA1 Message Date
Dan Bucholtz
248d0c1a9c chore(e2e): add css back to e2e tests where it was missing
add css back to e2e tests where it was missing
2016-09-27 16:48:27 -05:00
Adam Bradley
d7be8a80c0 test(ngmodule): update to ngmodule 2016-09-13 15:44:02 -05:00
Brandy Carney
55a0257dbc refactor(colors): color should be added as an input instead of directly adding the color to the component
BREAKING CHANGES:

Colors should be passed in the `color` input on components, not added
individually as an attribute on the component.

For example:

```
<ion-tabs primary>
```

Becomes

```
<ion-tabs color=”primary”>
```

Or to bind an expression to color:

```
<ion-navbar [color]="barColor">
   ...
</ion-navbar>
```

```ts
@Component({
  templateUrl: 'build/pages/about/about.html'
})
export class AboutPage {
  barColor: string;

  constructor(private nav: NavController, platform: Platform) {
    this.barColor = platform.is('android') ? 'primary' : 'light';
  }
}
```

Reason for this change:
It was difficult to dynamically add colors to components, especially if
the name of the color attribute was unknown in the template.
This change keeps the css flat since we aren’t chaining color
attributes on components and instead we assign a class to the component
which includes the color’s name.
This allows you to easily toggle a component between multiple colors.
Speeds up performance because we are no longer reading through all of
the attributes to grab the color ones.

references #7467
closes #7087 closes #7401 closes #7523
2016-08-23 17:16:55 -04:00
Brandy Carney
7ddebdd6a1 test(loading): add test to show setting dynamic content
references #6103
2016-08-17 14:07:43 -04:00
Brandy Carney
938864e8d0 refactor(button): add ion-button attribute and icon attributes to style buttons
BREAKING CHANGES:

- `<button>` becomes `<button ion-button>`
- `<a button>` becomes `<a ion-button>`
- `<button ion-item>` does not get the `ion-button` attribute
- Buttons inside of `<ion-item-options>` do get the `ion-button`
attribute
- Removed the `category` attribute, this should be passed in
`ion-button` instead.
- Button attributes added for icons in buttons: `icon-only`,
`icon-left`, and `icon-right`

closes #7466
2016-08-16 17:11:02 -04:00
Brandy Carney
466dea310b feat(loading): add ability to pass multiple classes to cssClass
references #7618
2016-08-09 16:15:58 -04:00
Adam Bradley
3c493652b2 test(): update to public navCtrl convention 2016-08-04 13:50:15 -05:00
Manu Mtz.-Almeida
ac8e4dce06 style(all): tslinter warnings 2016-07-19 13:31:46 -07:00
Manu Mtz.-Almeida
ec99bfd019 feat(viewcontroller): add onWillDismiss callback
Fixed #6702
2016-06-30 08:06:19 -05:00
Adam Bradley
4980659bd6 test(overlay): use injectable overlay controllers 2016-06-28 15:20:42 -05:00
Adam Bradley
1a8f6d745d test(header): update header markup 2016-06-17 11:43:30 -05:00
Adam Bradley
2eb88fa687 test(lifecycle): update lifecycle events 2016-06-01 12:19:08 -05:00
Adam Bradley
6e9087534d test(bootstrap): update to use ionicBootstrap 2016-05-31 15:49:12 -05:00
Josh Thomas
2b836a930f chore(tests): correct components to use src path instead of ionic to ensure karma tests pass. 2016-05-19 16:58:08 -05:00
Josh Thomas
c8f760f080 chore(build): rename ionic directory to src and update all references in the build process. 2016-05-19 13:22:40 -05:00