Commit Graph

85 Commits

Author SHA1 Message Date
Brandy Carney
b2021fd9c4 fix(theming): update global css variable naming and default values (#16003)
Updates all of the global variables to make sure their naming is consistent, their default values are correct, they are used properly by the related components, and remove any that are not used.

- removes some of the non mode-specific global Sass variables
- updates the md and ios values so that the default is the css variable
with different fallbacks
- removes non-color related css variables from the global file
- fixes item so it uses the background color that is set by the global
file

# Breaking Changes

## Removed Global CSS Variables

The following global CSS variables have been removed for the reasons listed.

| Variable Name                     | Reason                                          |
| ----------------------------------| ------------------------------------------------|
| `--ion-toolbar-color-inactive`    | Unused                                          |
| `--ion-ripple-background-color`   | Unused / Ripple color is based on component     |
| `--ion-header-size`               | Removed in favor of using CSS for h1-h6         |
| `--ion-header-step`               | Removed in favor of using CSS for h1-h6         |

## Renamed Global CSS Variables

The following global CSS variables have been renamed for the reasons listed.

| Old Variable Name                        | New Variable Name                  | Reason                                                                        |
| -----------------------------------------| -----------------------------------| ------------------------------------------------------------------------------|
| `--ion-toolbar-text-color`               | `--ion-toolbar-color`              | Variable is not limited to text color                                         |
| `--ion-toolbar-color-active`             | `--ion-toolbar-color-activated`    | Consistency with our component variables                                      |
| `--ion-tabbar-text-color`                | `--ion-tab-bar-color`              | Variable is not limited to text color                                         |
| `--ion-tabbar-text-color-active`         | `--ion-tab-bar-color-activated`    | Consistency with our component variables                                      |
| `--ion-tabbar-background-color`          | `--ion-tab-bar-background`         | Applies to the background property                                            |
| `--ion-tabbar-background-color-focused`  | `--ion-tab-bar-background-focused` | Applies to the background property                                            |
| `--ion-item-background-color`            | `--ion-item-background`            | Applies to the background property                                            |
| `--ion-item-background-color-active`     | `--ion-item-background-activated`  | Applies to the background property / Consistency with our component variables |
| `--ion-item-text-color`                  | `--ion-item-color`                 | Variable is not limited to text color                                         |
| `--ion-placeholder-text-color`           | `--ion-placeholder-color`          | Consistency with other variables                                              |

Fixes #15989 
Fixes #15559
2018-10-23 12:37:04 -04:00
Adam Bradley
a9fd3399de test(e2e): force roboto font on all systems (#15993) 2018-10-19 15:22:15 -05:00
Manu Mtz.-Almeida
3a4b21457f chore(): update stencil 2018-10-12 11:44:43 -05:00
Manu Mtz.-Almeida
a72fced6fe fix(all): docs for all missing props 2018-10-11 16:24:08 -05:00
Cam Wiegert
ae3271f2d7 test(all): inject test styles on flag 2018-10-11 15:13:23 -05:00
Daniel Imhoff
2172aa9dae test(screenshot): use Arial for testing 2018-10-09 13:40:31 -05:00
Manu Mtz.-Almeida
4036db5480 chore(): update readme 2018-10-08 15:46:34 -05:00
Manu Mtz.-Almeida
e51f1f36f1 fix(item): detail context based in text color 2018-10-08 13:17:33 -05:00
Manu Mtz.-Almeida
9d109d68c8 fix(all): disable animations in e2e tests 2018-10-08 10:18:31 -05:00
Brandy Carney
f885f7d10a fix(item): add input highlight using an absolute div (#15856)
Adds the following CSS properties to item:

```
--highlight-color-focused
--highlight-color-valid
--highlight-color-invalid
--highlight-height
```

This also fixes an issue where we were showing the highlight on items
with no lines, and shows inset vs full properly. Adds documentation and tests for input focus.

fixes #14036 fixes #9639 fixes #14952 closes #15690
2018-10-05 16:15:39 -04:00
Cam Wiegert
7370218b2d test(item): migrate e2e tests
references #15803
2018-10-02 11:49:26 -05:00
Mike Hartington
a3c85ae301 fix(): add safe area cutouts (#15750)
* fix(): add safe area cutouts

* fix(): adjust safe-area padding

* fix(): safe area improvments

* fix(): safe-area-improvments for padding

* fix(): safe-area improvements for items

* fix(): safe-area fix for core css

* fix(): safe-area fix for list header

* fix(): safe-area fix for popover

* fix(): safe-area validates

* chore(): ci updates

* fix(): safe-area revert padding changes for now

* padding is being applied twice

* safe-area-left is applied to item
2018-09-26 13:01:54 -05:00
Cam Wiegert
2dd4bdb0a4 docs(item): document custom properties
references #14850
closes #15648
2018-09-20 11:42:52 -05:00
Cam Wiegert
a9af2f5682 chore(item): don't set ion-color properties
references #14808
2018-09-20 11:42:52 -05:00
Cam Wiegert
c7d4b022e3 chore(label): remove item styles and escapes
references #14808
2018-09-20 11:42:52 -05:00
Brandy Carney
1cd792efff fix(item): add the multiple inputs class to fix select/datetime in item
references #15547 closes #15401
2018-09-18 15:45:59 -04:00
Manu Mtz.-Almeida
c49d896e08 refactor(all): using ComponentInterface 2018-09-14 18:47:00 +02:00
Brandy Carney
fcb45d12e2 style(components): don't self close tags 2018-09-12 11:38:20 -04:00
Brandy Carney
6ed4690834 style(tap-click): rename activable to activatable 2018-09-12 11:38:20 -04:00
Manu Mtz.-Almeida
e7416435d8 refactor(all): additional tslint rules 2018-09-01 18:06:59 +02:00
Manu Mtz.-Almeida
ba2230510e refactor(all): strict boolean conditions 2018-09-01 17:23:03 +02:00
Manu MA
096d9a76f3 fix(css): add core.css (#15220)
fixes #15170
2018-08-29 18:05:20 +02:00
Manu Mtz.-Almeida
4a45effe8c fix(ripple-effect): using method invocation instead of events
fixes #15318
2018-08-24 22:58:12 +02:00
Manu Mtz.-Almeida
151c58e12f fix(select): support any kind of value
fixes #15200
2018-08-24 04:15:41 +02:00
Manu Mtz.-Almeida
d12ef78de6 refactor(all): cleanup mode font 2018-08-24 03:33:44 +02:00
Manu Mtz.-Almeida
3d6caae13f chore(): update to latest stencil 2018-08-22 23:38:23 +02:00
Brandy Carney
9424ad765d style(sass): fix lint error 2018-08-13 13:17:51 -04:00
Brandy Carney
42ca99d111 fix(select): apply proper styles for stacked/floating selects
adds padding attributes to select to style the correct padding with a
stacked/floating label

fixes #15140 references #14850
2018-08-13 12:31:04 -04:00
Manu Mtz.-Almeida
0dc70f7f6d fix(tap-click): works inside shadow-dom
adds private ion-activable attribute

fixes #15128
2018-08-12 22:48:58 +02:00
Manu Mtz.-Almeida
d856ecfbbf chore(): update to latest stencil 2018-08-12 12:04:27 +02:00
Adam LaCombe
e3010e1f0d fix(css): --ion-item-background > --ion-item-background-color (#15101) 2018-08-12 00:40:36 +02:00
Manu Mtz.-Almeida
aa23d08a71 fix(all): safe-area using css variables 2018-08-10 01:41:05 +02:00
Brandy Carney
4ec038d507 style(item): remove console log and outdated docs 2018-08-09 18:10:33 -04:00
Brandy Carney
c287cb587e docs(item): update to include lines prop 2018-08-09 18:04:52 -04:00
Manu Mtz.-Almeida
5668dc4fc5 chore(): update to latest stencil 2018-08-08 17:21:41 +02:00
Manu Mtz.-Almeida
a77ee2a6f8 fix(sliding): fix core gesture logic + priority configuration
fixes #14763
2018-08-07 17:14:04 +02:00
Manu Mtz.-Almeida
c1b61d0fee chore(): update to ionic-rules/strict 2018-07-29 23:10:38 +02:00
Manu Mtz.-Almeida
7292fc7d38 perf(icon): disable icon lazy loading when it's not needed 2018-07-29 16:04:51 +02:00
Manu Mtz.-Almeida
25423a06f2 fix(button): improve text style inherency
related #14927
2018-07-29 13:19:28 +02:00
Manu Mtz.-Almeida
92e21a8cf3 fix(all): updated tslint rules to latest 2018-07-29 13:03:47 +02:00
Manu Mtz.-Almeida
f19553fe36 fix(item): only use pointer cursor for <button> and <a> 2018-07-28 16:32:29 +02:00
Manu Mtz.-Almeida
b4976dd914 chore(): update docs 2018-07-24 23:05:35 +02:00
Brandy Carney
2c37a5a7b2 docs(previews): update preview tests to have translucent white toolbars
to make ben happy
2018-07-24 16:27:17 -04:00
Brandy Carney
f0c15384a2 docs(components): update color documentation 2018-07-24 11:59:32 -04:00
Brandy Carney
7a8d5f68d2 chore(stylelint): remove sass-lint/scss-lint in favor of stylelint
- remove scss-lint and sass-lint
- add stylelint and stylelint-order packages and configuration
- update all *.scss files to new syntax

fixes #14805
2018-07-19 15:10:30 -05:00
Brandy Carney
094fde755c style(css): fix most scss lint errors 2018-07-18 12:53:33 -04:00
Brandy Carney
43f1feccad fix(item): add cursor pointer back to native item
fixes #14743
2018-07-12 10:51:27 -04:00
Adam Bradley
13e0c91ebe docs(readme): update component readmes 2018-07-11 12:26:22 -05:00
Brandy Carney
5f8b02eb3f fix(item): pass the correct type property to the button tag
fixes #14740
2018-07-11 12:10:38 -04:00
Brandy Carney
02a0b6e5fe style(components): don't self close slot tags 2018-07-11 11:48:41 -04:00