344d819014
chore: sync with workspace-test
2024-03-28 15:43:48 -04:00
c59394cbf7
chore: sync with main
2024-03-28 15:36:38 -04:00
a2923aaeb3
chore(): update package lock files
2024-03-27 13:34:23 +00:00
eeab96de55
v7.8.2
2024-03-27 13:33:47 +00:00
7ca6b80b04
chore(): update package lock files
2024-03-20 13:19:42 +00:00
4cd8fb15af
v7.8.1
2024-03-20 13:18:53 +00:00
58d217d0cf
fix(react): avoid definitely typed errors with @types/react@18 ( #29182 )
...
Issue number: resolves #29178
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
[DefinitelyTyped removed the `onPointerEnterCaptured` and
`onPointerLeaveCaptured` types for
`@types/react`](https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/69006 ).
This caused issues when multiple versions of `@types/react` are
installed where an older version inlined these types, but they did not
exist in newer versions.
For Ionic React, we build with React 16 which did inline the types. In
an Ionic React starter app we build with React 18 which does not want
these types. As a result, there is a type mismatch.
Note that this type change is being [reverted in React
16-17](https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/69006#discussioncomment-8826095 )
so presumably this issue will go away in its own for those versions.
However, developers are building with React 18 too, so this issue will
persist for those developers.
However, React 17 should still have this problem (at least until the
change is reverted), yet the build here passes. The main difference is
that the `onPointer{Enter,Leave}Captured` event is no longer inlined.
After talking with the Stencil team this is the current understanding of
why the issue no longer reproduces.
**Building with React 17**
```ts
import type { JSX as LocalJSX } from '@ionic/core/components';
import React from 'react';
import type { IonicReactProps } from './IonicReactProps';
export declare const IonRouterOutlet: React.ForwardRefExoticComponent<Pick<LocalJSX.IonRouterOutlet & {
basePath?: string | undefined;
ref?: React.Ref<any> | undefined;
ionPage?: boolean | undefined;
} & IonicReactProps & Omit<React.HTMLAttributes<HTMLIonRouterOutletElement>, "style" | "placeholder">, "children" | "slot" | "title" | "defaultChecked" | "defaultValue" | "suppressContentEditableWarning" | "suppressHydrationWarning" | "accessKey" | "contentEditable" | "contextMenu" | "dir" | "draggable" | "hidden" | "id" | "lang" | "spellCheck" | "tabIndex" | "translate" | "radioGroup" | "role" | "about" | "datatype" | "inlist" | "prefix" | "property" | "resource" | "typeof" | "vocab" | "autoCapitalize" | "autoCorrect" | "autoSave" | "color" | "itemProp" | "itemScope" | "itemType" | "itemID" | "itemRef" | "results" | "security" | "unselectable" | "inputMode" | "is" | "aria-activedescendant" | "aria-atomic" | "aria-autocomplete" | "aria-busy" | "aria-checked" | "aria-colcount" | "aria-colindex" | "aria-colspan" | "aria-controls" | "aria-current" | "aria-describedby" | "aria-details" | "aria-disabled" | "aria-dropeffect" | "aria-errormessage" | "aria-expanded" | "aria-flowto" | "aria-grabbed" | "aria-haspopup" | "aria-hidden" | "aria-invalid" | "aria-keyshortcuts" | "aria-label" | "aria-labelledby" | "aria-level" | "aria-live" | "aria-modal" | "aria-multiline" | "aria-multiselectable" | "aria-orientation" | "aria-owns" | "aria-placeholder" | "aria-posinset" | "aria-pressed" | "aria-readonly" | "aria-relevant" | "aria-required" | "aria-roledescription" | "aria-rowcount" | "aria-rowindex" | "aria-rowspan" | "aria-selected" | "aria-setsize" | "aria-sort" | "aria-valuemax" | "aria-valuemin" | "aria-valuenow" | "aria-valuetext" | "dangerouslySetInnerHTML" | "onCopy" | "onCopyCapture" | "onCut" | "onCutCapture" | "onPaste" | "onPasteCapture" | "onCompositionEnd" | "onCompositionEndCapture" | "onCompositionStart" | "onCompositionStartCapture" | "onCompositionUpdate" | "onCompositionUpdateCapture" | "onFocus" | "onFocusCapture" | "onBlur" | "onBlurCapture" | "onChange" | "onChangeCapture" | "onBeforeInput" | "onBeforeInputCapture" | "onInput" | "onInputCapture" | "onReset" | "onResetCapture" | "onSubmit" | "onSubmitCapture" | "onInvalid" | "onInvalidCapture" | "onLoad" | "onLoadCapture" | "onError" | "onErrorCapture" | "onKeyDown" | "onKeyDownCapture" | "onKeyPress" | "onKeyPressCapture" | "onKeyUp" | "onKeyUpCapture" | "onAbort" | "onAbortCapture" | "onCanPlay" | "onCanPlayCapture" | "onCanPlayThrough" | "onCanPlayThroughCapture" | "onDurationChange" | "onDurationChangeCapture" | "onEmptied" | "onEmptiedCapture" | "onEncrypted" | "onEncryptedCapture" | "onEnded" | "onEndedCapture" | "onLoadedData" | "onLoadedDataCapture" | "onLoadedMetadata" | "onLoadedMetadataCapture" | "onLoadStart" | "onLoadStartCapture" | "onPause" | "onPauseCapture" | "onPlay" | "onPlayCapture" | "onPlaying" | "onPlayingCapture" | "onProgress" | "onProgressCapture" | "onRateChange" | "onRateChangeCapture" | "onSeeked" | "onSeekedCapture" | "onSeeking" | "onSeekingCapture" | "onStalled" | "onStalledCapture" | "onSuspend" | "onSuspendCapture" | "onTimeUpdate" | "onTimeUpdateCapture" | "onVolumeChange" | "onVolumeChangeCapture" | "onWaiting" | "onWaitingCapture" | "onAuxClick" | "onAuxClickCapture" | "onClick" | "onClickCapture" | "onContextMenu" | "onContextMenuCapture" | "onDoubleClick" | "onDoubleClickCapture" | "onDrag" | "onDragCapture" | "onDragEnd" | "onDragEndCapture" | "onDragEnter" | "onDragEnterCapture" | "onDragExit" | "onDragExitCapture" | "onDragLeave" | "onDragLeaveCapture" | "onDragOver" | "onDragOverCapture" | "onDragStart" | "onDragStartCapture" | "onDrop" | "onDropCapture" | "onMouseDown" | "onMouseDownCapture" | "onMouseEnter" | "onMouseLeave" | "onMouseMove" | "onMouseMoveCapture" | "onMouseOut" | "onMouseOutCapture" | "onMouseOver" | "onMouseOverCapture" | "onMouseUp" | "onMouseUpCapture" | "onSelect" | "onSelectCapture" | "onTouchCancel" | "onTouchCancelCapture" | "onTouchEnd" | "onTouchEndCapture" | "onTouchMove" | "onTouchMoveCapture" | "onTouchStart" | "onTouchStartCapture" | "onPointerDown" | "onPointerDownCapture" | "onPointerMove" | "onPointerMoveCapture" | "onPointerUp" | "onPointerUpCapture" | "onPointerCancel" | "onPointerCancelCapture" | "onPointerEnter" | "onPointerEnterCapture" | "onPointerLeave" | "onPointerLeaveCapture" | "onPointerOver" | "onPointerOverCapture" | "onPointerOut" | "onPointerOutCapture" | "onGotPointerCapture" | "onGotPointerCaptureCapture" | "onLostPointerCapture" | "onLostPointerCaptureCapture" | "onScroll" | "onScrollCapture" | "onWheel" | "onWheelCapture" | "onAnimationStart" | "onAnimationStartCapture" | "onAnimationEnd" | "onAnimationEndCapture" | "onAnimationIteration" | "onAnimationIterationCapture" | "onTransitionEnd" | "onTransitionEndCapture" | keyof IonicReactProps | keyof LocalJSX.IonRouterOutlet | "basePath" | "ionPage"> & React.RefAttributes<HTMLIonRouterOutletElement>>;
```
**Building with React 18**
```ts
export declare const IonRouterOutlet: React.ForwardRefExoticComponent<Omit<LocalJSX.IonRouterOutlet & {
basePath?: string | undefined;
ref?: React.Ref<any> | undefined;
ionPage?: boolean | undefined;
} & IonicReactProps & Omit<React.HTMLAttributes<HTMLIonRouterOutletElement>, "style" | "placeholder">, "ref"> & React.RefAttributes<HTMLIonRouterOutletElement>>;
```
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
- Updated types in our React test apps and verified that the [issue
reproduces there without this
fix](https://github.com/ionic-team/ionic-framework/actions/runs/8345186602 ).
- Updated Ionic React and Ionic React Router to build with React 17.
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
Ionic v7 expects React 17 or newer, so building with React 17 instead of
React 16 is not a breaking change.
<!--
If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
Dev build: `7.8.1-dev.11710859149.114e57ae` Verified with sample repro
2024-03-19 17:36:29 +00:00
afa69b056f
chore: sync
2024-03-15 20:31:46 -04:00
4f649d1b4d
chore: install deps
2024-03-15 20:29:37 -04:00
7c70b8a7c2
chore: sync with main
2024-03-15 20:28:22 -04:00
7be6d9f72d
chore(): update package lock files
2024-03-13 13:48:18 +00:00
400013d6cb
v7.8.0
2024-03-13 13:47:29 +00:00
ddcda78ac9
chore(): update package lock files
2024-03-13 13:15:50 +00:00
82e90f28b4
v7.7.5
2024-03-13 13:15:09 +00:00
369c56425d
REVERT ME: add react test app verification
2024-03-08 15:00:14 +00:00
bef3e77f01
chore: move test apps to test-app directory
2024-03-08 01:39:47 +00:00
9d27d7cc21
chore: sync with main
2024-03-07 23:03:32 +00:00
77914f3a28
chore(): update package lock files
2024-03-06 18:05:34 +00:00
911519a5f8
v7.7.4
2024-03-06 18:04:51 +00:00
842a65c9be
chore(): update package lock files
2024-02-21 15:24:31 +00:00
3fd66e76b5
v7.7.3
2024-02-21 15:23:45 +00:00
76c003a3a1
chore(): update package lock files
2024-02-14 14:27:02 +00:00
ae873e7028
v7.7.2
2024-02-14 14:26:08 +00:00
a0afeeb50e
chore(): update package lock files
2024-02-07 14:21:09 +00:00
66fcb70151
v7.7.1
2024-02-07 14:20:32 +00:00
72416324e3
chore(angular, react, vue): update readmes for pnpm usage ( #28958 )
2024-02-02 14:29:31 -08:00
7bb08f9ce4
chore(): update package lock files
2024-01-31 15:18:19 +00:00
e672805406
v7.7.0
2024-01-31 15:17:39 +00:00
fae7b24d2a
chore(): update package lock files
2024-01-31 14:27:13 +00:00
1de5ff9302
v7.6.7
2024-01-31 14:26:24 +00:00
ac251c75fb
Merge remote-tracking branch 'origin/main' into workspace-test
2024-01-29 14:06:08 -05:00
b1c4c72474
refactor(react, react-router): build works on windows ( #28904 )
...
Issue number: Internal
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
React and React Router packages do not build correctly on Windows
because certain dependencies were not marked as external.
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
- 3rd party packages are correctly marked as external
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!--
If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
2024-01-29 18:15:50 +00:00
e35fe27803
chore: update e2e app lockfiles
2024-01-25 13:28:34 -05:00
14c8e826c2
chore: fix package.json merge conflict
2024-01-25 13:16:22 -05:00
594925ea78
chore: sync
2024-01-25 13:15:39 -05:00
67bee73513
chore(): update package lock files
2024-01-24 14:15:49 +00:00
0c4e1fcdb4
v7.6.6
2024-01-24 14:15:07 +00:00
0fb88315df
chore: update package lock
2024-01-17 09:41:15 -05:00
71e485d770
chore: clean up changelog
2024-01-17 09:31:16 -05:00
e2708ff651
v7.6.5
2024-01-17 14:23:09 +00:00
076c9fed29
merge release-7.6.4
2024-01-10 11:28:13 -05:00
b2e40cdcb8
chore: update package lock files
2024-01-03 09:57:18 -05:00
ebb9ae9c11
v7.6.3
2024-01-03 14:52:37 +00:00
55f9cba9fc
fix: react-router test app package resolution
2023-12-28 16:22:25 -05:00
3a7f8b65fe
add type package
2023-12-19 12:29:24 -05:00
29f5ba0535
test(react-router): add history types
2023-12-19 12:08:49 -05:00
9e901309f2
history is a dependency
2023-12-19 11:50:05 -05:00
40122929bc
chore: update
2023-12-19 11:34:34 -05:00
c44bfa07dd
test(react-router): use file protocol for test app
2023-12-19 11:26:17 -05:00
bfd497f825
chore(): update package lock files
2023-12-19 14:45:31 +00:00
