javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 03:00:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(label): inline position by default

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-04-13 17:36:33 +02:00
parent b1ee4b8e3a
commit fde878baf3
4 changed files with 12 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
core/src/components/label/label.tsx
View File

@ -32,7 +32,7 @@ export class Label {
* The position determines where and how the label behaves inside an item.
* Possible values are: 'inline' | 'fixed' | 'stacked' | 'floating'
*/
@Prop({mutable: true}) position: 'inline' | 'fixed' | 'stacked' | 'floating' | undefined;
@Prop() position?: 'fixed' | 'stacked' | 'floating';
/**
* Emitted when the styles change.
@ -44,28 +44,24 @@ export class Label {
return this.el.textContent || '';
}
componentWillLoad() {
if (this.position === undefined) {
this.position = (this.mode === 'ios') ? 'inline' : 'floating';
}
}
componentDidLoad() {
this.positionChanged();
}
@Watch('position')
positionChanged() {
const position = this.position;
return this.ionStyle.emit({
[`label-${this.position}`]: true,
[`label-${position}`]: !!position,
});
}
hostData() {
const position = this.position;
return {
class: {
[`label-${this.position}`]: true,
[`label-${this.mode}-${this.position}`]: true
[`label-${position}`]: !!position,
[`label-${this.mode}-${position}`]: !!position
}
};
}