From fd5d5992bcbb32c904fcce11e5a1dffbfd0e3ca2 Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Tue, 20 Feb 2018 21:57:47 +0100 Subject: [PATCH] perf(): initialize in willLoad --- packages/core/src/components/reorder/reorder.tsx | 2 +- packages/core/src/components/ripple-effect/ripple-effect.tsx | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/core/src/components/reorder/reorder.tsx b/packages/core/src/components/reorder/reorder.tsx index 2216252f8e..bbdd7a7949 100644 --- a/packages/core/src/components/reorder/reorder.tsx +++ b/packages/core/src/components/reorder/reorder.tsx @@ -17,7 +17,7 @@ export class Reorder { @State() custom: boolean; - componentDidLoad() { + componentWillLoad() { this.custom = this.el.childElementCount > 0; } diff --git a/packages/core/src/components/ripple-effect/ripple-effect.tsx b/packages/core/src/components/ripple-effect/ripple-effect.tsx index bc574ff621..bde9092ec5 100644 --- a/packages/core/src/components/ripple-effect/ripple-effect.tsx +++ b/packages/core/src/components/ripple-effect/ripple-effect.tsx @@ -48,10 +48,13 @@ export class RippleEffect { } } - componentDidLoad() { + componentWillLoad() { if (this.useTapClick === undefined) { this.useTapClick = !!document.querySelector('ion-tap-click'); } + } + + componentDidLoad() { this.tapClickChanged(this.useTapClick); }