From fcb45d12e28d752eb337b7573d5d986289cc998c Mon Sep 17 00:00:00 2001
From: Brandy Carney <brandy@ionic.io>
Date: Wed, 12 Sep 2018 11:37:08 -0400
Subject: [PATCH] style(components): don't self close tags

---
 core/src/components/alert/alert.tsx                    | 4 ++--
 core/src/components/button/button.tsx                  | 2 +-
 core/src/components/chip-button/chip-button.tsx        | 2 +-
 core/src/components/datetime/datetime.tsx              | 2 +-
 core/src/components/item/item.tsx                      | 2 +-
 core/src/components/segment-button/segment-button.tsx  | 2 +-
 core/src/components/select/select.tsx                  | 2 +-
 core/src/components/tabbar/tabbar.tsx                  | 2 +-
 core/src/css/{global.bundle.css => global.bundle.scss} | 0
 core/src/utils/tap-click.ts                            | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
 rename core/src/css/{global.bundle.css => global.bundle.scss} (100%)

diff --git a/core/src/components/alert/alert.tsx b/core/src/components/alert/alert.tsx
index 0d738be414..b14ab13fb7 100644
--- a/core/src/components/alert/alert.tsx
+++ b/core/src/components/alert/alert.tsx
@@ -337,7 +337,7 @@ export class Alert implements OverlayInterface {
                 {i.label}
               </div>
             </div>
-            {this.mode === 'md' && <ion-ripple-effect />}
+            {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
           </button>
         ))}
       </div>
@@ -368,7 +368,7 @@ export class Alert implements OverlayInterface {
                 {i.label}
               </div>
             </div>
-            {this.mode === 'md' && <ion-ripple-effect />}
+            {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
           </button>
         ))}
       </div>
diff --git a/core/src/components/button/button.tsx b/core/src/components/button/button.tsx
index 8fcae49e94..b71159e5b5 100644
--- a/core/src/components/button/button.tsx
+++ b/core/src/components/button/button.tsx
@@ -186,7 +186,7 @@ export class Button {
           <slot></slot>
           <slot name="end"></slot>
         </span>
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </TagType>
     );
   }
diff --git a/core/src/components/chip-button/chip-button.tsx b/core/src/components/chip-button/chip-button.tsx
index 5ec3fe59a2..96e50d0a72 100644
--- a/core/src/components/chip-button/chip-button.tsx
+++ b/core/src/components/chip-button/chip-button.tsx
@@ -63,7 +63,7 @@ export class ChipButton {
         <span class="chip-button-inner">
           <slot></slot>
         </span>
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </TagType>
     );
   }
diff --git a/core/src/components/datetime/datetime.tsx b/core/src/components/datetime/datetime.tsx
index 6f5d5723e9..533bf9f808 100644
--- a/core/src/components/datetime/datetime.tsx
+++ b/core/src/components/datetime/datetime.tsx
@@ -538,7 +538,7 @@ export class Datetime {
         onClick={this.open.bind(this)}
         class="datetime-cover"
       >
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </button>
     ];
   }
diff --git a/core/src/components/item/item.tsx b/core/src/components/item/item.tsx
index 047393831e..25262262a9 100644
--- a/core/src/components/item/item.tsx
+++ b/core/src/components/item/item.tsx
@@ -161,7 +161,7 @@ export class Item {
           {showDetail && <ion-icon icon={detailIcon} lazy={false} class="item-detail-icon"></ion-icon>}
         </div>
         {state && <div class="item-state"></div>}
-        {clickable && mode === 'md' && <ion-ripple-effect />}
+        {clickable && mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </TagType>
     );
   }
diff --git a/core/src/components/segment-button/segment-button.tsx b/core/src/components/segment-button/segment-button.tsx
index 58d8c7b193..8e4a01fd7b 100644
--- a/core/src/components/segment-button/segment-button.tsx
+++ b/core/src/components/segment-button/segment-button.tsx
@@ -76,7 +76,7 @@ export class SegmentButton {
         onClick={() => this.checked = true}
       >
         <slot></slot>
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </button>
     ];
   }
diff --git a/core/src/components/select/select.tsx b/core/src/components/select/select.tsx
index af1e89af68..2a3e44dba9 100644
--- a/core/src/components/select/select.tsx
+++ b/core/src/components/select/select.tsx
@@ -506,7 +506,7 @@ export class Select {
         class="select-cover"
       >
         <slot></slot>
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </button>
     ];
   }
diff --git a/core/src/components/tabbar/tabbar.tsx b/core/src/components/tabbar/tabbar.tsx
index d62a363f79..4029297049 100644
--- a/core/src/components/tabbar/tabbar.tsx
+++ b/core/src/components/tabbar/tabbar.tsx
@@ -136,7 +136,7 @@ export class Tabbar {
         {icon && <ion-icon class="tab-btn-icon" icon={icon} lazy={false}></ion-icon>}
         {label && <span class="tab-btn-text">{label}</span>}
         {badge && <ion-badge class="tab-btn-badge" color={badgeColor}>{badge}</ion-badge>}
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </a>
     );
   }
diff --git a/core/src/css/global.bundle.css b/core/src/css/global.bundle.scss
similarity index 100%
rename from core/src/css/global.bundle.css
rename to core/src/css/global.bundle.scss
diff --git a/core/src/utils/tap-click.ts b/core/src/utils/tap-click.ts
index dc2095dab6..04c69fefe2 100644
--- a/core/src/utils/tap-click.ts
+++ b/core/src/utils/tap-click.ts
@@ -77,7 +77,7 @@ export function startTapClick(doc: Document) {
 
     const { x, y } = pointerCoord(ev);
 
-    // unactivate selected
+    // deactivate selected
     if (activatableEle) {
       if (clearDefers.has(activatableEle)) {
         throw new Error('internal error');