From fc4e5ae2873f1ba8c4c0724401e35bd677614aa6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Ferreira?= <60441552+JoaoFerreira-FrontEnd@users.noreply.github.com> Date: Fri, 23 May 2025 17:36:56 +0100 Subject: [PATCH] fix(progress-bar, spinner): update colors for ionic theme (#30418) Issue number: internal --------- ## What is the current behavior? The colors were not working on progress bar when the theme was ionic; The Spinner with color="medium" should use the contrast variation by design; ## What is the new behavior? - Fix Progress-Bar Ionic Colors; - Change Spinner Medium Color Variation; ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information https://ionic-framework-git-rou-11917-ionic1.vercel.app/src/components/progress-bar/test/basic?ionic:theme=ionic https://ionic-framework-git-rou-11917-ionic1.vercel.app/src/components/spinner/test/color?ionic:theme=ionic --- core/src/components/progress-bar/progress-bar.common.scss | 7 ------- core/src/components/progress-bar/progress-bar.ionic.scss | 7 +++++++ core/src/components/progress-bar/progress-bar.native.scss | 7 +++++++ core/src/components/spinner/spinner.ionic.scss | 4 ++++ 4 files changed, 18 insertions(+), 7 deletions(-) diff --git a/core/src/components/progress-bar/progress-bar.common.scss b/core/src/components/progress-bar/progress-bar.common.scss index a4d937f4e8..95541ae144 100644 --- a/core/src/components/progress-bar/progress-bar.common.scss +++ b/core/src/components/progress-bar/progress-bar.common.scss @@ -146,13 +146,6 @@ } } -:host(.ion-color) { - .progress, - .progress-indeterminate { - background: #{current-color(base)}; - } -} - // Progress Bar: Animation Keyframes // ------------------------------------------------------------------------ // Source: https://github.com/material-components/material-components-web/blob/master/packages/mdc-linear-progress/_keyframes.scss diff --git a/core/src/components/progress-bar/progress-bar.ionic.scss b/core/src/components/progress-bar/progress-bar.ionic.scss index 3ae5609d44..3fad235b07 100644 --- a/core/src/components/progress-bar/progress-bar.ionic.scss +++ b/core/src/components/progress-bar/progress-bar.ionic.scss @@ -25,6 +25,13 @@ // Progress Bar: Color // ------------------------------------------------------------------------ +:host(.ion-color) { + .progress, + .progress-indeterminate { + background: #{globals.current-color(base)}; + } +} + :host(.ion-color) .buffer-circles { background-image: radial-gradient( ellipse at center, diff --git a/core/src/components/progress-bar/progress-bar.native.scss b/core/src/components/progress-bar/progress-bar.native.scss index 45885d5cda..5bc8e728b7 100644 --- a/core/src/components/progress-bar/progress-bar.native.scss +++ b/core/src/components/progress-bar/progress-bar.native.scss @@ -14,6 +14,13 @@ // Progress Bar: Color // ------------------------------------------------------------------------ +:host(.ion-color) { + .progress, + .progress-indeterminate { + background: #{current-color(base)}; + } +} + :host(.ion-color) .buffer-circles { background-image: radial-gradient( ellipse at center, diff --git a/core/src/components/spinner/spinner.ionic.scss b/core/src/components/spinner/spinner.ionic.scss index 981fb26bb4..f8fe09383f 100644 --- a/core/src/components/spinner/spinner.ionic.scss +++ b/core/src/components/spinner/spinner.ionic.scss @@ -11,6 +11,10 @@ height: globals.$ion-scale-700; } +:host(.ion-color-medium) { + color: #{globals.ion-color(medium, contrast, $subtle: true)}; +} + // Spinner: lines / lines-small / lines-sharp / lines-sharp-small // --------------------------------------------------