From fbcd3f8c087420bc035f7b2f560659bc53a70a17 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Fri, 19 Jun 2020 13:45:49 -0400 Subject: [PATCH] docs(select-option): clarify that disabled does not apply for action sheets (#21584) resolves https://github.com/ionic-team/ionic/issues/21578 --- core/src/components.d.ts | 4 ++-- core/src/components/select-option/readme.md | 8 ++++---- core/src/components/select-option/select-option.tsx | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 4c65aa6fc7..76dbc79699 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -2124,7 +2124,7 @@ export namespace Components { } interface IonSelectOption { /** - * If `true`, the user cannot interact with the select option. + * If `true`, the user cannot interact with the select option. This property does not apply when `interface="action-sheet"` as `ion-action-sheet` does not allow for disabled buttons. */ "disabled": boolean; /** @@ -5421,7 +5421,7 @@ declare namespace LocalJSX { } interface IonSelectOption { /** - * If `true`, the user cannot interact with the select option. + * If `true`, the user cannot interact with the select option. This property does not apply when `interface="action-sheet"` as `ion-action-sheet` does not allow for disabled buttons. */ "disabled"?: boolean; /** diff --git a/core/src/components/select-option/readme.md b/core/src/components/select-option/readme.md index a4136576cf..8e6f54cf9c 100644 --- a/core/src/components/select-option/readme.md +++ b/core/src/components/select-option/readme.md @@ -654,10 +654,10 @@ To customize an individual option, set a class on the `ion-select-option`: ## Properties -| Property | Attribute | Description | Type | Default | -| ---------- | ---------- | ----------------------------------------------------------- | --------- | ----------- | -| `disabled` | `disabled` | If `true`, the user cannot interact with the select option. | `boolean` | `false` | -| `value` | `value` | The text value of the option. | `any` | `undefined` | +| Property | Attribute | Description | Type | Default | +| ---------- | ---------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------- | ----------- | +| `disabled` | `disabled` | If `true`, the user cannot interact with the select option. This property does not apply when `interface="action-sheet"` as `ion-action-sheet` does not allow for disabled buttons. | `boolean` | `false` | +| `value` | `value` | The text value of the option. | `any` | `undefined` | ---------------------------------------------- diff --git a/core/src/components/select-option/select-option.tsx b/core/src/components/select-option/select-option.tsx index f6d8f6d0b0..8e34f69e3c 100644 --- a/core/src/components/select-option/select-option.tsx +++ b/core/src/components/select-option/select-option.tsx @@ -14,7 +14,7 @@ export class SelectOption implements ComponentInterface { @Element() el!: HTMLElement; /** - * If `true`, the user cannot interact with the select option. + * If `true`, the user cannot interact with the select option. This property does not apply when `interface="action-sheet"` as `ion-action-sheet` does not allow for disabled buttons. */ @Prop() disabled = false;