From c473b3ed923bfbd41b800114a89e106c4edc7f7c Mon Sep 17 00:00:00 2001 From: Manu MA Date: Wed, 7 Aug 2019 20:00:15 +0200 Subject: [PATCH 1/3] chore(): add production build check (#19031) --- .scripts/release.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.scripts/release.js b/.scripts/release.js index 966aa7ad59..97c69b66fa 100644 --- a/.scripts/release.js +++ b/.scripts/release.js @@ -5,6 +5,7 @@ const tc = require('turbocolor'); const execa = require('execa'); const Listr = require('listr'); +const path = require('path'); const octokit = require('@octokit/rest')() const common = require('./common'); const fs = require('fs-extra'); @@ -16,6 +17,8 @@ async function main() { throw new Error('env.GH_TOKEN is undefined'); } + checkProductionRelease(); + const tasks = []; const { version } = common.readPkg('core'); const changelog = findChangelog(); @@ -39,6 +42,15 @@ async function main() { } } +function checkProductionRelease() { + const corePath = common.projectPath('core'); + const hasEsm = fs.existsSync(path.join(corePath, 'dist', 'esm')); + const hasEsmEs5 = fs.existsSync(path.join(corePath, 'dist', 'esm-es5')); + const hasCjs = fs.existsSync(path.join(corePath, 'dist', 'cjs')); + if (!hasEsm || !hasEsmEs5 || !hasCjs) { + throw new Error('core build is not a production build'); + } +} function publishGit(tasks, version, changelog) { const tag = `v${version}`; From 39f076847f1432f471040b28b4636cb89c0108a8 Mon Sep 17 00:00:00 2001 From: Manu MA Date: Wed, 7 Aug 2019 21:12:30 +0200 Subject: [PATCH 2/3] fix(): remove semicolons (#19033) --- core/src/components/card-title/card-title.tsx | 2 +- core/src/components/grid/grid.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/components/card-title/card-title.tsx b/core/src/components/card-title/card-title.tsx index a0b1c6d12d..c7bf333ad6 100644 --- a/core/src/components/card-title/card-title.tsx +++ b/core/src/components/card-title/card-title.tsx @@ -34,7 +34,7 @@ export class CardTitle implements ComponentInterface { [mode]: true }} > - ; + ); } diff --git a/core/src/components/grid/grid.tsx b/core/src/components/grid/grid.tsx index 624ed94d0c..acfbe9d221 100644 --- a/core/src/components/grid/grid.tsx +++ b/core/src/components/grid/grid.tsx @@ -23,7 +23,7 @@ export class Grid implements ComponentInterface { 'grid-fixed': this.fixed }} > - ; + ); } From c9f7c475719d8cc72569519cb460b12bb30deba4 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 7 Aug 2019 15:55:08 -0400 Subject: [PATCH 3/3] 4.7.4 --- CHANGELOG.md | 10 ++++++++++ angular/package.json | 4 ++-- core/package.json | 2 +- docs/package.json | 2 +- 4 files changed, 14 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cb6530dad8..266c65b3f0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,18 @@ +## [4.7.4](https://github.com/ionic-team/ionic/compare/v4.7.3...v4.7.4) (2019-08-07) + + +### Bug Fixes + +* **core:** remove extra semicolons being rendered ([#19033](https://github.com/ionic-team/ionic/issues/19033)) ([39f0768](https://github.com/ionic-team/ionic/commit/39f0768)) + + + ## [4.7.3](https://github.com/ionic-team/ionic/compare/v4.7.2...v4.7.3) (2019-08-07) * **core:** fix an issue with production builds of `@ionic/core` + ## [4.7.2](https://github.com/ionic-team/ionic/compare/v4.7.1...v4.7.2) (2019-08-07) diff --git a/angular/package.json b/angular/package.json index 777ecfe464..8826cc223b 100644 --- a/angular/package.json +++ b/angular/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular", - "version": "4.7.3", + "version": "4.7.4", "description": "Angular specific wrappers for @ionic/core", "keywords": [ "ionic", @@ -49,7 +49,7 @@ "css/" ], "dependencies": { - "@ionic/core": "4.7.3", + "@ionic/core": "4.7.4", "tslib": "^1.9.3" }, "peerDependencies": { diff --git a/core/package.json b/core/package.json index 51431f49c8..ee611baab5 100644 --- a/core/package.json +++ b/core/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/core", - "version": "4.7.3", + "version": "4.7.4", "description": "Base components for Ionic", "keywords": [ "ionic", diff --git a/docs/package.json b/docs/package.json index a88a3fa1f4..acd0b6ae3d 100644 --- a/docs/package.json +++ b/docs/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/docs", - "version": "4.7.3", + "version": "4.7.4", "description": "Pre-packaged API documentation for the Ionic docs.", "main": "core.json", "files": [