From f9deb1db417bf8ffc050adb1f6a9e563643be9a6 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 10 Apr 2023 14:27:00 -0400 Subject: [PATCH] test(radio): skip legacy flaky test (#27153) ## What is the current behavior? I forgot to skip the legacy radio test in https://github.com/ionic-team/ionic-framework/pull/27126. I also discovered we had duplicate flaky radio keyboard test tech debt tickets. https://github.com/ionic-team/ionic-framework/actions/runs/4658963827/jobs/8245309480?pr=27125 ## What is the new behavior? - skipped legacy radio test - closed FW-3956 in favor of FW-3747 ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information --- core/src/components/radio/test/legacy/a11y/radio.e2e.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/components/radio/test/legacy/a11y/radio.e2e.ts b/core/src/components/radio/test/legacy/a11y/radio.e2e.ts index ff431897ee..7e0a2739d1 100644 --- a/core/src/components/radio/test/legacy/a11y/radio.e2e.ts +++ b/core/src/components/radio/test/legacy/a11y/radio.e2e.ts @@ -1,7 +1,8 @@ import { expect } from '@playwright/test'; import { test } from '@utils/test/playwright'; -test.describe('radio: a11y', () => { +// TODO FW-3747 +test.describe.skip('radio: a11y', () => { test.beforeEach(({ skip }) => { skip.rtl(); }); @@ -21,8 +22,7 @@ test.describe('radio: a11y', () => { await page.keyboard.press(`Shift+${tabKey}`); await expect(firstGroupRadios.nth(0)).toBeFocused(); }); - // TODO FW-3956 - test.skip('using arrow keys should move between enabled radios within group', async ({ page, browserName }) => { + test('using arrow keys should move between enabled radios within group', async ({ page, browserName }) => { const tabKey = browserName === 'webkit' ? 'Alt+Tab' : 'Tab'; await page.goto(`/src/components/radio/test/legacy/a11y`);