From f93e4fdc64590898c9b3c1078ebfb7c323c31031 Mon Sep 17 00:00:00 2001 From: Manu MA Date: Fri, 14 Dec 2018 02:07:21 +0100 Subject: [PATCH] fix(datetime): picker inherits mode (#16731) fixes #16717 --- core/src/components/datetime/datetime.tsx | 1 + core/src/components/select/select.tsx | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/core/src/components/datetime/datetime.tsx b/core/src/components/datetime/datetime.tsx index 7134e1f00a..ae175513e4 100644 --- a/core/src/components/datetime/datetime.tsx +++ b/core/src/components/datetime/datetime.tsx @@ -274,6 +274,7 @@ export class Datetime implements ComponentInterface { private generatePickerOptions(): PickerOptions { const pickerOptions: PickerOptions = { ...this.pickerOptions, + mode: this.mode, columns: this.generateColumns() }; diff --git a/core/src/components/select/select.tsx b/core/src/components/select/select.tsx index 3344abd095..a919d54f84 100644 --- a/core/src/components/select/select.tsx +++ b/core/src/components/select/select.tsx @@ -206,6 +206,7 @@ export class Select implements ComponentInterface { const popoverOpts: PopoverOptions = { ...interfaceOptions, + mode: this.mode, component: 'ion-select-popover', cssClass: ['select-popover', interfaceOptions.cssClass], event: ev, @@ -255,6 +256,7 @@ export class Select implements ComponentInterface { const actionSheetOpts: ActionSheetOptions = { ...interfaceOptions, + mode: this.mode, buttons: actionSheetButtons, cssClass: ['select-action-sheet', interfaceOptions.cssClass] }; @@ -262,7 +264,6 @@ export class Select implements ComponentInterface { } private async openAlert() { - const label = this.getLabel(); const labelText = (label) ? label.textContent : null; @@ -272,6 +273,7 @@ export class Select implements ComponentInterface { const alertOpts: AlertOptions = { ...interfaceOptions, + mode: this.mode, header: interfaceOptions.header ? interfaceOptions.header : labelText, inputs: this.childOpts.map(o => { return {