javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 04:14:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(navcontroller): lazy loading is queued

Browse Source
This commit is contained in:
Manuel Mtz-Almeida
2017-04-09 12:10:57 +02:00
parent 5776f76ac9
commit f88823a30f
17 changed files with 649 additions and 571 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/navigation/view-controller.ts
View File

@ -541,26 +541,24 @@ export class ViewController {
/**
* @hidden
*/
_lifecycleTest(lifecycle: string): boolean | Promise<any> {
_lifecycleTest(lifecycle: string): Promise<any> {
const instance = this.instance;
const methodName = 'ionViewCan' + lifecycle;
if (instance && instance[methodName]) {
try {
var result = instance[methodName]();
if (result === false) {
return false;
} else if (result instanceof Promise) {
if (result instanceof Promise) {
return result;
} else {
return true;
// Any value but explitic false, should be true
return Promise.resolve(result !== false);
}
} catch (e) {
console.error(`${this.name} ${methodName} error: ${e.message}`);
return false;
return Promise.reject(`${this.name} ${methodName} error: ${e.message}`);
}
}
return true;
return Promise.resolve(true);
}
_lifecycle(lifecycle: string) {