diff --git a/CHANGELOG.md b/CHANGELOG.md index da7e508929..dd3a796d3f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,20 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.7.1](https://github.com/ionic-team/ionic-framework/compare/v6.7.0...v6.7.1) (2023-03-29) + + +### Bug Fixes + +* **item-sliding:** open method works with items added async ([#27035](https://github.com/ionic-team/ionic-framework/issues/27035)) ([521063b](https://github.com/ionic-team/ionic-framework/commit/521063bf241dc2c55bcd02a92ed8a418cfec6b1e)), closes [#26991](https://github.com/ionic-team/ionic-framework/issues/26991) +* **item:** use thumbnail's size when present ([#27014](https://github.com/ionic-team/ionic-framework/issues/27014)) ([6cecdf4](https://github.com/ionic-team/ionic-framework/commit/6cecdf41451a5c7aa908494dfad9fab1496a0c6c)), closes [#22935](https://github.com/ionic-team/ionic-framework/issues/22935) +* **radio-group:** radios participate in form submission ([#27018](https://github.com/ionic-team/ionic-framework/issues/27018)) ([3b99c31](https://github.com/ionic-team/ionic-framework/commit/3b99c31bab41bf7fcec340ac7159d3e8fce126c1)), closes [#27016](https://github.com/ionic-team/ionic-framework/issues/27016) +* **select:** inherit white-space in select-text to allow text wrapping ([#26973](https://github.com/ionic-team/ionic-framework/issues/26973)) ([19c1e25](https://github.com/ionic-team/ionic-framework/commit/19c1e25399ca18c8e6a8dd39c0131979c0bb01e9)), closes [#19949](https://github.com/ionic-team/ionic-framework/issues/19949) + + + + + # [7.0.0-rc.4](https://github.com/ionic-team/ionic-framework/compare/v7.0.0-rc.3...v7.0.0-rc.4) (2023-03-27) diff --git a/angular/CHANGELOG.md b/angular/CHANGELOG.md index 5591da91a6..f79c786c5b 100644 --- a/angular/CHANGELOG.md +++ b/angular/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.7.1](https://github.com/ionic-team/ionic/compare/v6.7.0...v6.7.1) (2023-03-29) + +**Note:** Version bump only for package @ionic/angular + + + + + # [7.0.0-rc.4](https://github.com/ionic-team/ionic/compare/v7.0.0-rc.3...v7.0.0-rc.4) (2023-03-27) **Note:** Version bump only for package @ionic/angular diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md index 8bbaa2ce64..af998d9be8 100644 --- a/core/CHANGELOG.md +++ b/core/CHANGELOG.md @@ -3,6 +3,19 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.7.1](https://github.com/ionic-team/ionic/compare/v6.7.0...v6.7.1) (2023-03-29) + + +### Bug Fixes +* **item-sliding:** open method works with items added async ([#27035](https://github.com/ionic-team/ionic/issues/27035)) ([521063b](https://github.com/ionic-team/ionic/commit/521063bf241dc2c55bcd02a92ed8a418cfec6b1e)), closes [#26991](https://github.com/ionic-team/ionic/issues/26991) +* **item:** use thumbnail's size when present ([#27014](https://github.com/ionic-team/ionic/issues/27014)) ([6cecdf4](https://github.com/ionic-team/ionic/commit/6cecdf41451a5c7aa908494dfad9fab1496a0c6c)), closes [#22935](https://github.com/ionic-team/ionic/issues/22935) +* **radio-group:** radios participate in form submission ([#27018](https://github.com/ionic-team/ionic/issues/27018)) ([3b99c31](https://github.com/ionic-team/ionic/commit/3b99c31bab41bf7fcec340ac7159d3e8fce126c1)), closes [#27016](https://github.com/ionic-team/ionic/issues/27016) +* **select:** inherit white-space in select-text to allow text wrapping ([#26973](https://github.com/ionic-team/ionic/issues/26973)) ([19c1e25](https://github.com/ionic-team/ionic/commit/19c1e25399ca18c8e6a8dd39c0131979c0bb01e9)), closes [#19949](https://github.com/ionic-team/ionic/issues/19949) + + + + + # [7.0.0-rc.4](https://github.com/ionic-team/ionic/compare/v7.0.0-rc.3...v7.0.0-rc.4) (2023-03-27) diff --git a/core/package-lock.json b/core/package-lock.json index e600419af5..aff907a414 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -18,7 +18,7 @@ "@ionic/eslint-config": "^0.3.0", "@ionic/prettier-config": "^2.0.0", "@jest/core": "^27.5.1", - "@playwright/test": "^1.32.0", + "@playwright/test": "^1.32.1", "@rollup/plugin-node-resolve": "^8.4.0", "@rollup/plugin-virtual": "^2.0.3", "@stencil/angular-output-target": "^0.6.0", @@ -1501,13 +1501,13 @@ } }, "node_modules/@playwright/test": { - "version": "1.32.0", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.32.0.tgz", - "integrity": "sha512-zOdGloaF0jeec7hqoLqM5S3L2rR4WxMJs6lgiAeR70JlH7Ml54ZPoIIf3X7cvnKde3Q9jJ/gaxkFh8fYI9s1rg==", + "version": "1.32.1", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.32.1.tgz", + "integrity": "sha512-FTwjCuhlm1qHUGf4hWjfr64UMJD/z0hXYbk+O387Ioe6WdyZQ+0TBDAc6P+pHjx2xCv1VYNgrKbYrNixFWy4Dg==", "dev": true, "dependencies": { "@types/node": "*", - "playwright-core": "1.32.0" + "playwright-core": "1.32.1" }, "bin": { "playwright": "cli.js" @@ -8150,14 +8150,14 @@ } }, "node_modules/playwright": { - "version": "1.32.0", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.32.0.tgz", - "integrity": "sha512-zQVzxTGoC/ak2Zu0l3CeBGQ6z5oOka5ecUOk+5QbmAerih6CaVsjY9BjjhiN+UOImd3xLiNeCcmLEWcXlz1Dlg==", + "version": "1.32.1", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.32.1.tgz", + "integrity": "sha512-GnEizysWMvoqHC3I9l8+4/ZxeLwLNdJJG76xdKGxzOcIZDcw5RSk/FKrFb5CuA+zcLpjIM2p9eR9Z4CuUDkWXg==", "dev": true, "hasInstallScript": true, "peer": true, "dependencies": { - "playwright-core": "1.32.0" + "playwright-core": "1.32.1" }, "bin": { "playwright": "cli.js" @@ -8167,9 +8167,9 @@ } }, "node_modules/playwright-core": { - "version": "1.32.0", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.32.0.tgz", - "integrity": "sha512-Z9Ij17X5Z3bjpp6XKujGBp9Gv4eViESac9aDmwgQFUEJBW0K80T21m/Z+XJQlu4cNsvPygw33b6V1Va6Bda5zQ==", + "version": "1.32.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.32.1.tgz", + "integrity": "sha512-KZYUQC10mXD2Am1rGlidaalNGYk3LU1vZqqNk0gT4XPty1jOqgup8KDP8l2CUlqoNKhXM5IfGjWgW37xvGllBA==", "dev": true, "bin": { "playwright": "cli.js" @@ -11398,14 +11398,14 @@ } }, "@playwright/test": { - "version": "1.32.0", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.32.0.tgz", - "integrity": "sha512-zOdGloaF0jeec7hqoLqM5S3L2rR4WxMJs6lgiAeR70JlH7Ml54ZPoIIf3X7cvnKde3Q9jJ/gaxkFh8fYI9s1rg==", + "version": "1.32.1", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.32.1.tgz", + "integrity": "sha512-FTwjCuhlm1qHUGf4hWjfr64UMJD/z0hXYbk+O387Ioe6WdyZQ+0TBDAc6P+pHjx2xCv1VYNgrKbYrNixFWy4Dg==", "dev": true, "requires": { "@types/node": "*", "fsevents": "2.3.2", - "playwright-core": "1.32.0" + "playwright-core": "1.32.1" } }, "@rollup/plugin-node-resolve": { @@ -16275,19 +16275,19 @@ } }, "playwright": { - "version": "1.32.0", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.32.0.tgz", - "integrity": "sha512-zQVzxTGoC/ak2Zu0l3CeBGQ6z5oOka5ecUOk+5QbmAerih6CaVsjY9BjjhiN+UOImd3xLiNeCcmLEWcXlz1Dlg==", + "version": "1.32.1", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.32.1.tgz", + "integrity": "sha512-GnEizysWMvoqHC3I9l8+4/ZxeLwLNdJJG76xdKGxzOcIZDcw5RSk/FKrFb5CuA+zcLpjIM2p9eR9Z4CuUDkWXg==", "dev": true, "peer": true, "requires": { - "playwright-core": "1.32.0" + "playwright-core": "1.32.1" } }, "playwright-core": { - "version": "1.32.0", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.32.0.tgz", - "integrity": "sha512-Z9Ij17X5Z3bjpp6XKujGBp9Gv4eViESac9aDmwgQFUEJBW0K80T21m/Z+XJQlu4cNsvPygw33b6V1Va6Bda5zQ==", + "version": "1.32.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.32.1.tgz", + "integrity": "sha512-KZYUQC10mXD2Am1rGlidaalNGYk3LU1vZqqNk0gT4XPty1jOqgup8KDP8l2CUlqoNKhXM5IfGjWgW37xvGllBA==", "dev": true }, "postcss": { diff --git a/core/package.json b/core/package.json index 65f45adc41..b924f1e656 100644 --- a/core/package.json +++ b/core/package.json @@ -40,7 +40,7 @@ "@ionic/eslint-config": "^0.3.0", "@ionic/prettier-config": "^2.0.0", "@jest/core": "^27.5.1", - "@playwright/test": "^1.32.0", + "@playwright/test": "^1.32.1", "@rollup/plugin-node-resolve": "^8.4.0", "@rollup/plugin-virtual": "^2.0.3", "@stencil/angular-output-target": "^0.6.0", diff --git a/core/src/components/alert/alert.tsx b/core/src/components/alert/alert.tsx index 1efcafbbb6..83b945c6b0 100644 --- a/core/src/components/alert/alert.tsx +++ b/core/src/components/alert/alert.tsx @@ -250,13 +250,13 @@ export class Alert implements ComponentInterface, OverlayInterface { // If hitting arrow down or arrow right, move to the next radio // If we're on the last radio, move to the first radio - if (['ArrowDown', 'ArrowRight'].includes(ev.code)) { + if (['ArrowDown', 'ArrowRight'].includes(ev.key)) { nextEl = index === radios.length - 1 ? radios[0] : radios[index + 1]; } // If hitting arrow up or arrow left, move to the previous radio // If we're on the first radio, move to the last radio - if (['ArrowUp', 'ArrowLeft'].includes(ev.code)) { + if (['ArrowUp', 'ArrowLeft'].includes(ev.key)) { nextEl = index === 0 ? radios[radios.length - 1] : radios[index - 1]; } diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts b/core/src/components/datetime/test/display/datetime.e2e.ts index ba004a346a..a8198316bb 100644 --- a/core/src/components/datetime/test/display/datetime.e2e.ts +++ b/core/src/components/datetime/test/display/datetime.e2e.ts @@ -8,6 +8,7 @@ test.describe('datetime: display', () => { await page.setContent(` `); + await page.waitForSelector('.datetime-ready'); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(`datetime-display-date-time-${page.getSnapshotSettings()}.png`); }); @@ -15,6 +16,7 @@ test.describe('datetime: display', () => { await page.setContent(` `); + await page.waitForSelector('.datetime-ready'); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(`datetime-display-time-date-${page.getSnapshotSettings()}.png`); }); @@ -22,6 +24,7 @@ test.describe('datetime: display', () => { await page.setContent(` `); + await page.waitForSelector('.datetime-ready'); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(`datetime-display-time-${page.getSnapshotSettings()}.png`); }); @@ -29,6 +32,7 @@ test.describe('datetime: display', () => { await page.setContent(` `); + await page.waitForSelector('.datetime-ready'); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(`datetime-display-date-${page.getSnapshotSettings()}.png`); }); @@ -46,6 +50,7 @@ test.describe('datetime: display', () => { await page.setContent(` `); + await page.waitForSelector('.datetime-ready'); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(`datetime-display-cover-date-time-${page.getSnapshotSettings()}.png`); }); @@ -53,6 +58,7 @@ test.describe('datetime: display', () => { await page.setContent(` `); + await page.waitForSelector('.datetime-ready'); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(`datetime-display-cover-time-date-${page.getSnapshotSettings()}.png`); }); @@ -60,6 +66,7 @@ test.describe('datetime: display', () => { await page.setContent(` `); + await page.waitForSelector('.datetime-ready'); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(`datetime-display-cover-time-${page.getSnapshotSettings()}.png`); }); @@ -67,6 +74,7 @@ test.describe('datetime: display', () => { await page.setContent(` `); + await page.waitForSelector('.datetime-ready'); const datetime = page.locator('ion-datetime'); await expect(datetime).toHaveScreenshot(`datetime-display-cover-date-${page.getSnapshotSettings()}.png`); }); diff --git a/core/src/components/item-divider/item-divider.md.scss b/core/src/components/item-divider/item-divider.md.scss index d6f19f27a0..fb5e19dc08 100644 --- a/core/src/components/item-divider/item-divider.md.scss +++ b/core/src/components/item-divider/item-divider.md.scss @@ -96,13 +96,11 @@ height: $item-md-avatar-height; } - // Material Design Item Divider Thumbnail // -------------------------------------------------- ::slotted(ion-thumbnail) { - width: $item-md-thumbnail-width; - height: $item-md-thumbnail-height; + --size: #{$item-md-thumbnail-size}; } // Material Design Item Divider Avatar/Thumbnail diff --git a/core/src/components/item-sliding/item-sliding.tsx b/core/src/components/item-sliding/item-sliding.tsx index abb8132f3e..3f671c0b1d 100644 --- a/core/src/components/item-sliding/item-sliding.tsx +++ b/core/src/components/item-sliding/item-sliding.tsx @@ -128,7 +128,16 @@ export class ItemSliding implements ComponentInterface { */ @Method() async open(side: Side | undefined) { - if (this.item === null) { + /** + * It is possible for the item to be added to the DOM + * after the item-sliding component was created. As a result, + * if this.item is null, then we should attempt to + * query for the ion-item again. + * However, if the item is already defined then + * we do not query for it again. + */ + const item = (this.item = this.item ?? this.el.querySelector('ion-item')); + if (item === null) { return; } diff --git a/core/src/components/item-sliding/test/async/index.html b/core/src/components/item-sliding/test/async/index.html new file mode 100644 index 0000000000..401e37dc96 --- /dev/null +++ b/core/src/components/item-sliding/test/async/index.html @@ -0,0 +1,49 @@ + + + + + Item Sliding - Async + + + + + + + + + + + + + Item Sliding - Basic + + + + + + + + Option + + + + + + + + + diff --git a/core/src/components/item-sliding/test/async/item-sliding.e2e.ts b/core/src/components/item-sliding/test/async/item-sliding.e2e.ts new file mode 100644 index 0000000000..ed83be79d4 --- /dev/null +++ b/core/src/components/item-sliding/test/async/item-sliding.e2e.ts @@ -0,0 +1,23 @@ +import { expect } from '@playwright/test'; +import { test } from '@utils/test/playwright'; + +test.describe('item-sliding: async', () => { + test('should open even when item is added async', async ({ page, skip }) => { + skip.rtl(); + skip.mode('md'); + + await page.goto(`/src/components/item-sliding/test/async`); + + const itemEl = page.locator('ion-item'); + const itemSlidingEl = page.locator('ion-item-sliding'); + + // Wait for item to be added to DOM + await page.waitForSelector('ion-item'); + + // Click item to open ion-item-sliding + await itemEl.click(); + + // This class is added when the item sliding component is fully open + await expect(itemSlidingEl).toHaveClass(/item-sliding-active-slide/); + }); +}); diff --git a/core/src/components/item/item.ios.scss b/core/src/components/item/item.ios.scss index 9f6440450b..eae9433a1a 100644 --- a/core/src/components/item/item.ios.scss +++ b/core/src/components/item/item.ios.scss @@ -154,8 +154,7 @@ font-size: 13px; } - -// iOS Item Avatar & Thumbnail +// iOS Item Avatar // -------------------------------------------------- ::slotted(ion-avatar) { @@ -163,11 +162,16 @@ height: $item-ios-avatar-height; } +// iOS Item Thumbnail +// -------------------------------------------------- + ::slotted(ion-thumbnail) { - width: $item-ios-thumbnail-width; - height: $item-ios-thumbnail-height; + --size: #{$item-ios-thumbnail-size}; } +// iOS Item Avatar/Thumbnail +// -------------------------------------------------- + ::slotted(ion-avatar[slot="end"]), ::slotted(ion-thumbnail[slot="end"]) { @include margin(($item-ios-padding-end * 0.5)); diff --git a/core/src/components/item/item.ios.vars.scss b/core/src/components/item/item.ios.vars.scss index abdbfb970a..8f6670f10e 100644 --- a/core/src/components/item/item.ios.vars.scss +++ b/core/src/components/item/item.ios.vars.scss @@ -33,11 +33,8 @@ $item-ios-avatar-width: 36px !default; /// @prop - Height of the avatar in the item $item-ios-avatar-height: $item-ios-avatar-width !default; -/// @prop - Width of the thumbnail in the item -$item-ios-thumbnail-width: 56px !default; - -/// @prop - Height of the thumbnail in the item -$item-ios-thumbnail-height: $item-ios-thumbnail-width !default; +/// @prop - Size of the thumbnail in the item +$item-ios-thumbnail-size: 56px !default; /// @prop - Color of the detail arrow icon $item-ios-detail-icon-color: $item-ios-border-color !default; diff --git a/core/src/components/item/item.md.scss b/core/src/components/item/item.md.scss index d78ce0557f..05f2c097db 100644 --- a/core/src/components/item/item.md.scss +++ b/core/src/components/item/item.md.scss @@ -258,7 +258,6 @@ @include padding-horizontal($item-md-note-end-slot-padding-start, $item-md-note-end-slot-padding-end); } - // Material Design Item Avatar // -------------------------------------------------- @@ -267,13 +266,11 @@ height: $item-md-avatar-height; } - // Material Design Item Thumbnail // -------------------------------------------------- ::slotted(ion-thumbnail) { - width: $item-md-thumbnail-width; - height: $item-md-thumbnail-height; + --size: #{$item-md-thumbnail-size}; } // Material Design Item Avatar/Thumbnail diff --git a/core/src/components/item/item.md.vars.scss b/core/src/components/item/item.md.vars.scss index 848480d257..8d225813e7 100644 --- a/core/src/components/item/item.md.vars.scss +++ b/core/src/components/item/item.md.vars.scss @@ -18,11 +18,8 @@ $item-md-avatar-width: 40px !default; /// @prop - Height of the avatar in the item $item-md-avatar-height: $item-md-avatar-width !default; -/// @prop - Width of the thumbnail in the item -$item-md-thumbnail-width: 56px !default; - -/// @prop - Height of the thumbnail in the item -$item-md-thumbnail-height: $item-md-thumbnail-width !default; +/// @prop - Size of the thumbnail in the item +$item-md-thumbnail-size: 56px !default; /// @prop - Color of the detail arrow icon $item-md-detail-icon-color: $item-md-border-color !default; diff --git a/core/src/components/popover/test/size/popover.e2e.ts b/core/src/components/popover/test/size/popover.e2e.ts index 6c77927a17..15842789a9 100644 --- a/core/src/components/popover/test/size/popover.e2e.ts +++ b/core/src/components/popover/test/size/popover.e2e.ts @@ -1,7 +1,7 @@ import { expect } from '@playwright/test'; import { test, Viewports } from '@utils/test/playwright'; -import { openPopover } from '../test.utils'; +import { openPopover, screenshotPopover } from '../test.utils'; test.describe('popover: size', async () => { /** @@ -22,7 +22,6 @@ test.describe('popover: size', async () => { await expect(page).toHaveScreenshot(`popover-size-${page.getSnapshotSettings()}.png`); // test this one separately since it would overlap others - // TODO FW-3598 - //await screenshotPopover(page, 'no-event-trigger', 'size'); + await screenshotPopover(page, 'no-event-trigger', 'size'); }); }); diff --git a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-ltr-Mobile-Chrome-linux.png index 02b84bf6ee..2047244fea 100644 Binary files a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-ltr-Mobile-Safari-linux.png index 39ef3b78bf..b39d597499 100644 Binary files a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-rtl-Mobile-Chrome-linux.png index df3cfa9e52..a7585f7476 100644 Binary files a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-rtl-Mobile-Safari-linux.png index ff2664ea8b..fe8a3dd54a 100644 Binary files a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/radio-group/radio-group.tsx b/core/src/components/radio-group/radio-group.tsx index 94747fcc8c..68bd2ad64a 100644 --- a/core/src/components/radio-group/radio-group.tsx +++ b/core/src/components/radio-group/radio-group.tsx @@ -147,13 +147,13 @@ export class RadioGroup implements ComponentInterface { // If hitting arrow down or arrow right, move to the next radio // If we're on the last radio, move to the first radio - if (['ArrowDown', 'ArrowRight'].includes(ev.code)) { + if (['ArrowDown', 'ArrowRight'].includes(ev.key)) { next = index === radios.length - 1 ? radios[0] : radios[index + 1]; } // If hitting arrow up or arrow left, move to the previous radio // If we're on the first radio, move to the last radio - if (['ArrowUp', 'ArrowLeft'].includes(ev.code)) { + if (['ArrowUp', 'ArrowLeft'].includes(ev.key)) { next = index === 0 ? radios[radios.length - 1] : radios[index - 1]; } @@ -168,7 +168,7 @@ export class RadioGroup implements ComponentInterface { // Update the radio group value when a user presses the // space bar on top of a selected radio - if (['Space'].includes(ev.code)) { + if ([' '].includes(ev.key)) { const previousValue = this.value; this.value = this.allowEmptySelection && this.value !== undefined ? undefined : current.value; if (previousValue !== this.value || this.allowEmptySelection) { diff --git a/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts index 79b200d561..4ddf1bba07 100644 --- a/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts +++ b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts @@ -24,4 +24,24 @@ test.describe('thumbnail: basic', () => { await expect(referenceEl).toHaveScreenshot(`thumbnail-ion-item-diff-${page.getSnapshotSettings()}.png`); }); + + test('size should be customizable in ', async ({ page, skip }) => { + skip.rtl(); + + test.info().annotations.push({ + type: 'issue', + description: 'https://github.com/ionic-team/ionic-framework/issues/22935', + }); + + await page.setContent(` + + + + + + `); + + const item = page.locator('ion-item'); + await expect(item).toHaveScreenshot(`thumbnail-ion-item-size-diff-${page.getSnapshotSettings()}.png`); + }); }); diff --git a/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..2b49479546 Binary files /dev/null and b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..f814c6f397 Binary files /dev/null and b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..e59497e1d4 Binary files /dev/null and b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..0ac78f4d53 Binary files /dev/null and b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..05ff9c2403 Binary files /dev/null and b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..f23ccdcce5 Binary files /dev/null and b/core/src/components/thumbnail/test/basic/thumbnail.e2e.ts-snapshots/thumbnail-ion-item-size-diff-md-ltr-Mobile-Safari-linux.png differ diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index dc8f39546c..390db85bfe 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.7.1](https://github.com/ionic-team/ionic-docs/compare/v6.7.0...v6.7.1) (2023-03-29) + +**Note:** Version bump only for package @ionic/docs + + + + + # [7.0.0-rc.4](https://github.com/ionic-team/ionic-docs/compare/v7.0.0-rc.3...v7.0.0-rc.4) (2023-03-27) **Note:** Version bump only for package @ionic/docs diff --git a/packages/angular-server/CHANGELOG.md b/packages/angular-server/CHANGELOG.md index d891f94697..b9f82ea5fc 100644 --- a/packages/angular-server/CHANGELOG.md +++ b/packages/angular-server/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.7.1](https://github.com/ionic-team/ionic/compare/v6.7.0...v6.7.1) (2023-03-29) + +**Note:** Version bump only for package @ionic/angular-server + + + + + # [7.0.0-rc.4](https://github.com/ionic-team/ionic/compare/v7.0.0-rc.3...v7.0.0-rc.4) (2023-03-27) **Note:** Version bump only for package @ionic/angular-server diff --git a/packages/react-router/CHANGELOG.md b/packages/react-router/CHANGELOG.md index a354037b54..b6fcd606fa 100644 --- a/packages/react-router/CHANGELOG.md +++ b/packages/react-router/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.7.1](https://github.com/ionic-team/ionic/compare/v6.7.0...v6.7.1) (2023-03-29) + +**Note:** Version bump only for package @ionic/react-router + + + + + # [7.0.0-rc.4](https://github.com/ionic-team/ionic/compare/v7.0.0-rc.3...v7.0.0-rc.4) (2023-03-27) **Note:** Version bump only for package @ionic/react-router diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md index 3e4b78f84d..8c09b41cf6 100644 --- a/packages/react/CHANGELOG.md +++ b/packages/react/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.7.1](https://github.com/ionic-team/ionic/compare/v6.7.0...v6.7.1) (2023-03-29) + +**Note:** Version bump only for package @ionic/react + + + + + # [7.0.0-rc.4](https://github.com/ionic-team/ionic/compare/v7.0.0-rc.3...v7.0.0-rc.4) (2023-03-27) **Note:** Version bump only for package @ionic/react diff --git a/packages/vue-router/CHANGELOG.md b/packages/vue-router/CHANGELOG.md index 09addf3578..c908587f10 100644 --- a/packages/vue-router/CHANGELOG.md +++ b/packages/vue-router/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.7.1](https://github.com/ionic-team/ionic/compare/v6.7.0...v6.7.1) (2023-03-29) + +**Note:** Version bump only for package @ionic/vue-router + + + + + # [7.0.0-rc.4](https://github.com/ionic-team/ionic/compare/v7.0.0-rc.3...v7.0.0-rc.4) (2023-03-27) **Note:** Version bump only for package @ionic/vue-router diff --git a/packages/vue/CHANGELOG.md b/packages/vue/CHANGELOG.md index 0c7f7de485..0d26cfb8f3 100644 --- a/packages/vue/CHANGELOG.md +++ b/packages/vue/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.7.1](https://github.com/ionic-team/ionic/compare/v6.7.0...v6.7.1) (2023-03-29) + +**Note:** Version bump only for package @ionic/vue + + + + + # [7.0.0-rc.4](https://github.com/ionic-team/ionic/compare/v7.0.0-rc.3...v7.0.0-rc.4) (2023-03-27) **Note:** Version bump only for package @ionic/vue