javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 10:41:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(lint): fix lint issues in nav

Browse Source
This commit is contained in:
Dan Bucholtz
2018-01-10 15:30:58 -06:00
parent e0ab78d3a3
commit f73e7774dc
1 changed files with 2 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/core/src/components/nav/nav.tsx
View File

@ -103,14 +103,12 @@ export class Nav implements PublicNav, NavContainer {
} }
this.init = true; this.init = true;
if (!this.useRouter) { if (!this.useRouter) {
console.log('componentDidLoadImpl: ', this.root);
componentDidLoadImpl(this); componentDidLoadImpl(this);
} }
} }
@Watch('root') @Watch('root')
updateRootComponent(): any { updateRootComponent(): any {
console.log('updateRootComponent: ', this.root);
if (this.init) { if (this.init) {
return this.setRoot(this.root); return this.setRoot(this.root);
} }
@ -195,11 +193,6 @@ export class Nav implements PublicNav, NavContainer {
return getFirstView(this); return getFirstView(this);
} }
@Method()
resize() {
console.log('resize content');
}
@Listen('navInit') @Listen('navInit')
navInitialized(event: CustomEvent) { navInitialized(event: CustomEvent) {
navInitializedImpl(this, event); navInitializedImpl(this, event);
@ -862,8 +855,7 @@ export function updateNavStacks(enteringView: ViewController, leavingView: ViewC
// batch all of lifecycles together // batch all of lifecycles together
if (destroyQueue && destroyQueue.length) { if (destroyQueue && destroyQueue.length) {
// TODO, figure out how the zone stuff should work in angular // TODO, figure out how the zone stuff should work in angular
for (let i = 0; i < destroyQueue.length; i++) { for (const view of destroyQueue) {
const view = destroyQueue[i];
view.willLeave(true); view.willLeave(true);
view.didLeave(); view.didLeave();
view.willUnload(); view.willUnload();
@ -879,11 +871,7 @@ export function updateNavStacks(enteringView: ViewController, leavingView: ViewC
}).then(() => { }).then(() => {
// set which animation it should use if it wasn't set yet // set which animation it should use if it wasn't set yet
if (ti.requiresTransition && !ti.opts.animation) { if (ti.requiresTransition && !ti.opts.animation) {
if (isDef(ti.removeStart)) { ti.opts.animation = isDef(ti.removeStart) ? (leavingView || enteringView).getTransitionName(ti.opts.direction) : (enteringView || leavingView).getTransitionName(ti.opts.direction);
ti.opts.animation = (leavingView || enteringView).getTransitionName(ti.opts.direction);
} else {
ti.opts.animation = (enteringView || leavingView).getTransitionName(ti.opts.direction);
}
} }
}); });
} }