From f6ec23774b33378241f827613d527124caf151be Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 17 Apr 2023 14:16:09 -0400 Subject: [PATCH] chore(template): separate issue url from body (#27216) Now that the default commit message uses the PR description, the conventional commit tool is getting confused when it sees other URLs and text that looks like issues (like hex colors). Using the `-------` separates the issue URL from the rest of the PR description and helps the conventional commits tool generate the changelog correctly. Example: https://github.com/ionic-team/ionic-framework/releases/tag/v7.0.3-nightly.20230417 `item: ios active state has correct contrast` has issue 000 as the issue the commit closes. This is happening because I mentioned the 000 hex color in the commit description. --- .github/PULL_REQUEST_TEMPLATE.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 35f2af36d1..2138de83e8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,3 +1,7 @@ +Issue URL: + +--------- + @@ -9,11 +13,6 @@ ## What is the current behavior? - - -Issue URL: - - ## What is the new behavior?