From f6678c4e2087ef55f123e6130121f560665412aa Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Tue, 25 Sep 2018 01:38:44 +0200 Subject: [PATCH] chore(): update componentd.d.ts --- core/src/components.d.ts | 7 ++++--- core/src/components/action-sheet/test/basic/e2e.ts | 6 +++--- core/src/components/back-button/readme.md | 14 +++++++------- core/src/components/nav/readme.md | 2 +- core/src/components/route/readme.md | 4 ++-- core/src/components/router/readme.md | 6 +++--- 6 files changed, 20 insertions(+), 19 deletions(-) diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 2075c004bb..fa0fbda4fe 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -1,9 +1,10 @@ /** -* This is an autogenerated file created by the Stencil compiler. -* It contains typing information for all components that exist in this project. -*/ + * This is an autogenerated file created by the Stencil compiler. + * It contains typing information for all components that exist in this project. + */ /* tslint:disable */ + import '@stencil/core'; import 'ionicons'; diff --git a/core/src/components/action-sheet/test/basic/e2e.ts b/core/src/components/action-sheet/test/basic/e2e.ts index 1a241f7018..58f7a77d42 100644 --- a/core/src/components/action-sheet/test/basic/e2e.ts +++ b/core/src/components/action-sheet/test/basic/e2e.ts @@ -14,14 +14,14 @@ it('action-sheet: basic', async () => { let compare = await page.compareScreenshot(); expect(compare).toMatchScreenshot(); - const backdrop = await page.find('ion-backdrop'); - await backdrop.click(); + await actionSheet.callMethod('dismiss'); - await actionSheet.callMethod('onDidDismiss'); + await actionSheet.waitForNotVisible(); compare = await page.compareScreenshot(`dismissed`); expect(compare).toMatchScreenshot(); actionSheet = await page.find('ion-action-sheet'); + expect(actionSheet).toBe(null); }); diff --git a/core/src/components/back-button/readme.md b/core/src/components/back-button/readme.md index f791912c1d..6ef37e1f2e 100644 --- a/core/src/components/back-button/readme.md +++ b/core/src/components/back-button/readme.md @@ -10,13 +10,13 @@ To change what is displayed in the back button, use the `text` and `icon` proper ## Properties -| Property | Attribute | Description | Type | -| ------------- | -------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------- | -| `color` | `color` | The color to use from your application's color palette. Default options are: `"primary"`, `"secondary"`, `"tertiary"`, `"success"`, `"warning"`, `"danger"`, `"light"`, `"medium"`, and `"dark"`. For more information on colors, see [theming](/docs/theming/basics). | `Color` | -| `defaultHref` | `default-href` | The url to navigate back to by default when there is no history. | `string` | -| `icon` | `icon` | The icon name to use for the back button. | `string` | -| `mode` | `mode` | The mode determines which platform styles to use. Possible values are: `"ios"` or `"md"`. | `Mode` | -| `text` | `text` | The text to display in the back button. | `string` | +| Property | Attribute | Description | Type | +| ------------- | -------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------- | +| `color` | `color` | The color to use from your application's color palette. Default options are: `"primary"`, `"secondary"`, `"tertiary"`, `"success"`, `"warning"`, `"danger"`, `"light"`, `"medium"`, and `"dark"`. For more information on colors, see [theming](/docs/theming/basics). | `Color` | +| `defaultHref` | `default-href` | The url to navigate back to by default when there is no history. | `string` | +| `icon` | `icon` | The icon name to use for the back button. | `string`, `null` | +| `mode` | `mode` | The mode determines which platform styles to use. Possible values are: `"ios"` or `"md"`. | `Mode` | +| `text` | `text` | The text to display in the back button. | `string`, `null` | ## CSS Custom Properties diff --git a/core/src/components/nav/readme.md b/core/src/components/nav/readme.md index c0963dd37f..6eb6a20cde 100644 --- a/core/src/components/nav/readme.md +++ b/core/src/components/nav/readme.md @@ -41,7 +41,7 @@ Unlike RouterOutlet, Nav is not tied to a particular router. Meaning that if we | `pop` | Call to navigate back from a current component. Similar to push(), you can also pass navigation options. | | `popTo` | Pop to a specific index in the navigation stack | | `popToRoot` | Navigate back to the root of the stack, no matter how far back that is. | -| `push` | Push a new component onto the current navigation stack. Pass any additional information along as an object. This additional information is accessible through NavParams | +| `push` | Push a new component onto the current navigation stack. Pass any additional information along as an object. This additional information is accessible through NavParams | | `removeIndex` | Removes a page from the nav stack at the specified index. | | `setPages` | Set the views of the current navigation stack and navigate to the last view. By default animations are disabled, but they can be enabled by passing options to the navigation controller.You can also pass any navigation params to the individual pages in the array. | | `setRoot` | Set the root for the current navigation stack. | diff --git a/core/src/components/route/readme.md b/core/src/components/route/readme.md index 8bc0f33716..b6b580ff34 100644 --- a/core/src/components/route/readme.md +++ b/core/src/components/route/readme.md @@ -18,8 +18,8 @@ Router is a component that can take a component, and render it when the Browser ## Events -| Event | Description | -| --------------------- | ------------------------------------------------------------------ | +| Event | Description | +| --------------------- | ------------------------------------------------------------------- | | `ionRouteDataChanged` | Used internally by `ion-router` to know when this route did change. | diff --git a/core/src/components/router/readme.md b/core/src/components/router/readme.md index ec00f518fb..830a0a3787 100644 --- a/core/src/components/router/readme.md +++ b/core/src/components/router/readme.md @@ -20,9 +20,9 @@ If you're using Angular, please see [ion-router-outlet](../router-outlet) instea ## Properties -| Property | Attribute | Description | Type | -| --------- | ---------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------- | -| `root` | `root` | By default `ion-router` will match the routes at the root path ("/"). That can be changed when | `string` | +| Property | Attribute | Description | Type | +| --------- | ---------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------- | +| `root` | `root` | By default `ion-router` will match the routes at the root path ("/"). That can be changed when | `string` | | `useHash` | `use-hash` | The router can work in two "modes": - With hash: `/index.html#/path/to/page` - Without hash: `/path/to/page` Using one or another might depend in the requirements of your app and/or where it's deployed. Usually "hash-less" navigation works better for SEO and it's more user friendly too, but it might requires additional server-side configuration in order to properly work. On the otherside hash-navigation is much easier to deploy, it even works over the file protocol. By default, this property is `true`, change to `false` to allow hash-less URLs. | `boolean` |