From f4d4c9c67541adea24b2a6ecaff08f087c21de4c Mon Sep 17 00:00:00 2001 From: Ken Sodemann Date: Tue, 7 Nov 2017 15:26:48 -0600 Subject: [PATCH] feat(e2e-tests): only open and close the driver once per run --- packages/core/scripts/e2e-test-runner.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/core/scripts/e2e-test-runner.js b/packages/core/scripts/e2e-test-runner.js index fdcf3183f9..817c8e97b8 100644 --- a/packages/core/scripts/e2e-test-runner.js +++ b/packages/core/scripts/e2e-test-runner.js @@ -8,6 +8,7 @@ const webdriver = require('selenium-webdriver'); const Snapshot = require('./Snapshot'); +let driver; let snapshot; let specIndex = 0; let takeScreenshots = false; @@ -53,7 +54,6 @@ function processCommandLine() { function registerE2ETest(desc, tst) { // NOTE: Do not use an arrow function here because: https://mochajs.org/#arrow-functions it(desc, async function() { - const driver = new webdriver.Builder().forBrowser('chrome').build(); await tst(driver); if (takeScreenshots) { await snapshot.takeScreenshot(driver, { @@ -61,7 +61,7 @@ function registerE2ETest(desc, tst) { specIndex: specIndex++ }); } - return driver.quit(); + return Promise.resolve(true); }); } @@ -77,6 +77,8 @@ async function run() { slow: 2000 }); + driver = new webdriver.Builder().forBrowser('chrome').build(); + processCommandLine(); const devServer = await startDevServer(); @@ -113,6 +115,7 @@ async function run() { process.exit(failures); // exit with non-zero status if there were failures }); devServer.close(); + driver.quit(); }); }); }