javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-22 13:32:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(slides): make slide method parameters optional

Browse Source 
references #5508
This commit is contained in:
Brandy Carney
2016-05-04 17:12:38 -06:00
parent ab82d532dc
commit f355087942
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ionic/components/slides/slides.ts
View File

@ -787,7 +787,7 @@ export class Slides extends Ion {
* @param {number} speed Transition duration (in ms). Optional. * @param {number} speed Transition duration (in ms). Optional.
* @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true. * @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true.
*/ */
slideTo(index: number, speed: number, runCallbacks: boolean) { slideTo(index: number, speed?: number, runCallbacks?: boolean) {
this.slider.slideTo(index, speed, runCallbacks); this.slider.slideTo(index, speed, runCallbacks);
} }
@ -797,7 +797,7 @@ export class Slides extends Ion {
* @param {number} speed Transition duration (in ms). Optional. * @param {number} speed Transition duration (in ms). Optional.
* @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true. * @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true.
*/ */
slideNext(speed: number, runCallbacks: boolean) { slideNext(speed?: number, runCallbacks?: boolean) {
this.slider.slideNext(runCallbacks, speed); this.slider.slideNext(runCallbacks, speed);
} }
@ -807,7 +807,7 @@ export class Slides extends Ion {
* @param {number} speed Transition duration (in ms). Optional. * @param {number} speed Transition duration (in ms). Optional.
* @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true. * @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true.
*/ */
slidePrev(speed: number, runCallbacks: boolean) { slidePrev(speed?: number, runCallbacks?: boolean) {
this.slider.slidePrev(runCallbacks, speed); this.slider.slidePrev(runCallbacks, speed);
} }

2
ionic/components/slides/test/controller/index.ts
View File

@ -49,5 +49,5 @@ class MyPage {
template: `<ion-nav [root]="root"></ion-nav>` template: `<ion-nav [root]="root"></ion-nav>`
}) })
class E2EApp { class E2EApp {
root: Page = MyPage; root: any = MyPage;
} }