javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-23 14:01:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(angular): enable TS strict

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-07-25 14:29:32 +02:00
parent a5898163b6
commit f1c2c0c1ba
11 changed files with 62 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
angular/src/providers/angular-delegate.ts
View File

@ -28,7 +28,7 @@ export class AngularFrameworkDelegate implements FrameworkDelegate {
constructor(
private resolver: ComponentFactoryResolver,
private injector: Injector,
private location: ViewContainerRef,
private location: ViewContainerRef | undefined,
private appRef: ApplicationRef,
private zone: NgZone,
) {}
@ -62,10 +62,10 @@ export class AngularFrameworkDelegate implements FrameworkDelegate {
export function attachView(
resolver: ComponentFactoryResolver,
injector: Injector,
location: ViewContainerRef|undefined,
location: ViewContainerRef | undefined,
appRef: ApplicationRef,
elRefMap: WeakMap<HTMLElement, any>,
container: any, component: any, params: any, cssClasses: string[]
container: any, component: any, params: any, cssClasses: string[] | undefined
) {
const factory = resolver.resolveComponentFactory(component);
const childInjector = Injector.create(getProviders(params), injector);
@ -78,8 +78,10 @@ export function attachView(
if (params) {
Object.assign(instance, params);
}
for (const clazz of cssClasses) {
hostElement.classList.add(clazz);
if (cssClasses) {
for (const clazz of cssClasses) {
hostElement.classList.add(clazz);
}
}
bindLifecycleEvents(instance, hostElement);
container.appendChild(hostElement);
@ -103,8 +105,8 @@ const LIFECYCLES = [
export function bindLifecycleEvents(instance: any, element: HTMLElement) {
LIFECYCLES.forEach(eventName => {
element.addEventListener(eventName, (ev: CustomEvent) => {
if (typeof instance[eventName] === 'function') {
element.addEventListener(eventName, (ev: any) => {
if (typeof instance[eventName] === 'function' && ev.detail) {
instance[eventName](ev.detail);
}
});