refactor(angular): enable TS strict

angular/src/directives/navigation/router-controller.ts

@@ -21,11 +21,12 @@ export class StackController {
       ref: enteringRef,
       element: (enteringRef && enteringRef.location && enteringRef.location.nativeElement) as HTMLElement,
       url: this.getUrl(route),
+      fullpath: document.location.pathname,
       deactivatedId: -1
     };
   }
 
-  getExistingView(activatedRoute: ActivatedRoute): RouteView|null {
+  getExistingView(activatedRoute: ActivatedRoute): RouteView | undefined {
     const activatedUrlKey = this.getUrl(activatedRoute);
     return this.views.find(vw => vw.url === activatedUrlKey);
   }
@@ -74,24 +75,28 @@ export class StackController {
   }
 
   private cleanup() {
+    const views = this.views;
     this.viewsSnapshot
-      .filter(view => !this.views.includes(view))
+      .filter(view => !views.includes(view))
       .forEach(view => destroyView(view));
 
-    for (const {element} of this.views) {
+    for (let i = 0; i < views.length - 1; i++) {
+      const element = views[i].element;
       element.setAttribute('aria-hidden', 'true');
       element.classList.add('ion-page-hidden');
     }
-    this.viewsSnapshot = this.views.slice();
+
+    this.viewsSnapshot = views.slice();
   }
 
-  getActive(): RouteView | null {
-    return this.views.length > 0 ? this.views[this.views.length - 1] : null;
+  getActive(): RouteView | undefined {
+    const views = this.views;
+    return views.length > 0 ? views[views.length - 1] : undefined;
   }
 
   private async transition(
-    enteringView: RouteView,
-    leavingView: RouteView,
+    enteringView: RouteView | undefined,
+    leavingView: RouteView | undefined,
     direction: number,
     animated: boolean,
     showGoBack: boolean
@@ -141,6 +146,7 @@ export function getLastDeactivatedRef(views: RouteView[]) {
 
 export interface RouteView {
   url: string;
+  fullpath: string;
   element: HTMLElement;
   ref: ComponentRef<any>;
   deactivatedId: number;

angular/src/directives/virtual-scroll/virtual-scroll.ts

@@ -41,18 +41,18 @@ export class VirtualScroll {
     ]);
   }
 
-  private nodeRender(el: HTMLElement|null, cell: any, index?: number) {
+  private nodeRender(el: HTMLElement|null, cell: any, index: number) {
     if (!el) {
       const node = this.itmTmp.viewContainer.createEmbeddedView(
         this.getComponent(cell.type),
-        new VirtualContext(null, null, null),
+        { $implicit: null, index },
         index
       );
       el = getElement(node);
       (el as any)['$ionView'] = node;
     }
     const node = (el as any)['$ionView'];
-    const ctx = node.context;
+    const ctx = node.context as VirtualContext;
     ctx.$implicit = cell.value;
     ctx.index = cell.index;
     node.detectChanges();
@@ -65,11 +65,11 @@ export class VirtualScroll {
       case 1: return this.hdrTmp.templateRef;
       case 2: return this.ftrTmp.templateRef;
     }
-    return null;
+    throw new Error('template for virtual item was not provided');
   }
 }
 
-function getElement(view: EmbeddedViewRef<VirtualContext>): HTMLElement {
+function getElement(view: EmbeddedViewRef<VirtualContext>): HTMLElement | null {
   const rootNodes = view.rootNodes;
   for (let i = 0; i < rootNodes.length; i++) {
     if (rootNodes[i].nodeType === 1) {

angular/src/directives/virtual-scroll/virtual-utils.ts

@@ -1,14 +1,5 @@
 
-export class VirtualContext {
-
-  constructor(public $implicit: any, public index: number, public count: number) { }
-
-  get first(): boolean { return this.index === 0; }
-
-  get last(): boolean { return this.index === this.count - 1; }
-
-  get even(): boolean { return this.index % 2 === 0; }
-
-  get odd(): boolean { return !this.even; }
-
+export interface VirtualContext {
+  $implicit: any;
+  index: number;
 }