From c6b15d63fe8ad182f6b50796ceecc426e7fa7c33 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Mon, 16 Nov 2015 15:42:59 -0500 Subject: [PATCH 01/12] refactor(item-groups): updated item groups demo to latest code --- .../item/test/groups/component-list.html | 10 ++++++---- ionic/components/item/test/groups/index.ts | 15 +++++++-------- ionic/components/item/test/groups/main.html | 2 +- 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/ionic/components/item/test/groups/component-list.html b/ionic/components/item/test/groups/component-list.html index 4fb57d1032..a7462260d8 100644 --- a/ionic/components/item/test/groups/component-list.html +++ b/ionic/components/item/test/groups/component-list.html @@ -4,10 +4,12 @@ {{data.day}} - Sessions -

{{session.name}}

-

- {{session.location}} -

+ diff --git a/ionic/components/item/test/groups/index.ts b/ionic/components/item/test/groups/index.ts index a9c7305aea..0be5ab9165 100644 --- a/ionic/components/item/test/groups/index.ts +++ b/ionic/components/item/test/groups/index.ts @@ -1,21 +1,20 @@ -import {ElementRef, Host} from 'angular2/angular2'; -import {Component, View, NgIf, NgFor} from 'angular2/angular2'; -import {App, Content, Icon, Item, ItemGroup, ItemGroupTitle, ItemSliding, List, ListHeader, NavController} from 'ionic/ionic'; +import {Component, NgIf, NgFor} from 'angular2/angular2'; +import {App, Icon, Item, ItemGroup, ItemGroupTitle, ItemSliding, List, ListHeader, NavController} from 'ionic/ionic'; @Component({ properties: ['data'], selector: 'component-list', - directives: [ComponentList, Item, ItemGroup, ItemGroupTitle, ItemSliding, List, NgIf, NgFor], + directives: [Item, ItemGroup, ItemGroupTitle, ItemSliding, List, NgIf, NgFor], templateUrl: 'component-list.html' }) -class ComponentList { - constructor(elementRef: ElementRef, @Host() content:Content) { - console.log('Component List init', content); +export class ComponentList { + constructor() { + } } @App({ - directives: [Content, ComponentList, Item, ItemGroup, ItemGroupTitle, ItemSliding, List, NgIf, NgFor], + directives: [ComponentList], templateUrl: 'main.html' }) class E2EApp { diff --git a/ionic/components/item/test/groups/main.html b/ionic/components/item/test/groups/main.html index fb598a56a6..db54c5f87a 100644 --- a/ionic/components/item/test/groups/main.html +++ b/ionic/components/item/test/groups/main.html @@ -1,4 +1,4 @@ +Item Groups -

Component List

From 83164132e4686dd8b7d73f6805df1d524d5e6065 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Mon, 16 Nov 2015 15:43:35 -0500 Subject: [PATCH 02/12] refactor(item-buttons): moved items outside of list in the buttons example references #387 --- ionic/components/item/test/buttons/main.html | 152 +++++++++---------- 1 file changed, 74 insertions(+), 78 deletions(-) diff --git a/ionic/components/item/test/buttons/main.html b/ionic/components/item/test/buttons/main.html index cb176c17a8..e11cb28a7a 100644 --- a/ionic/components/item/test/buttons/main.html +++ b/ionic/components/item/test/buttons/main.html @@ -1,91 +1,87 @@ Items as Links/Buttons - + + a[ion-item] + - - a[ion-item] - + + a[ion-item].activated + - - a[ion-item].activated - + - + + + + Inner Buttons + + + + + - - + - - - Inner Buttons - - + + + right icon buttons + + - - - left icon buttons - - + + + icon only buttons + + - - - right icon buttons - - + + ion-item right icon/text button + + - - - icon only buttons - - + + + ion-item left clear button + - - ion-item right icon/text button - - + + ion-item right clear button + + - - - ion-item left clear button - - - - ion-item right clear button - - - - - This is multiline text that has a - long description of about how the text is really long - and a link. - - - - + + This is multiline text that has a + long description of about how the text is really long + and a link. + + From 85bd3fbfec5920427f0fca01206b7d0c868b541f Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Mon, 16 Nov 2015 15:49:07 -0500 Subject: [PATCH 03/12] refactor(item): removed list from item tests that don't need it references #387 --- ionic/components/item/test/buttons/main.html | 152 ++++++++++--------- ionic/components/item/test/icons/main.html | 4 +- ionic/components/item/test/images/main.html | 4 +- ionic/components/item/test/media/main.html | 10 +- ionic/components/item/test/text/main.html | 90 ++++++----- 5 files changed, 127 insertions(+), 133 deletions(-) diff --git a/ionic/components/item/test/buttons/main.html b/ionic/components/item/test/buttons/main.html index e11cb28a7a..459d935d1c 100644 --- a/ionic/components/item/test/buttons/main.html +++ b/ionic/components/item/test/buttons/main.html @@ -1,87 +1,91 @@ Items as Links/Buttons - - a[ion-item] - + - - a[ion-item].activated - + + a[ion-item] + - + + a[ion-item].activated + - - - - - Inner Buttons - - - - - - left icon buttons - - - - - right icon buttons - - - - - icon only buttons - - + + + Inner Buttons + + - - ion-item right icon/text button - - + + + left icon buttons + + - - - ion-item left clear button - + + + right icon buttons + + - - ion-item right clear button - - + + + icon only buttons + + - - This is multiline text that has a - long description of about how the text is really long - and a link. - - + + ion-item right icon/text button + + + + + + ion-item left clear button + + + + ion-item right clear button + + + + + This is multiline text that has a + long description of about how the text is really long + and a link. + + + + diff --git a/ionic/components/item/test/icons/main.html b/ionic/components/item/test/icons/main.html index e23e172f74..e98b67a447 100644 --- a/ionic/components/item/test/icons/main.html +++ b/ionic/components/item/test/icons/main.html @@ -1,6 +1,6 @@ Item Icons - + ion-item [detail-push] attr @@ -67,4 +67,4 @@ 99 - + diff --git a/ionic/components/item/test/images/main.html b/ionic/components/item/test/images/main.html index 615d71962a..53fa230b4b 100644 --- a/ionic/components/item/test/images/main.html +++ b/ionic/components/item/test/images/main.html @@ -1,6 +1,6 @@ Item Images - + Plain Ol' div w/ some text, no images @@ -58,7 +58,7 @@

Paragraph text.

-
+