javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 11:17:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix some angular (#16615)

Browse Source 
* fix(angular): platform types

fixes #16535

* fix(angular): memory leak in lifecycle events

fixes #16285

* fix ci

* single core
This commit is contained in:
Manu MA
2018-12-06 22:19:35 +01:00
committed by GitHub
parent 119e0c1fd2
commit edf3659949
4 changed files with 44 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
angular/src/util/util.ts
View File

@ -1,4 +1,5 @@
import { ElementRef, EventEmitter } from '@angular/core';
import { ElementRef } from '@angular/core';
import { Subject } from 'rxjs';
export function inputs(instance: any, el: ElementRef, props: string[]) {
props.forEach(propName => {
@ -8,13 +9,12 @@ export function inputs(instance: any, el: ElementRef, props: string[]) {
});
}
export function proxyEvent<T>(emitter: EventEmitter<T>, el: EventTarget, eventName: string) {
export function proxyEvent<T>(emitter: Subject<T>, el: EventTarget, eventName: string) {
el.addEventListener(eventName, (ev) => {
emitter.emit(ev ? (ev as any).detail as T : undefined);
emitter.next(ev ? (ev as any).detail as T : undefined);
});
}
export function proxyMethod(ctrlName: string, methodName: string, ...args: any[]) {
const controller = ensureElementInBody(ctrlName);
return controller.componentOnReady()