javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-21 04:53:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(menu-button): screen readers now properly announce menu button (#21324)

Browse Source
This commit is contained in:
Liam DeBeasi
2020-05-18 12:43:02 -04:00
committed by GitHub
parent 3937101e5c
commit eaf4fb6b2a
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/components/menu-button/menu-button.tsx
View File

@ -95,10 +95,11 @@ export class MenuButton implements ComponentInterface, ButtonInterface {
{...attrs} {...attrs}
disabled={disabled} disabled={disabled}
class="button-native" class="button-native"
aria-label="menu"
> >
<span class="button-inner"> <span class="button-inner">
<slot> <slot>
<ion-icon icon={menuIcon} mode={mode} lazy={false}></ion-icon> <ion-icon icon={menuIcon} mode={mode} lazy={false} aria-hidden="true"></ion-icon>
</slot> </slot>
</span> </span>
{mode === 'md' && <ion-ripple-effect type="unbounded"></ion-ripple-effect>} {mode === 'md' && <ion-ripple-effect type="unbounded"></ion-ripple-effect>}