javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-23 14:01:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(framework-delegate): wrap user element with ion-page for modal and nav

Browse Source
This commit is contained in:
Dan Bucholtz
2018-01-04 13:01:31 -06:00
parent ebfb54ff21
commit e64944d6de
6 changed files with 62 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/react/src/react-framework-delegate.ts
View File

@ -2,10 +2,9 @@ import React from 'react';
import ReactDOM from 'react-dom';
import { FrameworkDelegate } from '@ionic/core';
import { isElementModal, isElementNav } from './utils/helpers';
export function attachViewToDom(parentElement: HTMLElement, reactComponent: any, propsOrData: any, classesToAdd: string[]) {
console.log('parentElement: ', parentElement);
console.log('reactComponent: ', reactComponent);
const wrappingDiv = shouldWrapInIonPage(parentElement) ? document.createElement('ion-page') : document.createElement('div');
if (classesToAdd) {
for (const clazz of classesToAdd) {
@ -41,8 +40,5 @@ export { Delegate }
export function shouldWrapInIonPage(element: HTMLElement) {
if (element.tagName.toUpperCase() === 'ION-NAV' || element.classList.contains('modal-wrapper')) {
return true;
}
return false;
}
return isElementModal(element) || isElementNav(element);
}