javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-22 21:48:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(ViewController): remove need for viewType property

Browse Source
This commit is contained in:
Adam Bradley
2016-06-16 15:26:16 -05:00
parent d13fa4e2cf
commit e5d79d28c0
10 changed files with 16 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/components/nav/nav-controller.ts
View File

@ -1201,10 +1201,6 @@ export class NavController extends Ion {
this.setTransitioning(!enableApp, duration);
}
if (enteringView.viewType) {
transAnimation.before.addClass(enteringView.viewType);
}
// create a callback for when the animation is done
transAnimation.onFinish((trans: Transition) => {
// transition animation has ended
@ -1472,8 +1468,8 @@ export class NavController extends Ion {
return;
}
// automatically set "ion-page" selector
// TODO: see about having this set using ComponentFactory
// TEMPORARY: automatically set selector w/ dah reflector
// TODO: use componentFactory.create once fixed
addSelector(view.componentType, 'ion-page');
this._compiler.resolveComponent(view.componentType).then(componentFactory => {